MC-33405: review_entity_summary table has no unique key entity_pk_value-entity_type-store_id and may contain duplicate rows

Author: nikita-shcherbatykh

app/code/Magento/Review/Model/ResourceModel/Review.php

@@ -361,12 +361,12 @@ protected function aggregateReviewSummary($object, $ratingSummaryObject)
         );
         $select = $connection->select()->from($this->_aggregateTable)
             ->where('entity_pk_value = :pk_value')
-            ->where('entity_type = :entity_type')
-            ->where('store_id = :store_id');
+            ->where('store_id = :store_id')
+            ->where('entity_type = :entity_type');
         $bind = [
             ':pk_value' => $object->getEntityPkValue(),
-            ':entity_type' => $object->getEntityId(),
             ':store_id' => $ratingSummaryObject->getStoreId(),
+            ':entity_type' => $object->getEntityId(),
         ];
         $oldData = $connection->fetchRow($select, $bind);
         $data = new \Magento\Framework\DataObject();
@@ -424,6 +424,7 @@ protected function _loadVotedRatingIds($reviewId)
 
     /**
      * Aggregate this review's ratings.
+     *
      * Useful, when changing the review.
      *
      * @param int[] $ratingIds
@@ -471,6 +472,7 @@ public function getEntityIdByCode($entityCode)
 
     /**
      * Delete reviews by product id.
+     *
      * Better to call this method in transaction, because operation performed on two separated tables
      *
      * @param int $productId

app/code/Magento/Review/Setup/Patch/Schema/AddUniqueConstraintToReviewEntitySummary.php

@@ -0,0 +1,91 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Review\Setup\Patch\Schema;
+
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Magento\Framework\Setup\Patch\SchemaPatchInterface;
+use Magento\Framework\Setup\SchemaSetupInterface;
+
+/**
+ * Schema patch to add unique constraint (entity_pk_value, store_id, entity_type) to review_entity_summary.
+ */
+class AddUniqueConstraintToReviewEntitySummary implements SchemaPatchInterface
+{
+    /**
+     * Table name to modify
+     */
+    private const TABLE = 'review_entity_summary';
+    /**
+     * Columns to be unique
+     */
+    private const COLUMNS = [
+        'entity_pk_value',
+        'store_id',
+        'entity_type',
+    ];
+
+    /**
+     * @var SchemaSetupInterface
+     */
+    private $setup;
+
+    /**
+     * @param SchemaSetupInterface $setup
+     */
+    public function __construct(
+        SchemaSetupInterface $setup
+    ) {
+        $this->setup = $setup;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function apply()
+    {
+        $this->setup->startSetup();
+        $this->addUniqueKey();
+        $this->setup->endSetup();
+        return $this;
+    }
+
+    /**
+     * Add unique constraint (entity_pk_value, store_id, entity_type) to review_entity_summary.
+     *
+     * Remove duplicate entries if any and retries until the unique key is successfully added.
+     */
+    private function addUniqueKey(): void
+    {
+        $this->setup->getConnection()->addIndex(
+            $this->setup->getTable(self::TABLE),
+            $this->setup->getIdxName(
+                self::TABLE,
+                self::COLUMNS,
+                AdapterInterface::INDEX_TYPE_UNIQUE
+            ),
+            self::COLUMNS,
+            AdapterInterface::INDEX_TYPE_UNIQUE
+        );
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public static function getDependencies()
+    {
+        return [];
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getAliases()
+    {
+        return [];
+    }
+}