Merge branch 'MAGETWO-35023-Code-Coverage-Guest-Sales-And-Checkout-APIs' of github.scm.corp.ebay.com:magento-api/magento2ce into MAGETWO-35023-Code-Coverage-Guest-Sales-And-Checkout-APIs

Author: Cari Spruiell

app/code/Magento/Quote/Test/Unit/Model/GuestCart/GuestBillingAddressManagementTest.php

@@ -88,7 +88,7 @@ public function testGet()
     /**
      * @return void
      */
-    public function testAssing()
+    public function testAssign()
     {
         $addressId = 1;
         $this->billingAddressManagementMock->expects($this->once())->method('assign')->willReturn($addressId);

app/code/Magento/Quote/Test/Unit/Model/GuestCart/GuestCartTotalRepositoryTest.php

@@ -36,45 +36,37 @@ class GuestCartTotalRepositoryTest extends \PHPUnit_Framework_TestCase
     /**
      * @var string
      */
-    protected $maskedCartId = 'f216207248d65c789b17be8545e0aa73';
+    protected $maskedCartId;
 
     /**
      * @var int
      */
-    protected $cartId = 12;
+    protected $cartId;
 
     public function setUp()
     {
         $this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
 
-        $this->quoteIdMaskFactoryMock = $this->getMockBuilder('Magento\Quote\Model\QuoteIdMaskFactory')
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->quoteIdMaskMock = $this->getMockBuilder('Magento\Quote\Model\QuoteIdMask')
-            ->disableOriginalConstructor()
-            ->getMock();
         $this->cartTotalRepository = $this->getMockBuilder('Magento\Quote\Api\CartTotalRepositoryInterface')
             ->disableOriginalConstructor()
             ->getMock();
 
+        $this->maskedCartId = 'f216207248d65c789b17be8545e0aa73';
+        $this->cartId = 123;
+
+        $guestCartTestHelper = new GuestCartTestHelper($this);
+        list($this->quoteIdMaskFactoryMock, $this->quoteIdMaskMock) = $guestCartTestHelper->mockQuoteIdMask(
+            $this->maskedCartId,
+            $this->cartId
+        );
+
         $this->model = $this->objectManager->getObject(
             'Magento\Quote\Model\GuestCart\GuestCartTotalRepository',
             [
                 'cartTotalRepository' => $this->cartTotalRepository,
                 'quoteIdMaskFactory' => $this->quoteIdMaskFactoryMock,
             ]
         );
-
-        $this->quoteIdMaskFactoryMock->expects($this->once())
-            ->method('create')
-            ->willReturn($this->quoteIdMaskMock);
-        $this->quoteIdMaskMock->expects($this->once())
-            ->method('load')
-            ->with($this->maskedCartId, 'masked_id')
-            ->willReturn($this->quoteIdMaskMock);
-        $this->quoteIdMaskMock->expects($this->once())
-            ->method('getId')
-            ->willReturn($this->cartId);
     }
 
     public function testGetTotals()

app/code/Magento/Quote/Test/Unit/Model/GuestCart/GuestShippingMethodManagementTest.php

@@ -46,33 +46,23 @@ protected function setUp()
         $this->shippingMethodManagementMock =
             $this->getMockBuilder('Magento\Quote\Api\ShippingMethodManagementInterface')
             ->getMockForAbstractClass();
-        $this->quoteIdMaskFactoryMock = $this->getMockBuilder('Magento\Quote\Model\QuoteIdMaskFactory')
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->quoteIdMaskMock = $this->getMockBuilder('Magento\Quote\Model\QuoteIdMask')
-            ->disableOriginalConstructor()
-            ->getMock();
+
+        $this->maskedCartId = 'f216207248d65c789b17be8545e0aa73';
+        $this->cartId = 867;
+
+        $guestCartTestHelper = new GuestCartTestHelper($this);
+        list($this->quoteIdMaskFactoryMock, $this->quoteIdMaskMock) = $guestCartTestHelper->mockQuoteIdMask(
+            $this->maskedCartId,
+            $this->cartId
+        );
+
         $this->model = $objectManager->getObject(
             'Magento\Quote\Model\GuestCart\GuestShippingMethodManagement',
             [
                 'shippingMethodManagement' => $this->shippingMethodManagementMock,
                 'quoteIdMaskFactory' => $this->quoteIdMaskFactoryMock,
             ]
         );
-
-        $this->maskedCartId = 'f216207248d65c789b17be8545e0aa73';
-        $this->cartId = 867;
-
-        $this->quoteIdMaskFactoryMock->expects($this->once())
-            ->method('create')
-            ->willReturn($this->quoteIdMaskMock);
-        $this->quoteIdMaskMock->expects($this->once())
-            ->method('load')
-            ->with($this->maskedCartId, 'masked_id')
-            ->willReturn($this->quoteIdMaskMock);
-        $this->quoteIdMaskMock->expects($this->once())
-            ->method('getId')
-            ->willReturn($this->cartId);
     }
 
     public function testSet()