[fix] "Numeric value out of range" on mass delete

asubit · web-flow · commit 60704e8858ba · 2017-01-09T16:24:07.000+01:00
From Backend area the following error occurred on mass delete all products : "SQLSTATE[22003]: Numeric value out of range: 1690 BIGINT UNSIGNED value is out of range"
diff --git a/app/code/Magento/Quote/Model/ResourceModel/Quote.php b/app/code/Magento/Quote/Model/ResourceModel/Quote.php
@@ -242,14 +242,17 @@ public function substractProductFromQuotes($product)
         }
         $connection = $this->getConnection();
         $subSelect = $connection->select();
+        $conditionCheck = $connection->quoteIdentifier('q.items_count') . " > 0";
+        $conditionTrue = $connection->quoteIdentifier('q.items_count') . ' - 1';
+        $ifSql = "IF (" . $conditionCheck . "," . $conditionTrue . ", 0)";
 
         $subSelect->from(
             false,
             [
                 'items_qty' => new \Zend_Db_Expr(
                     $connection->quoteIdentifier('q.items_qty') . ' - ' . $connection->quoteIdentifier('qi.qty')
                 ),
-                'items_count' => new \Zend_Db_Expr($connection->quoteIdentifier('q.items_count') . ' - 1')
+                'items_count' => new \Zend_Db_Expr($ifSql)
             ]
         )->join(
             ['qi' => $this->getTable('quote_item')],

Original file line number	Diff line number	Diff line change
`@@ -242,14 +242,17 @@ public function substractProductFromQuotes($product)`
`242`	`242`	`}`
`243`	`243`	`$connection = $this->getConnection();`
`244`	`244`	`$subSelect = $connection->select();`
	`245`	`+ $conditionCheck = $connection->quoteIdentifier('q.items_count') . " > 0";`
	`246`	`+ $conditionTrue = $connection->quoteIdentifier('q.items_count') . ' - 1';`
	`247`	`+ $ifSql = "IF (" . $conditionCheck . "," . $conditionTrue . ", 0)";`
`245`	`248`
`246`	`249`	`$subSelect->from(`
`247`	`250`	`false,`
`248`	`251`	`[`
`249`	`252`	`'items_qty' => new \Zend_Db_Expr(`
`250`	`253`	`$connection->quoteIdentifier('q.items_qty') . ' - ' . $connection->quoteIdentifier('qi.qty')`
`251`	`254`	`),`
`252`		`- 'items_count' => new \Zend_Db_Expr($connection->quoteIdentifier('q.items_count') . ' - 1')`
	`255`	`+ 'items_count' => new \Zend_Db_Expr($ifSql)`
`253`	`256`	`]`
`254`	`257`	`)->join(`
`255`	`258`	`['qi' => $this->getTable('quote_item')],`