- fix: field names should not be camel case

Prabhu Ram · Prabhu Ram · commit 5f8682897f3c · 2020-08-05T18:10:44.000-05:00
diff --git a/app/code/Magento/QuoteGraphQl/Model/Resolver/AddProductsToCart.php b/app/code/Magento/QuoteGraphQl/Model/Resolver/AddProductsToCart.php
@@ -78,7 +78,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
             'cart' => [
                 'model' => $addProductsToCartOutput->getCart(),
             ],
-            'userInputErrors' => array_map(
+            'user_errors' => array_map(
                 function (Error $error) {
                     return [
                         'code' => $error->getCode(),
diff --git a/app/code/Magento/QuoteGraphQl/etc/schema.graphqls b/app/code/Magento/QuoteGraphQl/etc/schema.graphqls
@@ -375,12 +375,12 @@ type Order {
 
 type CartUserInputError @doc(description:"An error encountered while adding an item to the the cart.") {
     message: String! @doc(description: "A localized error message")
-    code: CartUserInputErrorType! @doc(description: "Checkout-specific error code")
+    code: CartUserInputErrorType! @doc(description: "Cart-specific error code")
 }
 
 type AddProductsToCartOutput {
     cart: Cart! @doc(description: "The cart after products have been added")
-    userInputErrors:[CartUserInputError]! @doc(description: "An error encountered while adding an item to the cart.")
+    user_errors: [CartUserInputError!]! @doc(description: "An error encountered while adding an item to the cart.")
 }
 
 enum CartUserInputErrorType {
diff --git a/app/code/Magento/WishlistGraphQl/Model/Resolver/AddProductsToWishlist.php b/app/code/Magento/WishlistGraphQl/Model/Resolver/AddProductsToWishlist.php
@@ -105,7 +105,7 @@ public function resolve(
 
         return [
             'wishlist' => $this->wishlistDataMapper->map($wishlistOutput->getWishlist()),
-            'userInputErrors' => array_map(
+            'user_errors' => array_map(
                 function (Error $error) {
                     return [
                         'code' => $error->getCode(),
diff --git a/app/code/Magento/WishlistGraphQl/Model/Resolver/RemoveProductsFromWishlist.php b/app/code/Magento/WishlistGraphQl/Model/Resolver/RemoveProductsFromWishlist.php
@@ -109,7 +109,7 @@ public function resolve(
 
         return [
             'wishlist' => $this->wishlistDataMapper->map($wishlistOutput->getWishlist()),
-            'userInputErrors' => \array_map(
+            'user_errors' => \array_map(
                 function (Error $error) {
                     return [
                         'code' => $error->getCode(),
diff --git a/app/code/Magento/WishlistGraphQl/Model/Resolver/UpdateProductsInWishlist.php b/app/code/Magento/WishlistGraphQl/Model/Resolver/UpdateProductsInWishlist.php
@@ -110,7 +110,7 @@ public function resolve(
 
         return [
             'wishlist' => $this->wishlistDataMapper->map($wishlistOutput->getWishlist()),
-            'userInputErrors' => \array_map(
+            'user_errors' => \array_map(
                 function (Error $error) {
                     return [
                         'code' => $error->getCode(),
diff --git a/app/code/Magento/WishlistGraphQl/etc/schema.graphqls b/app/code/Magento/WishlistGraphQl/etc/schema.graphqls
@@ -49,12 +49,12 @@ input WishlistItemInput @doc(description: "Defines the items to add to a wish li
 
 type AddProductsToWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered") {
     wishlist: Wishlist! @doc(description: "Contains the wish list with all items that were successfully added")
-    userInputErrors:[WishListUserInputError]! @doc(description: "An array of errors encountered while adding products to a wish list")
+    user_errors:[WishListUserInputError!]! @doc(description: "An array of errors encountered while adding products to a wish list")
 }
 
 type RemoveProductsFromWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered") {
     wishlist: Wishlist! @doc(description: "Contains the wish list with after items were successfully deleted")
-    userInputErrors:[WishListUserInputError]! @doc(description:"An array of errors encountered while deleting products from a wish list")
+    user_errors:[WishListUserInputError!]! @doc(description:"An array of errors encountered while deleting products from a wish list")
 }
 
 input WishlistItemUpdateInput @doc(description: "Defines updates to items in a wish list") {
@@ -67,7 +67,7 @@ input WishlistItemUpdateInput @doc(description: "Defines updates to items in a w
 
 type UpdateProductsInWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered") {
     wishlist: Wishlist! @doc(description: "Contains the wish list with all items that were successfully updated")
-    userInputErrors:[WishListUserInputError]! @doc(description:"An array of errors encountered while updating products in a wish list")
+    user_errors: [WishListUserInputError!]! @doc(description:"An array of errors encountered while updating products in a wish list")
 }
 
 type WishListUserInputError @doc(description:"An error encountered while performing operations with WishList.") {
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Bundle/AddBundleProductToCartSingleMutationTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Bundle/AddBundleProductToCartSingleMutationTest.php
@@ -208,7 +208,7 @@ public function testAddBundleToCartWithWrongBundleOptions()
             }
         }
     }
-    userInputErrors {
+    user_errors {
         message
     }
   }
@@ -219,7 +219,7 @@ public function testAddBundleToCartWithWrongBundleOptions()
 
         self::assertEquals(
             "Please select all required options.",
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
     }
 
@@ -341,7 +341,7 @@ private function getMutationsQuery(
             }
         }
     }
-    userInputErrors {
+    user_errors {
         message
     }
   }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartSingleMutationTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartSingleMutationTest.php
@@ -103,7 +103,7 @@ public function testAddConfigurableProductWithWrongSuperAttributes()
 
         self::assertEquals(
             'You need to choose options for your item.',
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
     }
 
@@ -132,7 +132,7 @@ public function testAddProductIfQuantityIsNotAvailable()
 
         self::assertEquals(
             'The requested qty is not available',
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
     }
 
@@ -156,7 +156,7 @@ public function testAddNonExistentConfigurableProductParentToCart()
 
         self::assertEquals(
             'Could not find a product with SKU "configurable_no_exist"',
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
     }
 
@@ -188,7 +188,7 @@ public function testOutOfStockVariationToCart()
             'This product is out of stock.'
         ];
         $this->assertContains(
-            $response['addProductsToCart']['userInputErrors'][0]['message'],
+            $response['addProductsToCart']['user_errors'][0]['message'],
             $expectedErrorMessages
         );
     }
@@ -235,7 +235,7 @@ private function getQuery(
                 }
             }
         },
-        userInputErrors {
+        user_errors {
             message
         }
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddDownloadableProductToCartSingleMutationTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddDownloadableProductToCartSingleMutationTest.php
@@ -186,7 +186,7 @@ private function getQuery(
                 }
             }
         },
-        userInputErrors {
+        user_errors {
             message
         }
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductToCartEndToEndTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductToCartEndToEndTest.php
@@ -250,7 +250,7 @@ private function getAddToCartMutation(
                 }
             }
         },
-        userInputErrors {
+        user_errors {
             message
         }
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductToCartSingleMutationTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductToCartSingleMutationTest.php
@@ -112,11 +112,11 @@ public function testAddProductWithWrongSku(string $sku, string $message)
         $query = $this->getAddToCartMutation($maskedQuoteId, 1, $sku, '');
         $response = $this->graphQlMutation($query);
 
-        self::assertArrayHasKey('userInputErrors', $response['addProductsToCart']);
-        self::assertCount(1, $response['addProductsToCart']['userInputErrors']);
+        self::assertArrayHasKey('user_errors', $response['addProductsToCart']);
+        self::assertCount(1, $response['addProductsToCart']['user_errors']);
         self::assertEquals(
             $message,
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
     }
 
@@ -140,10 +140,10 @@ public function testAddToCartWithQtyPlusOne()
         $query = $this->getAddToCartMutation($maskedQuoteId, 1, $sku, '');
         $response = $this->graphQlMutation($query);
 
-        self::assertArrayHasKey('userInputErrors', $response['addProductsToCart']);
+        self::assertArrayHasKey('user_errors', $response['addProductsToCart']);
         self::assertEquals(
             'The requested qty is not available',
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
         self::assertEquals(100, $response['addProductsToCart']['cart']['total_quantity']);
     }
@@ -164,12 +164,12 @@ public function testAddProductWithWrongQuantity(int $quantity, string $message)
 
         $query = $this->getAddToCartMutation($maskedQuoteId, $quantity, $sku, '');
         $response = $this->graphQlMutation($query);
-        self::assertArrayHasKey('userInputErrors', $response['addProductsToCart']);
-        self::assertCount(1, $response['addProductsToCart']['userInputErrors']);
+        self::assertArrayHasKey('user_errors', $response['addProductsToCart']);
+        self::assertCount(1, $response['addProductsToCart']['user_errors']);
 
         self::assertEquals(
             $message,
-            $response['addProductsToCart']['userInputErrors'][0]['message']
+            $response['addProductsToCart']['user_errors'][0]['message']
         );
     }
 
@@ -249,7 +249,7 @@ private function getAddToCartMutation(
                 }
             }
         },
-        userInputErrors {
+        user_errors {
             message
         }
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/AddBundleProductToWishlistTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/AddBundleProductToWishlistTest.php
@@ -140,7 +140,7 @@ private function getQuery(
       }
     ]
 ) {
-    userInputErrors {
+    user_errors {
       code
       message
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/AddConfigurableProductToWishlistTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/AddConfigurableProductToWishlistTest.php
@@ -126,7 +126,7 @@ private function getQuery(
       }
     ]
 ) {
-    userInputErrors {
+    user_errors {
       code
       message
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/AddDownloadableProductToWishlistTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/AddDownloadableProductToWishlistTest.php
@@ -181,7 +181,7 @@ private function getQuery(
       }
     ]
 ) {
-    userInputErrors {
+    user_errors {
       code
       message
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/DeleteProductsFromWishlistTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/DeleteProductsFromWishlistTest.php
@@ -90,7 +90,7 @@ private function getQuery(
     wishlistId: {$wishlistId},
     wishlistItemsIds: [{$wishlistItemId}]
 ) {
-    userInputErrors {
+    user_errors {
       code
       message
     }
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/UpdateProductsFromWishlistTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/UpdateProductsFromWishlistTest.php
@@ -102,7 +102,7 @@ private function getQuery(
       }
     ]
 ) {
-    userInputErrors {
+    user_errors {
       code
       message
     }

Original file line number	Diff line number	Diff line change
`@@ -375,12 +375,12 @@ type Order {`
`375`	`375`
`376`	`376`	`type CartUserInputError @doc(description:"An error encountered while adding an item to the the cart.") {`
`377`	`377`	`message: String! @doc(description: "A localized error message")`
`378`		`- code: CartUserInputErrorType! @doc(description: "Checkout-specific error code")`
	`378`	`+ code: CartUserInputErrorType! @doc(description: "Cart-specific error code")`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`type AddProductsToCartOutput {`
`382`	`382`	`cart: Cart! @doc(description: "The cart after products have been added")`
`383`		`- userInputErrors:[CartUserInputError]! @doc(description: "An error encountered while adding an item to the cart.")`
	`383`	`+ user_errors: [CartUserInputError!]! @doc(description: "An error encountered while adding an item to the cart.")`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`enum CartUserInputErrorType {`
Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,12 @@ input WishlistItemInput @doc(description: "Defines the items to add to a wish li`
`49`	`49`
`50`	`50`	`type AddProductsToWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered") {`
`51`	`51`	`wishlist: Wishlist! @doc(description: "Contains the wish list with all items that were successfully added")`
`52`		`- userInputErrors:[WishListUserInputError]! @doc(description: "An array of errors encountered while adding products to a wish list")`
	`52`	`+ user_errors:[WishListUserInputError!]! @doc(description: "An array of errors encountered while adding products to a wish list")`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`type RemoveProductsFromWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered") {`
`56`	`56`	`wishlist: Wishlist! @doc(description: "Contains the wish list with after items were successfully deleted")`
`57`		`- userInputErrors:[WishListUserInputError]! @doc(description:"An array of errors encountered while deleting products from a wish list")`
	`57`	`+ user_errors:[WishListUserInputError!]! @doc(description:"An array of errors encountered while deleting products from a wish list")`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`input WishlistItemUpdateInput @doc(description: "Defines updates to items in a wish list") {`
`@@ -67,7 +67,7 @@ input WishlistItemUpdateInput @doc(description: "Defines updates to items in a w`
`67`	`67`
`68`	`68`	`type UpdateProductsInWishlistOutput @doc(description: "Contains the customer's wish list and any errors encountered") {`
`69`	`69`	`wishlist: Wishlist! @doc(description: "Contains the wish list with all items that were successfully updated")`
`70`		`- userInputErrors:[WishListUserInputError]! @doc(description:"An array of errors encountered while updating products in a wish list")`
	`70`	`+ user_errors: [WishListUserInputError!]! @doc(description:"An array of errors encountered while updating products in a wish list")`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`type WishListUserInputError @doc(description:"An error encountered while performing operations with WishList.") {`
Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ public function testAddBundleToCartWithWrongBundleOptions()`
`208`	`208`	`}`
`209`	`209`	`}`
`210`	`210`	`}`
`211`		`- userInputErrors {`
	`211`	`+ user_errors {`
`212`	`212`	`message`
`213`	`213`	`}`
`214`	`214`	`}`
`@@ -219,7 +219,7 @@ public function testAddBundleToCartWithWrongBundleOptions()`
`219`	`219`
`220`	`220`	`self::assertEquals(`
`221`	`221`	`"Please select all required options.",`
`222`		`- $response['addProductsToCart']['userInputErrors'][0]['message']`
	`222`	`+ $response['addProductsToCart']['user_errors'][0]['message']`
`223`	`223`	`);`
`224`	`224`	`}`
`225`	`225`
`@@ -341,7 +341,7 @@ private function getMutationsQuery(`
`341`	`341`	`}`
`342`	`342`	`}`
`343`	`343`	`}`
`344`		`- userInputErrors {`
	`344`	`+ user_errors {`
`345`	`345`	`message`
`346`	`346`	`}`
`347`	`347`	`}`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function testAddConfigurableProductWithWrongSuperAttributes()`
`103`	`103`
`104`	`104`	`self::assertEquals(`
`105`	`105`	`'You need to choose options for your item.',`
`106`		`- $response['addProductsToCart']['userInputErrors'][0]['message']`
	`106`	`+ $response['addProductsToCart']['user_errors'][0]['message']`
`107`	`107`	`);`
`108`	`108`	`}`
`109`	`109`
`@@ -132,7 +132,7 @@ public function testAddProductIfQuantityIsNotAvailable()`
`132`	`132`
`133`	`133`	`self::assertEquals(`
`134`	`134`	`'The requested qty is not available',`
`135`		`- $response['addProductsToCart']['userInputErrors'][0]['message']`
	`135`	`+ $response['addProductsToCart']['user_errors'][0]['message']`
`136`	`136`	`);`
`137`	`137`	`}`
`138`	`138`
`@@ -156,7 +156,7 @@ public function testAddNonExistentConfigurableProductParentToCart()`
`156`	`156`
`157`	`157`	`self::assertEquals(`
`158`	`158`	`'Could not find a product with SKU "configurable_no_exist"',`
`159`		`- $response['addProductsToCart']['userInputErrors'][0]['message']`
	`159`	`+ $response['addProductsToCart']['user_errors'][0]['message']`
`160`	`160`	`);`
`161`	`161`	`}`
`162`	`162`
`@@ -188,7 +188,7 @@ public function testOutOfStockVariationToCart()`
`188`	`188`	`'This product is out of stock.'`
`189`	`189`	`];`
`190`	`190`	`$this->assertContains(`
`191`		`- $response['addProductsToCart']['userInputErrors'][0]['message'],`
	`191`	`+ $response['addProductsToCart']['user_errors'][0]['message'],`
`192`	`192`	`$expectedErrorMessages`
`193`	`193`	`);`
`194`	`194`	`}`
`@@ -235,7 +235,7 @@ private function getQuery(`
`235`	`235`	`}`
`236`	`236`	`}`
`237`	`237`	`},`
`238`		`- userInputErrors {`
	`238`	`+ user_errors {`
`239`	`239`	`message`
`240`	`240`	`}`
`241`	`241`	`}`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ private function getQuery(`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`	`},`
`189`		`- userInputErrors {`
	`189`	`+ user_errors {`
`190`	`190`	`message`
`191`	`191`	`}`
`192`	`192`	`}`
Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ private function getAddToCartMutation(`
`250`	`250`	`}`
`251`	`251`	`}`
`252`	`252`	`},`
`253`		`- userInputErrors {`
	`253`	`+ user_errors {`
`254`	`254`	`message`
`255`	`255`	`}`
`256`	`256`	`}`