url escape test coverage

Author: engcom-Charlie

dev/tests/integration/testsuite/Magento/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/LayoutTest.php

@@ -3,62 +3,95 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Tab\Main;
 
+use Magento\Framework\App\Area;
+use Magento\Framework\App\State;
+use Magento\Framework\Escaper;
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Framework\View\DesignInterface;
+use Magento\Framework\View\LayoutInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\Widget\Model\Widget\Instance;
+use PHPUnit\Framework\TestCase;
+
 /**
  * @magentoAppArea adminhtml
  */
-class LayoutTest extends \PHPUnit\Framework\TestCase
+class LayoutTest extends TestCase
 {
     /**
-     * @var \Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Tab\Main\Layout
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    /**
+     * @var Layout
      */
-    protected $_block;
+    private $block;
 
+    /**
+     * @inheritDoc
+     */
     protected function setUp(): void
     {
-        parent::setUp();
+        $this->objectManager = Bootstrap::getObjectManager();
 
-        $this->_block = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
-            \Magento\Framework\View\LayoutInterface::class
-        )->createBlock(
-            \Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Tab\Main\Layout::class,
-            '',
-            [
-                'data' => [
-                    'widget_instance' => \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(
-                        \Magento\Widget\Model\Widget\Instance::class
-                    ),
+        $this->block = $this->objectManager->get(LayoutInterface::class)
+            ->createBlock(
+                Layout::class,
+                '',
+                [
+                    'data' => [
+                        'widget_instance' => $this->objectManager->create(Instance::class),
+                    ],
                 ]
-            ]
-        );
-        $this->_block->setLayout(
-            \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
-                \Magento\Framework\View\LayoutInterface::class
-            )
-        );
+            );
+        $this->block->setLayout($this->objectManager->get(LayoutInterface::class));
     }
 
     /**
      * @magentoAppIsolation enabled
      */
     public function testGetLayoutsChooser()
     {
-        \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
-            \Magento\Framework\App\State::class
-        )->setAreaCode(
-            \Magento\Framework\App\Area::AREA_FRONTEND
-        );
-        \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(
-            \Magento\Framework\View\DesignInterface::class
-        )->setDefaultDesignTheme();
+        $this->objectManager->get(State::class)
+            ->setAreaCode(Area::AREA_FRONTEND);
+        $this->objectManager->get(DesignInterface::class)
+            ->setDefaultDesignTheme();
 
-        $actualHtml = $this->_block->getLayoutsChooser();
+        $actualHtml = $this->block->getLayoutsChooser();
         $this->assertStringStartsWith('<select ', $actualHtml);
         $this->assertStringEndsWith('</select>', $actualHtml);
         $this->assertStringContainsString('id="layout_handle"', $actualHtml);
         $optionCount = substr_count($actualHtml, '<option ');
         $this->assertGreaterThan(1, $optionCount, 'HTML select tag must provide options to choose from.');
         $this->assertEquals($optionCount, substr_count($actualHtml, '</option>'));
     }
+
+    /**
+     * Check that escapeUrl called from template
+     *
+     * @return void
+     */
+    public function testToHtml(): void
+    {
+        $escaperMock = $this->createMock(Escaper::class);
+        $this->objectManager->addSharedInstance($escaperMock, Escaper::class);
+
+        $escaperMock->expects($this->atLeast(6))
+            ->method('escapeUrl');
+
+        $this->block->toHtml();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    protected function tearDown(): void
+    {
+        $this->objectManager->removeSharedInstance(Escaper::class);
+    }
 }