MTA-4096: Ignore functional test failures caused by Magento issues

- unified the comparison algorithm

Author: Dell-

dev/tests/functional/tests/app/Magento/Sales/Test/TestStep/CreateCreditMemoStep.php

@@ -12,12 +12,15 @@
 use Magento\Sales\Test\Page\Adminhtml\OrderIndex;
 use Magento\Sales\Test\Page\Adminhtml\SalesOrderView;
 use Magento\Mtf\TestStep\TestStepInterface;
+use Magento\Sales\Test\TestStep\Utils\CompareQtyTrait;
 
 /**
  * Create credit memo from order on backend.
  */
 class CreateCreditMemoStep implements TestStepInterface
 {
+    use CompareQtyTrait;
+
     /**
      * Orders Page.
      *
@@ -89,7 +92,7 @@ public function run()
 
             $items = $this->cart->getItems();
             $this->orderCreditMemoNew->getFormBlock()->fillProductData($refundData, $items);
-            if (!empty($refundData) && count($refundData) !== count($items)) {
+            if ($this->compare($items, $refundData)) {
                 $this->orderCreditMemoNew->getFormBlock()->updateQty();
             }
 

dev/tests/functional/tests/app/Magento/Sales/Test/TestStep/CreateInvoiceStep.php

@@ -7,11 +7,13 @@
 namespace Magento\Sales\Test\TestStep;
 
 use Magento\Checkout\Test\Fixture\Cart;
+use Magento\Mtf\Fixture\FixtureInterface;
 use Magento\Sales\Test\Fixture\OrderInjectable;
 use Magento\Sales\Test\Page\Adminhtml\OrderIndex;
 use Magento\Sales\Test\Page\Adminhtml\OrderInvoiceNew;
 use Magento\Sales\Test\Page\Adminhtml\OrderInvoiceView;
 use Magento\Sales\Test\Page\Adminhtml\SalesOrderView;
+use Magento\Sales\Test\TestStep\Utils\CompareQtyTrait;
 use Magento\Shipping\Test\Page\Adminhtml\OrderShipmentView;
 use Magento\Mtf\TestStep\TestStepInterface;
 
@@ -20,6 +22,8 @@
  */
 class CreateInvoiceStep implements TestStepInterface
 {
+    use CompareQtyTrait;
+
     /**
      * Orders Page.
      *
@@ -124,7 +128,7 @@ public function run()
 
             $items = $this->cart->getItems();
             $this->orderInvoiceNew->getFormBlock()->fillProductData($invoiceData, $items);
-            if (!empty($invoiceData) && count($invoiceData) !== count($items)) {
+            if ($this->compare($items, $invoiceData)) {
                 $this->orderInvoiceNew->getFormBlock()->updateQty();
             }
 

dev/tests/functional/tests/app/Magento/Sales/Test/TestStep/CreateOnlineCreditMemoStep.php

@@ -13,12 +13,15 @@
 use Magento\Sales\Test\Page\Adminhtml\OrderIndex;
 use Magento\Sales\Test\Page\Adminhtml\OrderInvoiceView;
 use Magento\Sales\Test\Page\Adminhtml\SalesOrderView;
+use Magento\Sales\Test\TestStep\Utils\CompareQtyTrait;
 
 /**
  * Create credit memo for order placed using online payment methods.
  */
 class CreateOnlineCreditMemoStep implements TestStepInterface
 {
+    use CompareQtyTrait;
+
     /**
      * Orders Page.
      *
@@ -104,7 +107,7 @@ public function run()
 
             $items = $this->cart->getItems();
             $this->orderCreditMemoNew->getFormBlock()->fillProductData($refundData, $items);
-            if (!empty($refundData) && count($refundData) !== count($items)) {
+            if ($this->compare($items, $refundData)) {
                 $this->orderCreditMemoNew->getFormBlock()->updateQty();
             }
 

dev/tests/functional/tests/app/Magento/Sales/Test/TestStep/Utils/CompareQtyTrait.php

@@ -0,0 +1,42 @@
+<?php
+/**
+ * Copyright © 2013-2017 Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Sales\Test\TestStep\Utils;
+
+use Magento\Mtf\Fixture\FixtureInterface;
+
+/**
+ * Compare qty in current order with qty in the entity form.
+ */
+trait CompareQtyTrait
+{
+    /**
+     * Compare items.
+     *
+     * @param FixtureInterface[] $products
+     * @param array $data
+     * @return bool
+     */
+    protected function compare(array $products, array $data)
+    {
+        if (empty($data['items_data'])) {
+            return false;
+        }
+
+        $count = 0;
+        foreach ($data['items_data'] as $key => $item) {
+            if (!isset($products[$key])) {
+                continue;
+            }
+
+            if ($products[$key]->getData('qty') !== $item['qty']) {
+                ++$count;
+            }
+        }
+
+        return $count !== 0;
+    }
+}