MAGETWO-89659: Address comments / feedback from review

Robert He · Robert He · commit 5edebd7bceaa · 2018-04-04T15:31:20.000-05:00
- fix bugs and stylings
diff --git a/app/code/Magento/Ui/Model/ColorPicker/ColorModesProvider.php b/app/code/Magento/Ui/Model/ColorPicker/ColorModesProvider.php
@@ -58,16 +58,8 @@ public function getModes(): array
      */
     private function createModeProvider(string $instance): ModeInterface
     {
-        if (!is_subclass_of(
-            $instance,
-            ModeInterface::class
-        )
-        ) {
-            throw new \InvalidArgumentException(
-                $instance .
-                ' does not implement ' .
-                ModeInterface::class
-            );
+        if (!is_subclass_of($instance, ModeInterface::class)) {
+            throw new \InvalidArgumentException($instance . ' does not implement ' . ModeInterface::class);
         }
         return $this->objectManager->create($instance);
     }

Original file line number	Diff line number	Diff line change
`@@ -58,16 +58,8 @@ public function getModes(): array`
`58`	`58`	`*/`
`59`	`59`	`private function createModeProvider(string $instance): ModeInterface`
`60`	`60`	`{`
`61`		`- if (!is_subclass_of(`
`62`		`- $instance,`
`63`		`- ModeInterface::class`
`64`		`- )`
`65`		`- ) {`
`66`		`- throw new \InvalidArgumentException(`
`67`		`- $instance .`
`68`		`- ' does not implement ' .`
`69`		`- ModeInterface::class`
`70`		`- );`
	`61`	`+ if (!is_subclass_of($instance, ModeInterface::class)) {`
	`62`	`+ throw new \InvalidArgumentException($instance . ' does not implement ' . ModeInterface::class);`
`71`	`63`	`}`
`72`	`64`	`return $this->objectManager->create($instance);`
`73`	`65`	`}`