Skip to content

Commit 5eba76c

Browse files
viktorpetrykviktorpetryk
committed
MC-34091: [php7.4][MFTF] StoreFrontRecentlyComparedAtWebsiteLevelTest failed because of bad design (MC-33099)
1 parent 81e3240 commit 5eba76c

File tree

2 files changed

+28
-29
lines changed

2 files changed

+28
-29
lines changed

‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontClearCompareActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<waitForElementVisible selector="{{ModalConfirmationSection.OkButton}}" time="30" stepKey="waitForClearOk"/>
1919
<scrollTo selector="{{ModalConfirmationSection.OkButton}}" stepKey="scrollToClearOk"/>
2020
<click selector="{{ModalConfirmationSection.OkButton}}" stepKey="clickClearOk"/>
21-
<waitForElement selector="{{StorefrontMessagesSection.message('You cleared the comparison list.')}}" time="30" stepKey="AssertMessageCleared"/>
22-
<waitForElement selector="{{StorefrontComparisonSidebarSection.NoItemsMessage}}" time="30" stepKey="assertNoItems"/>
21+
<waitForElementVisible selector="{{StorefrontMessagesSection.message('You cleared the comparison list.')}}" time="30" stepKey="assertMessageCleared"/>
22+
<waitForElementVisible selector="{{StorefrontComparisonSidebarSection.NoItemsMessage}}" time="30" stepKey="assertNoItems"/>
2323
</actionGroup>
2424
</actionGroups>

‎app/code/Magento/Catalog/Test/Mftf/Test/StoreFrontRecentlyComparedAtWebsiteLevelTest.xml

Lines changed: 26 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,19 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1010
<test name="StoreFrontRecentlyComparedAtWebsiteLevelTest">
1111
<annotations>
12+
<features value="Catalog"/>
1213
<stories value="Recently Compared Product"/>
1314
<title value="Recently Compared Product at website level"/>
1415
<description value="Recently Compared Products widget appears on a page immediately after adding product to compare"/>
15-
<useCaseId value="MC-32763"/>
16-
<testCaseId value="MC-33099"/>
1716
<severity value="MAJOR"/>
17+
<testCaseId value="MC-33099"/>
18+
<useCaseId value="MC-32763"/>
1819
<group value="catalog"/>
1920
<group value="widget"/>
2021
</annotations>
2122
<before>
23+
<!-- Set Stores > Configurations > Catalog > Recently Viewed/Compared Products > Show for Current = Website -->
24+
<magentoCLI command="config:set {{RecentlyViewedProductScopeWebsite.path}} {{RecentlyViewedProductScopeWebsite.value}}" stepKey="setRecentlyViewedComparedProductsScopeToWebsite"/>
2225
<!--Create Simple Products and Category -->
2326
<createData entity="SimpleSubCategory" stepKey="createCategory"/>
2427
<createData entity="SimpleProduct" stepKey="createSimpleProductToCompareFirst">
@@ -40,67 +43,63 @@
4043
<actionGroup ref="AdminCreateRecentlyProductsWidgetActionGroup" stepKey="createRecentlyComparedProductsWidget">
4144
<argument name="widget" value="RecentlyComparedProductsWidget"/>
4245
</actionGroup>
43-
<!-- Set Stores > Configurations > Catalog > Recently Viewed/Compared Products > Show for Current = Website -->
44-
<magentoCLI command="config:set {{RecentlyViewedProductScopeWebsite.path}} {{RecentlyViewedProductScopeWebsite.value}}" stepKey="RecentlyViewedProductScopeWebsiteGroup"/>
4546
</before>
4647
<after>
47-
<!-- Customer Logout -->
48-
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="logoutFromCustomer"/>
49-
<!-- Delete product widget -->
50-
<actionGroup ref="AdminDeleteWidgetActionGroup" stepKey="deleteRecentlyComparedProductsWidget">
51-
<argument name="widget" value="RecentlyComparedProductsWidget"/>
52-
</actionGroup>
53-
<!-- Logout Admin -->
54-
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
5548
<!-- Reset Stores > Configurations > Catalog > Recently Viewed/Compared Products > Show for Current = Website-->
56-
<magentoCLI command="config:set {{RecentlyViewedProductScopeWebsite.path}} {{RecentlyViewedProductScopeWebsite.value}}" stepKey="RecentlyViewedProductScopeWebsite"/>
49+
<magentoCLI command="config:set {{RecentlyViewedProductScopeWebsite.path}} {{RecentlyViewedProductScopeWebsite.value}}" stepKey="setRecentlyViewedComparedProductsScopeToDefault"/>
5750
<!-- Delete Products and Category -->
5851
<deleteData createDataKey="createSimpleProductToCompareFirst" stepKey="deleteSimpleProductToCompareFirst"/>
5952
<deleteData createDataKey="createSimpleProductToCompareSecond" stepKey="deleteSimpleProductToCompareSecond"/>
6053
<deleteData createDataKey="createSimpleProductNotVisibleFirst" stepKey="deleteSimpleProductNotVisibleFirst"/>
6154
<deleteData createDataKey="createSimpleProductNotVisibleSecond" stepKey="deleteSimpleProductNotVisibleSecond"/>
6255
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
56+
<!-- Customer Logout -->
57+
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="logoutFromCustomer"/>
6358
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
59+
<!-- Delete product widget -->
60+
<actionGroup ref="AdminDeleteWidgetActionGroup" stepKey="deleteRecentlyComparedProductsWidget">
61+
<argument name="widget" value="RecentlyComparedProductsWidget"/>
62+
</actionGroup>
63+
<!-- Logout Admin -->
64+
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutFromAdmin"/>
6465
</after>
6566
<!--Login to storefront from customer-->
6667
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="loginCustomer">
67-
<argument name="Customer" value="$$createCustomer$$"/>
68+
<argument name="Customer" value="$createCustomer$"/>
6869
</actionGroup>
69-
<see userInput="Welcome, $$createCustomer.firstname$$ $$createCustomer.lastname$$!" selector="{{StorefrontPanelHeaderSection.welcomeMessage}}" stepKey="checkWelcomeMessage"/>
70-
<amOnPage url="{{StorefrontCategoryPage.url($$createCategory.custom_attributes[url_key]$$)}}" stepKey="openCategoryPageAfterAddedProductToCart"/>
70+
<see userInput="Welcome, $createCustomer.firstname$ $createCustomer.lastname$!" selector="{{StorefrontPanelHeaderSection.welcomeMessage}}" stepKey="checkWelcomeMessage"/>
71+
<amOnPage url="{{StorefrontCategoryPage.url($createCategory.custom_attributes[url_key]$)}}" stepKey="openCategoryPage"/>
7172
<!--Add to compare Simple Product and Simple Product 2-->
7273
<actionGroup ref="StorefrontAddCategoryProductToCompareActionGroup" stepKey="addSimpleProduct1ToCompare" >
73-
<argument name="productVar" value="$$createSimpleProductToCompareFirst$$"/>
74+
<argument name="productVar" value="$createSimpleProductToCompareFirst$"/>
7475
</actionGroup>
7576
<actionGroup ref="StorefrontAddCategoryProductToCompareActionGroup" stepKey="addSimpleProduct2ToCompare" >
76-
<argument name="productVar" value="$$createSimpleProductToCompareSecond$$"/>
77+
<argument name="productVar" value="$createSimpleProductToCompareSecond$"/>
7778
</actionGroup>
7879
<!--The Compare Products widget displays Simple Product 1 and Simple Product 2-->
7980
<actionGroup ref="StorefrontCheckCompareSidebarProductActionGroup" stepKey="checkSimpleProduct1InCompareSidebar">
80-
<argument name="productVar" value="$$createSimpleProductToCompareFirst$$"/>
81+
<argument name="productVar" value="$createSimpleProductToCompareFirst$"/>
8182
</actionGroup>
8283
<actionGroup ref="StorefrontCheckCompareSidebarProductActionGroup" stepKey="checkSimpleProduct2InCompareSidebar">
83-
<argument name="productVar" value="$$createSimpleProductToCompareSecond$$"/>
84+
<argument name="productVar" value="$createSimpleProductToCompareSecond$"/>
8485
</actionGroup>
8586

8687
<!--Click Clear all in the Compare Products widget-->
8788
<actionGroup ref="StorefrontClearCompareActionGroup" stepKey="clearCompareList"/>
8889
<!--The Recently Compared widget displays Simple Product 1 and Simple Product 2-->
89-
<amOnPage url="{{StorefrontCategoryPage.url($$createCategory.custom_attributes[url_key]$$)}}" stepKey="openCategoryPageToCheckProductsInRecentlyComparedSidebar"/>
90+
<waitForPageLoad stepKey="waitForRecentlyComparedWidgetLoad"/>
9091
<actionGroup ref="StorefrontAssertProductInRecentlyComparedWidgetActionGroup" stepKey="checkSimpleProduct1ExistInRecentlyComparedWidget">
91-
<argument name="product" value="$$createSimpleProductToCompareFirst$$"/>
92+
<argument name="product" value="$createSimpleProductToCompareFirst$"/>
9293
</actionGroup>
9394
<actionGroup ref="StorefrontAssertProductInRecentlyComparedWidgetActionGroup" stepKey="checkSimpleProduct2ExistInRecentlyComparedWidget">
94-
<argument name="product" value="$$createSimpleProductToCompareSecond$$"/>
95+
<argument name="product" value="$createSimpleProductToCompareSecond$"/>
9596
</actionGroup>
9697
<!--The Recently Compared widget not displays Simple Product 3 and Simple Product 4-->
9798
<actionGroup ref="StorefrontAssertNotExistProductInRecentlyComparedWidgetActionGroup" stepKey="checkSimpleProduct3NotExistInRecentlyComparedWidget">
98-
<argument name="product" value="$$createSimpleProductNotVisibleFirst$$"/>
99+
<argument name="product" value="$createSimpleProductNotVisibleFirst$"/>
99100
</actionGroup>
100101
<actionGroup ref="StorefrontAssertNotExistProductInRecentlyComparedWidgetActionGroup" stepKey="checkSimpleProduct4NotExistInRecentlyComparedWidget">
101-
<argument name="product" value="$$createSimpleProductNotVisibleSecond$$"/>
102+
<argument name="product" value="$createSimpleProductNotVisibleSecond$"/>
102103
</actionGroup>
103-
<amOnPage url="customer/account/logout/" stepKey="logoutCustomer"/>
104-
<waitForPageLoad time="30" stepKey="waitForPageLoad2"/>
105104
</test>
106105
</tests>

0 commit comments

Comments
 (0)