Skip to content

Commit 5e5ac82

Browse files
MAGETWO-70141: Fixed coding standard violations in the Framework\Code namespace #9358
2 parents d816ce7 + 7e540a5 commit 5e5ac82

File tree

7 files changed

+28
-21
lines changed

7 files changed

+28
-21
lines changed

lib/internal/Magento/Framework/Code/Test/Unit/GeneratorTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
// @codingStandardsIgnoreFile
8-
97
namespace Magento\Framework\Code\Test\Unit;
108

119
use Magento\Framework\Code\Generator;

lib/internal/Magento/Framework/Code/Test/Unit/Reader/_files/ClassesForArgumentsReader.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<?php
22
/**
3-
*
43
* Copyright © Magento, Inc. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
76

8-
// @codingStandardsIgnoreFile
7+
/**
8+
* @codingStandardsIgnoreFile
9+
* Coding Standards have to be ignored in this file, as it is just a data source for tests.
10+
*/
911

1012
class ClassWithAllArgumentTypes
1113
{

lib/internal/Magento/Framework/Code/Test/Unit/Validator/ConstructorArgumentTypesTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
// @codingStandardsIgnoreFile
8-
97
namespace Magento\Framework\Code\Test\Unit\Validator;
108

119
class ConstructorArgumentTypesTest extends \PHPUnit_Framework_TestCase

lib/internal/Magento/Framework/Code/Test/Unit/Validator/_files/ClassesForArgumentSequence.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<?php
22
/**
3-
*
43
* Copyright © Magento, Inc. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
76

8-
// @codingStandardsIgnoreFile
7+
/**
8+
* @codingStandardsIgnoreFile
9+
* Coding Standards have to be ignored in this file, as it is just a data source for tests.
10+
*/
911

1012
namespace ArgumentSequence;
1113

lib/internal/Magento/Framework/Code/Test/Unit/Validator/_files/ClassesForConstructorIntegrity.php

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<?php
22
/**
3-
*
43
* Copyright © Magento, Inc. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
76

8-
// @codingStandardsIgnoreFile
7+
/**
8+
* @codingStandardsIgnoreFile
9+
* Coding Standards have to be ignored in this file, as it is just a data source for tests.
10+
*/
911

1012
class ClassA
1113
{
@@ -16,16 +18,16 @@ class ClassB
1618
class ClassC
1719
{
1820
}
19-
interface InterfaceA
21+
interface FirstInterface
2022
{
2123
}
22-
class ImplementationOfInterfaceA implements InterfaceA
24+
class ImplementationOfFirstInterface implements FirstInterface
2325
{
2426
}
25-
interface InterfaceB
27+
interface SecondInterface
2628
{
2729
}
28-
class ImplementationOfInterfaceB implements InterfaceB
30+
class ImplementationOfSecondInterface implements SecondInterface
2931
{
3032
}
3133
class Context implements \Magento\Framework\ObjectManager\ContextInterface
@@ -46,21 +48,21 @@ class Context implements \Magento\Framework\ObjectManager\ContextInterface
4648
protected $_exC;
4749

4850
/**
49-
* @var InterfaceA
51+
* @var FirstInterface
5052
*/
5153
protected $_interfaceA;
5254

5355
/**
54-
* @var ImplementationOfInterfaceB
56+
* @var ImplementationOfSecondInterface
5557
*/
5658
protected $_implOfBInterface;
5759

5860
public function __construct(
5961
\ClassA $exA,
6062
\ClassB $exB,
6163
\ClassC $exC,
62-
\InterfaceA $interfaceA,
63-
\ImplementationOfInterfaceB $implOfBInterface
64+
\FirstInterface $interfaceA,
65+
\ImplementationOfSecondInterface $implOfBInterface
6466
) {
6567
$this->_exA = $exA;
6668
$this->_exB = $exB;

lib/internal/Magento/Framework/Code/Test/Unit/Validator/_files/ClassesForTypeDuplication.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<?php
22
/**
3-
*
43
* Copyright © Magento, Inc. All rights reserved.
54
* See COPYING.txt for license details.
65
*/
76

8-
// @codingStandardsIgnoreFile
7+
/**
8+
* @codingStandardsIgnoreFile
9+
* Coding Standards have to be ignored in this file, as it is just a data source for tests.
10+
*/
911

1012
namespace TypeDuplication;
1113

lib/internal/Magento/Framework/Code/Test/Unit/_files/app/code/Magento/SomeModule/Model/SevenInterface.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
// @codingStandardsIgnoreFile
7+
/**
8+
* @codingStandardsIgnoreFile
9+
* Coding Standards have to be ignored in this file, as it is just a data source for tests.
10+
*/
811

912
namespace Magento\SomeModule\Model;
1013

0 commit comments

Comments
 (0)