Skip to content

Commit 5e2bdd1

Browse files
ENGCOM-7771: Remove unneccessary \overflowed\ class from minicart sidebar widget #28963
- Merge Pull Request #28963 from lumnn/magento2:feature-minor-js-improvements - Merged commits: 1. a9c4d2a 2. 78375f0 3. 9c363fd
2 parents 48d7868 + 9c363fd commit 5e2bdd1

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

app/code/Magento/Checkout/view/frontend/web/js/sidebar.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ define([
4242
update: function () {
4343
$(this.options.targetElement).trigger('contentUpdated');
4444
this._calcHeight();
45-
this._isOverflowed();
4645
},
4746

4847
/**
@@ -135,23 +134,6 @@ define([
135134

136135
this._on(this.element, events);
137136
this._calcHeight();
138-
this._isOverflowed();
139-
},
140-
141-
/**
142-
* Add 'overflowed' class to minicart items wrapper element
143-
*
144-
* @private
145-
*/
146-
_isOverflowed: function () {
147-
var list = $(this.options.minicart.list),
148-
cssOverflowClass = 'overflowed';
149-
150-
if (this.scrollHeight > list.innerHeight()) {
151-
list.parent().addClass(cssOverflowClass);
152-
} else {
153-
list.parent().removeClass(cssOverflowClass);
154-
}
155137
},
156138

157139
/**

app/code/Magento/Checkout/view/frontend/web/template/summary/cart-items.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</strong>
1616
</div>
1717
<div class="content minicart-items" data-role="content">
18-
<div class="minicart-items-wrapper overflowed">
18+
<div class="minicart-items-wrapper">
1919
<ol class="minicart-items">
2020
<each args="items()">
2121
<li class="product-item">

0 commit comments

Comments
 (0)