Skip to content

Commit 5e06091

Browse files
committed
ACP2E-64: Bundle Products Special Price Column in Grid should have % sign not currency sign
- Fixed the CR comments
1 parent 0918f58 commit 5e06091

File tree

1 file changed

+20
-29
lines changed

1 file changed

+20
-29
lines changed

app/code/Magento/Bundle/Test/Mftf/Test/AdminBundleProductPriceSymbolValidationInGridTest.xml

Lines changed: 20 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,27 @@
2424
<createData entity="SimpleProduct2" stepKey="simpleProduct1"/>
2525
<!-- Admin login -->
2626
<actionGroup ref="AdminLoginActionGroup" stepKey="loginToAdminPanel"/>
27+
<!-- Navigate to catalog product grid page -->
28+
<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="navigateToProductIndexPage"/>
29+
<!-- Open the column dropdown to add the special price from the catalog product grid -->
30+
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="openColumnsDropdownSpecialPrice"/>
31+
<actionGroup ref="CheckAdminProductGridColumnOptionActionGroup" stepKey="checkSpecialPriceOption">
32+
<argument name="optionName" value="Special Price"/>
33+
</actionGroup>
34+
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="closeColumnsDropdownSpecialPrice"/>
35+
<!-- It takes a few seconds for column update to be saved -->
36+
<!-- waitForPageLoad won't work here since saving is happening with a short delay -->
37+
<wait time="5" stepKey="waitForColumnUpdateToSave"/>
2738
</before>
2839
<after>
2940
<!-- Navigate to catalog product grid page -->
3041
<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="navigateToProductIndexPage"/>
31-
<!-- Set product grid to default columns -->
32-
<actionGroup ref="ResetProductGridToDefaultViewActionGroup" stepKey="setProductGridToDefaultColumns"/>
33-
<!-- Open the column dropdown to reset the default columns from the catalog product grid -->
34-
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="openColumnsDropdownToReset"/>
35-
<actionGroup ref="ResetAdminProductGridColumnsActionGroup" stepKey="resetProductGridColumns"/>
36-
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="closeColumnsDropdownAfterReset"/>
42+
<!-- Clean applied product filters before delete -->
43+
<actionGroup ref="AdminClearGridFiltersActionGroup" stepKey="clearAppliedFilters"/>
3744
<!-- Delete all the products from the catalog product grid -->
3845
<actionGroup ref="DeleteProductsIfTheyExistActionGroup" stepKey="deleteAllProducts"/>
46+
<!-- Set product grid to default columns -->
47+
<actionGroup ref="ResetProductGridToDefaultViewActionGroup" stepKey="setProductGridToDefaultColumns"/>
3948
<!-- Logging out -->
4049
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
4150
</after>
@@ -48,6 +57,10 @@
4857
<actionGroup ref="AddSpecialPriceToProductActionGroup" stepKey="addSpecialPrice">
4958
<argument name="price" value="{{SimpleProductWithSpecialPrice.special_price}}"/>
5059
</actionGroup>
60+
<!-- Fill up the new product form with data -->
61+
<actionGroup ref="CreateBasicBundleProductActionGroup" stepKey="createBundledProduct">
62+
<argument name="bundleProduct" value="BundleProduct"/>
63+
</actionGroup>
5164
<!-- Add the bundle option to the product -->
5265
<actionGroup ref="AddBundleOptionWithOneProductActionGroup" stepKey="addBundleOption">
5366
<argument name="x" value="0"/>
@@ -57,38 +70,16 @@
5770
<argument name="optionTitle" value="{{BundleProduct.optionTitle1}}"/>
5871
<argument name="inputType" value="{{BundleProduct.optionInputType1}}"/>
5972
</actionGroup>
60-
<!-- Add the default attribute value for the bundle product creation page -->
61-
<actionGroup ref="CreateBasicBundleProductActionGroup" stepKey="createBundledProduct">
62-
<argument name="bundleProduct" value="BundleProduct"/>
63-
</actionGroup>
6473
<!-- Save the bundle product -->
6574
<actionGroup ref="SaveProductFormActionGroup" stepKey="saveProductForm"/>
66-
6775
<!-- Navigate to catalog product grid page -->
68-
<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="navigateToProductIndexPage"/>
69-
70-
<!-- Set product grid to default columns -->
71-
<actionGroup ref="ResetProductGridToDefaultViewActionGroup" stepKey="setProductGridToDefaultColumns"/>
72-
<!-- Open the column dropdown to reset the default columns from the catalog product grid -->
73-
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="openToResetColumnsDropdown"/>
74-
<actionGroup ref="ResetAdminProductGridColumnsActionGroup" stepKey="resetAdminProductGridColumns"/>
75-
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="closeColumnsDropdownAfterReset"/>
76-
77-
<!-- Open the column dropdown to add the special price from the catalog product grid -->
78-
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="openColumnsDropdownSpecialPrice"/>
79-
<actionGroup ref="CheckAdminProductGridColumnOptionActionGroup" stepKey="checkSpecialPriceOption">
80-
<argument name="optionName" value="Special Price"/>
81-
</actionGroup>
82-
<actionGroup ref="ToggleAdminProductGridColumnsDropdownActionGroup" stepKey="closeColumnsDropdownSpecialPrice"/>
83-
76+
<actionGroup ref="AdminOpenProductIndexPageActionGroup" stepKey="navigateToProductIndexPageAfterProdSave"/>
8477
<!-- Search the created bundle product with sku -->
8578
<actionGroup ref="FilterProductGridBySku2ActionGroup" stepKey="filterBundleProductGridBySku">
8679
<argument name="sku" value="{{BundleProduct.sku}}"/>
8780
</actionGroup>
88-
8981
<!-- Asserting with the special price value contains the percentage value -->
9082
<actionGroup ref="AdminAssertSpecialPriceAttributeValueOnProductGridPageActionGroup" stepKey="assertSpecialPricePercentageSymbol">
91-
<argument name="specialPriceColumn" value="Special Price"/>
9283
<argument name="expectedValue" value="90.00%"/>
9384
</actionGroup>
9485
</test>

0 commit comments

Comments
 (0)