Skip to content

Commit 5dd5e3a

Browse files
committed
magento/graphql-ce#540: Replace deprecated Magento/Checkout/_files/quote_with_address_saved.php fixture in SetUpsShippingMethodsOnCartTest
1 parent 8d107c5 commit 5dd5e3a

File tree

1 file changed

+12
-18
lines changed

1 file changed

+12
-18
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/Ups/SetUpsShippingMethodsOnCartTest.php

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
namespace Magento\GraphQl\Ups;
99

10+
use Magento\GraphQl\Quote\GetMaskedQuoteIdByReservedOrderId;
1011
use Magento\Integration\Api\CustomerTokenServiceInterface;
11-
use Magento\Quote\Model\QuoteFactory;
12-
use Magento\Quote\Model\QuoteIdToMaskedQuoteIdInterface;
12+
use Magento\Quote\Model\Quote;
1313
use Magento\Quote\Model\ResourceModel\Quote as QuoteResource;
1414
use Magento\TestFramework\Helper\Bootstrap;
1515
use Magento\TestFramework\TestCase\GraphQlAbstract;
@@ -30,50 +30,44 @@ class SetUpsShippingMethodsOnCartTest extends GraphQlAbstract
3030
const CARRIER_METHOD_CODE_GROUND = 'GND';
3131

3232
/**
33-
* @var QuoteFactory
33+
* @var Quote
3434
*/
35-
private $quoteFactory;
35+
private $quote;
3636

3737
/**
3838
* @var CustomerTokenServiceInterface
3939
*/
4040
private $customerTokenService;
4141

4242
/**
43-
* @var QuoteResource
43+
* @var GetMaskedQuoteIdByReservedOrderId
4444
*/
45-
private $quoteResource;
46-
47-
/**
48-
* @var QuoteIdToMaskedQuoteIdInterface
49-
*/
50-
private $quoteIdToMaskedId;
45+
private $getMaskedQuoteIdByReservedOrderId;
5146

5247
/**
5348
* @inheritdoc
5449
*/
5550
protected function setUp()
5651
{
5752
$objectManager = Bootstrap::getObjectManager();
58-
$this->quoteResource = $objectManager->get(QuoteResource::class);
59-
$this->quoteFactory = $objectManager->get(QuoteFactory::class);
60-
$this->quoteIdToMaskedId = $objectManager->get(QuoteIdToMaskedQuoteIdInterface::class);
53+
$this->quote = $objectManager->create(Quote::class);
6154
$this->customerTokenService = $objectManager->get(CustomerTokenServiceInterface::class);
55+
$this->getMaskedQuoteIdByReservedOrderId = $objectManager->get(GetMaskedQuoteIdByReservedOrderId::class);
6256
}
6357

6458
/**
6559
* @magentoApiDataFixture Magento/Customer/_files/customer.php
66-
* @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
60+
* @magentoApiDataFixture Magento/Catalog/_files/products.php
6761
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
6862
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
6963
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_shipping_address.php
7064
* @magentoApiDataFixture Magento/Ups/_files/enable_ups_shipping_method.php
7165
*/
7266
public function testSetUpsShippingMethod()
7367
{
74-
$quote = $this->quoteFactory->create();
75-
$this->quoteResource->load($quote, 'test_quote', 'reserved_order_id');
76-
$maskedQuoteId = $this->quoteIdToMaskedId->execute((int)$quote->getId());
68+
$quoteReservedId = 'test_quote';
69+
$maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute($quoteReservedId);
70+
$quote = $this->quote->load($quoteReservedId, 'reserved_order_id');
7771
$shippingAddressId = (int)$quote->getShippingAddress()->getId();
7872

7973
$query = $this->getAddUpsShippingMethodQuery(

0 commit comments

Comments
 (0)