Skip to content

Commit 5db1fe0

Browse files
AC-10845::Pagebuilder banner image not visible in gallery
1 parent c433605 commit 5db1fe0

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

app/code/Magento/MediaGalleryUi/Test/Mftf/Helper/MediaGalleryUiHelper.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ public function deleteAllImagesUsingMassAction(
4848
$rows = $webDriver->findElements(WebDriverBy::cssSelector($emptyRow));
4949
while (empty($rows)) {
5050
$magentoWebDriver->click($deleteImagesButton);
51-
$magentoWebDriver->waitForPageLoad(60);
52-
$magentoWebDriver->waitForElementVisible($deleteSelectedButton, 60);
51+
$magentoWebDriver->waitForPageLoad(30);
52+
$magentoWebDriver->waitForElementVisible($deleteSelectedButton, 10);
5353

5454
// Check all images
5555
/** @var RemoteWebElement[] $images */
@@ -59,13 +59,13 @@ public function deleteAllImagesUsingMassAction(
5959
$imageCheckbox->click();
6060
}
6161

62-
$magentoWebDriver->waitForPageLoad(60);
62+
$magentoWebDriver->waitForPageLoad(30);
6363
$magentoWebDriver->click($deleteSelectedButton);
64-
$magentoWebDriver->waitForPageLoad(60);
65-
$magentoWebDriver->waitForElementVisible($modalAcceptButton, 60);
64+
$magentoWebDriver->waitForPageLoad(30);
65+
$magentoWebDriver->waitForElementVisible($modalAcceptButton, 10);
6666
$magentoWebDriver->click($modalAcceptButton);
6767
$magentoWebDriver->waitForPageLoad(60);
68-
$magentoWebDriver->waitForElementVisible($successMessageContainer, 60);
68+
$magentoWebDriver->waitForElementVisible($successMessageContainer, 10);
6969
$magentoWebDriver->see($successMessage, $successMessageContainer);
7070

7171
$rows = $webDriver->findElements(WebDriverBy::cssSelector($emptyRow));

app/code/Magento/Ui/view/base/web/js/grid/masonry.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,9 @@ define([
129129
* Set layout styles inside the container
130130
*/
131131
setLayoutStyles: function (callback) {
132+
var containerWidth, rowImages, ratio, rowHeight, calcHeight, isLastRow, rowNumber;
132133
if (typeof this.container != 'undefined') {
133-
var containerWidth = parseInt(this.container.clientWidth, 10),
134+
containerWidth = parseInt(this.container.clientWidth, 10),
134135
rowImages = [],
135136
ratio = 0,
136137
rowHeight = 0,
@@ -145,7 +146,10 @@ define([
145146
rowImages.push(image);
146147

147148
if (ratio < this.minRatio && index + 1 !== this.rows().length) {
148-
// Row has more space for images and the image is not the last one - proceed to the next iteration
149+
/**
150+
* Row has more space for images and the image is not the last one -
151+
* Proceed to the next iteration
152+
*/
149153
return;
150154
}
151155

0 commit comments

Comments
 (0)