MAGETWO-61778: Implement config:set command

shiftedreality · shiftedreality · commit 5d506a0f4f48 · 2017-02-02T12:31:03.000+02:00
diff --git a/app/code/Magento/Config/Console/Command/ConfigSet/ConfigSetProcessorInterface.php b/app/code/Magento/Config/Console/Command/ConfigSet/ConfigSetProcessorInterface.php
@@ -5,22 +5,25 @@
  */
 namespace Magento\Config\Console\Command\ConfigSet;
 
+use Magento\Config\Console\Command\ConfigSetCommand;
 use Magento\Framework\Exception\CouldNotSaveException;
-use Symfony\Component\Console\Input\InputInterface;
 
 /**
  * Allows to process different flows of config:set command.
  *
- * @see \Magento\Config\Console\Command\ConfigSetCommand
+ * @see ConfigSetCommand
  */
 interface ConfigSetProcessorInterface
 {
     /**
      * Processes config:set command.
      *
-     * @param InputInterface $input An input console parameter
+     * @param string $path The configuration path in format group/section/field_name
+     * @param string $value The configuration value
+     * @param string $scope The configuration scope (default, website, or store)
+     * @param string $scopeCode The scope code
      * @return void
      * @throws CouldNotSaveException An exception on processing error
      */
-    public function process(InputInterface $input);
+    public function process($path, $value, $scope, $scopeCode);
 }
diff --git a/app/code/Magento/Config/Console/Command/ConfigSet/DefaultProcessor.php b/app/code/Magento/Config/Console/Command/ConfigSet/DefaultProcessor.php
@@ -13,7 +13,6 @@
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Exception\CouldNotSaveException;
 use Magento\Store\Model\ScopeInterface;
-use Symfony\Component\Console\Input\InputInterface;
 
 /**
  * Processes default flow of config:set command.
@@ -66,17 +65,8 @@ public function __construct(
      *
      * {@inheritdoc}
      */
-    public function process(InputInterface $input)
+    public function process($path, $value, $scope, $scopeCode)
     {
-        try {
-            $path = $input->getArgument(ConfigSetCommand::ARG_PATH);
-            $value = $input->getArgument(ConfigSetCommand::ARG_VALUE);
-            $scope = $input->getOption(ConfigSetCommand::OPTION_SCOPE);
-            $scopeCode = $input->getOption(ConfigSetCommand::OPTION_SCOPE_CODE);
-        } catch (\Exception $exception) {
-            throw new CouldNotSaveException(__('%1', $exception->getMessage()), $exception);
-        }
-
         if (!$this->deploymentConfig->isAvailable()) {
             throw new CouldNotSaveException(
                 __(
diff --git a/app/code/Magento/Config/Console/Command/ConfigSet/LockProcessor.php b/app/code/Magento/Config/Console/Command/ConfigSet/LockProcessor.php
@@ -6,17 +6,14 @@
 namespace Magento\Config\Console\Command\ConfigSet;
 
 use Magento\Config\App\Config\Type\System;
-use Magento\Config\Console\Command\ConfigSetCommand;
 use Magento\Config\Model\Config\Structure;
-use Magento\Config\Model\Config\Structure\Element\Field;
 use Magento\Framework\App\Config\ConfigPathResolver;
 use Magento\Framework\App\Config\Value;
 use Magento\Framework\App\Config\ValueFactory;
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Config\File\ConfigFilePool;
 use Magento\Framework\Exception\CouldNotSaveException;
 use Magento\Framework\Stdlib\ArrayManager;
-use Symfony\Component\Console\Input\InputInterface;
 
 /**
  * Processes file lock flow of config:set command.
@@ -99,16 +96,11 @@ public function __construct(
      *
      * {@inheritdoc}
      */
-    public function process(InputInterface $input)
+    public function process($path, $value, $scope, $scopeCode)
     {
         try {
-            $path = $input->getArgument(ConfigSetCommand::ARG_PATH);
-            $value = $input->getArgument(ConfigSetCommand::ARG_VALUE);
-            $scope = $input->getOption(ConfigSetCommand::OPTION_SCOPE);
-            $scopeCode = $input->getOption(ConfigSetCommand::OPTION_SCOPE_CODE);
-
             $configPath = $this->configPathResolver->resolve($path, $scope, $scopeCode, System::CONFIG_TYPE);
-            /** @var Field $field */
+            /** @var Structure\Element\Field $field */
             $field = $this->deploymentConfig->isAvailable()
                 ? $this->configStructure->getElement($path)
                 : null;
diff --git a/app/code/Magento/Config/Console/Command/ConfigSetCommand.php b/app/code/Magento/Config/Console/Command/ConfigSetCommand.php
@@ -90,7 +90,7 @@ protected function configure()
                     static::OPTION_SCOPE_CODE,
                     null,
                     InputArgument::OPTIONAL,
-                    'Scope code (required only if scope code is not \'default\')'
+                    'Scope code (required only if scope is not \'default\')'
                 ),
                 new InputOption(
                     static::OPTION_LOCK,
@@ -127,7 +127,12 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 : 'Value was saved.';
 
             // The processing flow depends on --lock option.
-            $processor->process($input);
+            $processor->process(
+                $input->getArgument(ConfigSetCommand::ARG_PATH),
+                $input->getArgument(ConfigSetCommand::ARG_VALUE),
+                $input->getOption(ConfigSetCommand::OPTION_SCOPE),
+                $input->getOption(ConfigSetCommand::OPTION_SCOPE_CODE)
+            );
 
             $output->writeln('<info>' . $message . '</info>');
 
diff --git a/app/code/Magento/Config/Test/Unit/Console/Command/ConfigSet/DefaultProcessorTest.php b/app/code/Magento/Config/Test/Unit/Console/Command/ConfigSet/DefaultProcessorTest.php
@@ -7,15 +7,13 @@
 
 use Magento\Config\App\Config\Type\System;
 use Magento\Config\Console\Command\ConfigSet\DefaultProcessor;
-use Magento\Config\Console\Command\ConfigSetCommand;
 use Magento\Config\Model\Config;
 use Magento\Config\Model\ConfigFactory;
 use Magento\Framework\App\Config\ConfigPathResolver;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Store\Model\ScopeInterface;
 use PHPUnit_Framework_MockObject_MockObject as Mock;
-use Symfony\Component\Console\Input\InputInterface;
 
 /**
  * Test for DefaultProcessor.
@@ -50,11 +48,6 @@ class DefaultProcessorTest extends \PHPUnit_Framework_TestCase
      */
     private $configPathResolverMock;
 
-    /**
-     * @var InputInterface|Mock
-     */
-    private $inputMock;
-
     /**
      * @inheritdoc
      */
@@ -70,8 +63,6 @@ protected function setUp()
         $this->deploymentConfigMock = $this->getMockBuilder(DeploymentConfig::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->inputMock = $this->getMockBuilder(InputInterface::class)
-            ->getMockForAbstractClass();
         $this->configPathResolverMock = $this->getMockBuilder(ConfigPathResolver::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -98,18 +89,6 @@ protected function setUp()
      */
     public function testProcess($path, $value, $scope, $scopeCode)
     {
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value]
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, $scope],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, $scopeCode],
-            ]);
         $this->configPathResolverMock->expects($this->once())
             ->method('resolve')
             ->with($path, $scope, $scopeCode, System::CONFIG_TYPE)
@@ -125,7 +104,7 @@ public function testProcess($path, $value, $scope, $scopeCode)
         $this->configMock->expects($this->once())
             ->method('save');
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, $scope, $scopeCode);
     }
 
     /**
@@ -149,25 +128,13 @@ public function testProcessNotInstalled()
         $path = 'test/test/test';
         $value = 'value';
 
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value]
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, ScopeConfigInterface::SCOPE_TYPE_DEFAULT],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, null],
-            ]);
         $this->deploymentConfigMock->expects($this->once())
             ->method('isAvailable')
             ->willReturn(false);
         $this->configMock->expects($this->never())
             ->method('save');
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
     }
 
     /**
@@ -179,18 +146,6 @@ public function testProcessLockedValue()
         $path = 'test/test/test';
         $value = 'value';
 
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value]
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, ScopeConfigInterface::SCOPE_TYPE_DEFAULT],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, null],
-            ]);
         $this->deploymentConfigMock->expects($this->once())
             ->method('isAvailable')
             ->willReturn(true);
@@ -204,6 +159,6 @@ public function testProcessLockedValue()
             ->method('resolve')
             ->willReturn('system/default/test/test/test');
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
     }
 }
diff --git a/app/code/Magento/Config/Test/Unit/Console/Command/ConfigSet/LockProcessorTest.php b/app/code/Magento/Config/Test/Unit/Console/Command/ConfigSet/LockProcessorTest.php
@@ -6,7 +6,6 @@
 namespace Magento\Config\Test\Unit\Console\Command\ConfigSet;
 
 use Magento\Config\Console\Command\ConfigSet\LockProcessor;
-use Magento\Config\Console\Command\ConfigSetCommand;
 use Magento\Config\Model\Config\Structure;
 use Magento\Config\Model\Config\Structure\Element\Field;
 use Magento\Framework\App\Config\ConfigPathResolver;
@@ -19,7 +18,6 @@
 use Magento\Framework\Stdlib\ArrayManager;
 use Magento\Store\Model\ScopeInterface;
 use PHPUnit_Framework_MockObject_MockObject as Mock;
-use Symfony\Component\Console\Input\InputInterface;
 
 /**
  * Test for LockProcessor.
@@ -49,11 +47,6 @@ class LockProcessorTest extends \PHPUnit_Framework_TestCase
      */
     private $arrayManagerMock;
 
-    /**
-     * @var InputInterface|Mock
-     */
-    private $inputMock;
-
     /**
      * @var ConfigPathResolver|Mock
      */
@@ -93,8 +86,6 @@ protected function setUp()
         $this->arrayManagerMock = $this->getMockBuilder(ArrayManager::class)
             ->disableOriginalConstructor()
             ->getMock();
-        $this->inputMock = $this->getMockBuilder(InputInterface::class)
-            ->getMockForAbstractClass();
         $this->configPathResolver = $this->getMockBuilder(ConfigPathResolver::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -143,18 +134,6 @@ protected function setUp()
      */
     public function testProcess($path, $value, $scope, $scopeCode)
     {
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value],
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, $scope],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, $scopeCode]
-            ]);
         $this->fieldMock->expects($this->once())
             ->method('hasBackendModel')
             ->willReturn(true);
@@ -206,7 +185,7 @@ public function testProcess($path, $value, $scope, $scopeCode)
         $this->valueMock->expects($this->once())
             ->method('afterSave');
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, $scope, $scopeCode);
     }
 
     /**
@@ -226,18 +205,6 @@ public function testProcessBackendModelNotExists()
         $path = 'test/test/test';
         $value = 'value';
 
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value],
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, ScopeConfigInterface::SCOPE_TYPE_DEFAULT],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, 'test_scope_code']
-            ]);
         $this->fieldMock->expects($this->once())
             ->method('hasBackendModel')
             ->willReturn(false);
@@ -282,7 +249,7 @@ public function testProcessBackendModelNotExists()
                 false
             );
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
     }
 
     /**
@@ -294,18 +261,6 @@ public function testProcessNotReadableFs()
         $path = 'test/test/test';
         $value = 'value';
 
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value],
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, ScopeConfigInterface::SCOPE_TYPE_DEFAULT],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, 'test_scope_code'],
-            ]);
         $this->fieldMock->expects($this->once())
             ->method('hasBackendModel')
             ->willReturn(true);
@@ -326,7 +281,7 @@ public function testProcessNotReadableFs()
             ->method('saveConfig')
             ->willThrowException(new FileSystemException(__('Filesystem is not writable.')));
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
     }
 
     /**
@@ -338,18 +293,6 @@ public function testCustomException()
         $path = 'test/test/test';
         $value = 'value';
 
-        $this->inputMock->expects($this->any())
-            ->method('getArgument')
-            ->willReturnMap([
-                [ConfigSetCommand::ARG_PATH, $path],
-                [ConfigSetCommand::ARG_VALUE, $value],
-            ]);
-        $this->inputMock->expects($this->any())
-            ->method('getOption')
-            ->willReturnMap([
-                [ConfigSetCommand::OPTION_SCOPE, ScopeConfigInterface::SCOPE_TYPE_DEFAULT],
-                [ConfigSetCommand::OPTION_SCOPE_CODE, 'test_scope_code']
-            ]);
         $this->fieldMock->expects($this->once())
             ->method('hasBackendModel')
             ->willReturn(true);
@@ -369,6 +312,6 @@ public function testCustomException()
         $this->deploymentConfigWriterMock->expects($this->never())
             ->method('saveConfig');
 
-        $this->model->process($this->inputMock);
+        $this->model->process($path, $value, ScopeConfigInterface::SCOPE_TYPE_DEFAULT, null);
     }
 }
