Skip to content

Commit 5ca8bb4

Browse files
committed
ACP2E-2622: Unable to save changes to phone number in existing order details
- Fixed build failures
1 parent b527f4c commit 5ca8bb4

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

app/code/Magento/Sales/Model/ResourceModel/Order/Address.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
class Address extends SalesResource implements OrderAddressResourceInterface
1616
{
1717
/**
18-
* Event prefix
18+
* Sales order address event prefix
1919
*
2020
* @var string
2121
*/
@@ -33,10 +33,10 @@ class Address extends SalesResource implements OrderAddressResourceInterface
3333

3434
/**
3535
* @param \Magento\Framework\Model\ResourceModel\Db\Context $context
36-
* @param \Magento\Sales\Model\ResourceModel\Attribute $attribute
37-
* @param \Magento\SalesSequence\Model\Manager $sequenceManager
3836
* @param Snapshot $entitySnapshot
3937
* @param \Magento\Framework\Model\ResourceModel\Db\VersionControl\RelationComposite $entityRelationComposite
38+
* @param \Magento\Sales\Model\ResourceModel\Attribute $attribute
39+
* @param \Magento\SalesSequence\Model\Manager $sequenceManager
4040
* @param \Magento\Sales\Model\Order\Address\Validator $validator
4141
* @param \Magento\Sales\Model\ResourceModel\GridPool $gridPool
4242
* @param string $connectionName

app/code/Magento/Sales/Test/Unit/Model/ResourceModel/Order/AddressTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ public function testSave()
9898
->method('validate')
9999
->with($this->addressMock)
100100
->willReturn([]);
101-
$this->entitySnapshotMock->expects($this->once())
102-
->method('isModified')
103-
->with($this->addressMock)
104-
->willReturn(true);
105101
$this->addressMock->expects($this->once())
106102
->method('getParentId')
107103
->willReturn(1);
@@ -116,10 +112,6 @@ public function testSaveValidationFailed()
116112
{
117113
$this->expectException('Magento\Framework\Exception\LocalizedException');
118114
$this->expectExceptionMessage('We can\'t save the address:');
119-
$this->entitySnapshotMock->expects($this->once())
120-
->method('isModified')
121-
->with($this->addressMock)
122-
->willReturn(true);
123115
$this->addressMock->expects($this->any())
124116
->method('hasDataChanges')
125117
->willReturn(true);

lib/internal/Magento/Framework/Model/ResourceModel/Db/VersionControl/Snapshot.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,14 @@ public function registerSnapshot(\Magento\Framework\DataObject $entity)
5959
*/
6060
public function getSnapshotData(\Magento\Framework\DataObject $entity)
6161
{
62-
return $this->snapshotData[get_class($entity)][$entity->getId()];
62+
$entityClass = get_class($entity);
63+
$entityId = $entity->getId();
64+
65+
if (isset($this->snapshotData[$entityClass][$entityId])) {
66+
return $this->snapshotData[$entityClass][$entityId];
67+
}
68+
69+
return [];
6370
}
6471

6572
/**

0 commit comments

Comments
 (0)