MAGETWO-87190: Test coverage for critical logic

Author: Sergii Kovalenko

dev/tests/setup-integration/testsuite/Magento/Setup/DeclarativeSchemaBuilderTest.php

@@ -38,7 +38,7 @@ class DeclarativeSchemaBuilderTest extends SetupTestCase
     public function setUp()
     {
         $objectManager = Bootstrap::getObjectManager();
-        $this->schemaConfig = $objectManager->create(SchemaConfig::class);
+        $this->schemaConfig = $objectManager->get(SchemaConfig::class);
         $this->moduleManager = $objectManager->get(TestModuleManager::class);
         $this->cliCommad = $objectManager->get(CliCommand::class);
     }

setup/src/Magento/Setup/Model/Declaration/Schema/Declaration/ReaderComposite.php

@@ -6,6 +6,7 @@
 
 namespace Magento\Setup\Model\Declaration\Schema\Declaration;
 
+use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Config\ReaderInterface;
 
 /**
@@ -20,14 +21,21 @@ class ReaderComposite implements ReaderInterface
      */
     private $readers;
 
+    /**
+     * @var DeploymentConfig
+     */
+    private $deploymentConfig;
+
     /**
      * Constructor.
      *
+     * @param DeploymentConfig $deploymentConfig
      * @param ReaderInterface[] $readers
      */
-    public function __construct(array $readers = [])
+    public function __construct(DeploymentConfig $deploymentConfig, array $readers = [])
     {
         $this->readers = $readers;
+        $this->deploymentConfig = $deploymentConfig;
     }
 
     /**
@@ -39,7 +47,12 @@ public function read($scope = null)
         foreach ($this->readers as $reader) {
             $schema = array_replace_recursive($schema, $reader->read($scope));
         }
-        var_dump($schema);
+
+        if (!count($schema)) {
+            var_dump($this->deploymentConfig->get());
+            var_dump($this->deploymentConfig->getConfigData());
+        }
+
         return $schema;
     }
 }