Skip to content

Commit 5c15c93

Browse files
Pooja.ManralPooja.Manral
authored andcommitted
AC-9843:: i18n:collect-phrases breaks the translations integrity
1 parent 3151fbd commit 5c15c93

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/TranslationFilesTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use Magento\Setup\Module\I18n\Dictionary\Options\ResolverFactory;
1111
use Magento\Setup\Module\I18n\Locale;
1212
use Magento\Setup\Module\I18n\Pack\Writer\File\Csv;
13+
use Magento\Framework\Filesystem\Driver\File;
1314

1415
/**
1516
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -104,9 +105,10 @@ protected function prepareParser()
104105
$phraseCollector = new \Magento\Setup\Module\I18n\Parser\Adapter\Php\Tokenizer\PhraseCollector(
105106
new \Magento\Setup\Module\I18n\Parser\Adapter\Php\Tokenizer()
106107
);
108+
$fileSystem = new File;
107109
$adapters = [
108110
'php' => new \Magento\Setup\Module\I18n\Parser\Adapter\Php($phraseCollector),
109-
'js' => new \Magento\Setup\Module\I18n\Parser\Adapter\Js(),
111+
'js' => new \Magento\Setup\Module\I18n\Parser\Adapter\Js($fileSystem),
110112
'xml' => new \Magento\Setup\Module\I18n\Parser\Adapter\Xml(),
111113
'html' => new \Magento\Setup\Module\I18n\Parser\Adapter\Html(),
112114
];

setup/src/Magento/Setup/Module/I18n/Parser/Adapter/Js.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public function __construct(File $filesystem)
4747

4848
/**
4949
* @inheritdoc
50+
*
5051
* @throws FileSystemException
5152
*/
5253
protected function _parse()

0 commit comments

Comments
 (0)