Merge branch '2.4.develop-bugfix-Product-Media-Gallery-GQL-response-is-not-sorted-by-image-position' of https://github.com/Kannakiraj123/magento2 into ACP2E-3126

thiaramus · thiaramus · commit 5c130dbf5bf5 · 2024-07-10T11:09:25.000-05:00
diff --git a/app/code/Magento/Catalog/Model/Product/Gallery/ReadHandler.php b/app/code/Magento/Catalog/Model/Product/Gallery/ReadHandler.php
@@ -64,7 +64,7 @@ public function execute($entity, $arguments = [])
 
         $this->addMediaDataToProduct(
             $entity,
-            $this->sortMediaEntriesByPosition($mediaEntries)
+            $mediaEntries
         );
 
         return $entity;
@@ -80,6 +80,7 @@ public function execute($entity, $arguments = [])
      */
     public function addMediaDataToProduct(Product $product, array $mediaEntries)
     {
+        $mediaEntries = $this->sortMediaEntriesByPosition($mediaEntries);
         $product->setData(
             $this->getAttribute()->getAttributeCode(),
             [

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public function execute($entity, $arguments = [])`
`64`	`64`
`65`	`65`	`$this->addMediaDataToProduct(`
`66`	`66`	`$entity,`
`67`		`- $this->sortMediaEntriesByPosition($mediaEntries)`
	`67`	`+ $mediaEntries`
`68`	`68`	`);`
`69`	`69`
`70`	`70`	`return $entity;`
`@@ -80,6 +80,7 @@ public function execute($entity, $arguments = [])`
`80`	`80`	`*/`
`81`	`81`	`public function addMediaDataToProduct(Product $product, array $mediaEntries)`
`82`	`82`	`{`
	`83`	`+ $mediaEntries = $this->sortMediaEntriesByPosition($mediaEntries);`
`83`	`84`	`$product->setData(`
`84`	`85`	`$this->getAttribute()->getAttributeCode(),`
`85`	`86`	`[`