Skip to content

Commit 5bfdb38

Browse files
Change whitelist files to process selection approach, change env value to const
1 parent 976e570 commit 5bfdb38

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

dev/tests/static/phpunit.xml.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
</testsuites>
3131
<php>
3232
<ini name="date.timezone" value="America/Los_Angeles"/>
33-
<env name="phpunit.static.testcodestyle.use_whitelist" value="0"/>
33+
<const name="TESTCODESTYLE_IS_FULL_SCAN" value="1"/>
3434
<!-- TESTS_COMPOSER_PATH - specify the path to composer binary, if a relative reference cannot be resolved -->
3535
<!--<const name="TESTS_COMPOSER_PATH" value="/usr/local/bin/composer"/>-->
3636
</php>

dev/tests/static/testsuite/Magento/Test/Php/LiveCodeTest.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,8 @@ private function getFullWhitelist()
201201

202202
public function testCodeStyle()
203203
{
204-
$useWhiteList = isset($_ENV['phpunit.static.testcodestyle.use_whitelist'])
205-
&& $_ENV['phpunit.static.testcodestyle.use_whitelist'] === '1';
206-
207-
$whiteList = $useWhiteList ? self::getWhitelist(['php']) : $this->getFullWhitelist();
204+
$whiteList = defined('TESTCODESTYLE_IS_FULL_SCAN') && TESTCODESTYLE_IS_FULL_SCAN === '1'
205+
? $this->getFullWhitelist() : self::getWhitelist(['php', 'phtml']);
208206

209207
$reportFile = self::$reportDir . '/phpcs_report.txt';
210208
$codeSniffer = new CodeSniffer('Magento', $reportFile, new Wrapper());

0 commit comments

Comments
 (0)