Skip to content

Commit 5b9f11d

Browse files
author
Dale Sikkema
committed
MAGETWO-43435: [Github] «i18n:collect-phrases» command wrongly handles PHP string concatenation
- style test fixes
1 parent f7c7bc2 commit 5b9f11d

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

dev/tests/integration/testsuite/Magento/Setup/Console/Command/_files/phrases/TestPhrases.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
use Magento\Framework\Phrase;
1010

11+
/**
12+
* @SuppressWarnings(PHPMD)
13+
*/
1114
class TestPhrases
1215
{
1316
public function awesomeFunction()

setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,11 @@ public function testCollectPhrases()
215215
$phraseTokens = [$firstPartToken, $concatenationToken, $secondPartToken];
216216
$phraseString = "'first part' . ' second part'";
217217

218-
$reflectionMethod = new \ReflectionMethod('\Magento\Setup\Module\I18n\Parser\Adapter\Php\Tokenizer\PhraseCollector', '_collectPhrase');
218+
$reflectionMethod = new \ReflectionMethod(
219+
'\Magento\Setup\Module\I18n\Parser\Adapter\Php\Tokenizer\PhraseCollector',
220+
'_collectPhrase'
221+
);
222+
219223
$reflectionMethod->setAccessible(true);
220224
$this->assertSame($phraseString, $reflectionMethod->invoke($this->phraseCollector, $phraseTokens));
221225
}

0 commit comments

Comments
 (0)