#28579:DependencyTest does not analyze GraphQL schema files - fixed tests

Author: sasha19957099

dev/tests/integration/testsuite/Magento/Framework/GraphQl/GraphQlConfigTest.php

@@ -36,9 +36,11 @@ protected function setUp(): void
         $fileResolverMock = $this->getMockBuilder(
             \Magento\Framework\Config\FileResolverInterface::class
         )->disableOriginalConstructor()->getMock();
+        $filePath1 = __DIR__ . '/_files/schemaC.graphqls';
+        $filePath2 = __DIR__ . '/_files/schemaD.graphqls';
         $fileList = [
-            file_get_contents(__DIR__ . '/_files/schemaC.graphqls'),
-            file_get_contents(__DIR__ . '/_files/schemaD.graphqls')
+            $filePath1 => file_get_contents($filePath1),
+            $filePath2 => file_get_contents($filePath2)
         ];
         $fileResolverMock->expects($this->any())->method('get')->willReturn($fileList);
         $graphQlReader = $objectManager->create(

dev/tests/static/testsuite/Magento/Test/Integrity/Dependency/DependencyProvider.php

@@ -1,4 +1,10 @@
 <?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
 
 namespace Magento\Test\Integrity\Dependency;
 
@@ -82,11 +88,7 @@ protected function initDeclaredDependencies()
      * @return void
      * @throws \Exception
      */
-    protected function presetDependencies(
-        string $moduleName,
-        array $packageNames,
-        string $type
-    ): void
+    protected function presetDependencies(string $moduleName, array $packageNames, string $type): void
     {
         $packageNames = array_filter($packageNames, function ($packageName) {
             return $this->getModuleName($packageName) ||

dev/tests/static/testsuite/Magento/Test/Integrity/Dependency/GraphQlSchemaDependencyProvider.php

@@ -1,12 +1,19 @@
 <?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
 
 namespace Magento\Test\Integrity\Dependency;
 
 use Magento\Framework\App\Bootstrap;
 
 /**
- * Class GraphQlSchemaDependencyProvider
- * @package Magento\Test\Integrity\Dependency
+ * Provide information on the dependency between the modules according to the GraphQL schema.
+ *
+ * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
  */
 class GraphQlSchemaDependencyProvider extends DependencyProvider
 {
@@ -98,10 +105,11 @@ private function getDependenciesFromSchema(string $moduleName): array
 
         $dependencies = [];
 
-        foreach ($schema as $typeName => $type) {
+        foreach ($schema as $type) {
             if (isset($type['module']) && $type['module'] == $moduleName && isset($type['implements'])) {
-                foreach ($type['implements'] as $interfaceName => $interfaceData) {
-                    $dependOnModule = $schema[$interfaceName]['module'];
+                $interfaces = array_keys($type['implements']);
+                foreach ($interfaces as $interface) {
+                    $dependOnModule = $schema[$interface]['module'];
                     if ($dependOnModule != $moduleName) {
                         $dependencies[] = $dependOnModule;
                     }

dev/tests/static/testsuite/Magento/Test/Integrity/GraphQlDependencyTest.php

@@ -1,9 +1,13 @@
 <?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
 
+declare(strict_types=1);
 
 namespace Magento\Test\Integrity;
 
-
 use Magento\Framework\App\Utility\Files;
 use Magento\Framework\Component\ComponentRegistrar;
 use Magento\Test\Integrity\Dependency\GraphQlSchemaDependencyProvider;

lib/internal/Magento/Framework/GraphQlSchemaStitching/GraphQlReader.php

@@ -9,8 +9,8 @@
 
 use Magento\Framework\Component\ComponentRegistrar;
 use Magento\Framework\Config\FileResolverInterface;
-use Magento\Framework\GraphQlSchemaStitching\GraphQlReader\TypeMetaReaderInterface as TypeReaderComposite;
 use Magento\Framework\Config\ReaderInterface;
+use Magento\Framework\GraphQlSchemaStitching\GraphQlReader\TypeMetaReaderInterface as TypeReaderComposite;
 
 /**
  * Reads *.graphqls files from modules and combines the results as array to be used with a library to configure objects
@@ -67,7 +67,10 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     *
+     * @param string|null $scope
+     * @return array
      */
     public function read($scope = null) : array
     {
@@ -335,8 +338,9 @@ private function addModuleNameToTypes(array $source, string $filePath): array
     {
         foreach ($source as $typeName => $type) {
             if (!isset($type['module']) && (
-                    ($type['type'] == 'graphql_interface' && isset($type['typeResolver']))
-                    || isset($type['implements']))
+                ($type['type'] == 'graphql_interface' && isset($type['typeResolver']))
+                    || isset($type['implements'])
+            )
             ) {
                 $source[$typeName]['module'] = self::getModuleNameForRelevantFile($filePath);
             }