Skip to content

Commit 5b5c688

Browse files
author
Hwashiang Yu
committed
MC-30925: Customer group API update
- Fixed test coverae for group API
1 parent 97b190e commit 5b5c688

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

dev/tests/api-functional/testsuite/Magento/Customer/Api/AccountManagementMeTest.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
/**
1717
* Class AccountManagementMeTest
1818
*
19+
* Tests involving the customer modifying their user information via web API.
20+
*
1921
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
2022
* @magentoApiDataFixture Magento/Customer/_files/customer.php
2123
* @magentoApiDataFixture Magento/Customer/_files/customer_two_addresses.php
@@ -144,13 +146,14 @@ public function testUpdateCustomer()
144146
{
145147
$customerData = $this->_getCustomerData($this->customerData[CustomerInterface::ID]);
146148
$lastName = $customerData->getLastname();
147-
149+
$groupID = $customerData->getGroupId();
148150
$updatedCustomerData = $this->dataObjectProcessor->buildOutputDataArray(
149151
$customerData,
150152
\Magento\Customer\Api\Data\CustomerInterface::class
151153
);
152154
$updatedCustomerData[CustomerInterface::LASTNAME] = $lastName . 'Updated';
153155
$updatedCustomerData[CustomerInterface::ID] = 25;
156+
$updatedCustomerData[CustomerInterface::GROUP_ID] = $groupID . 1;
154157

155158
$serviceInfo = [
156159
'rest' => [
@@ -172,6 +175,7 @@ public function testUpdateCustomer()
172175

173176
$customerData = $this->_getCustomerData($this->customerData[CustomerInterface::ID]);
174177
$this->assertEquals($lastName . "Updated", $customerData->getLastname());
178+
$this->assertEquals($groupID, $customerData->getGroupId());
175179
}
176180

177181
public function testGetCustomerData()

dev/tests/api-functional/testsuite/Magento/Customer/Api/CustomerRepositoryTest.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,6 @@ public function testUpdateCustomer()
268268
$customerData = $this->_createCustomer();
269269
$existingCustomerDataObject = $this->_getCustomerData($customerData[Customer::ID]);
270270
$lastName = $existingCustomerDataObject->getLastname();
271-
$expectedGroupID = $existingCustomerDataObject->getGroupId();
272271
$customerData[Customer::LASTNAME] = $lastName . 'Updated';
273272
$newCustomerDataObject = $this->customerDataFactory->create();
274273
$this->dataObjectHelper->populateWithArray(
@@ -297,12 +296,8 @@ public function testUpdateCustomer()
297296
$this->assertTrue($response !== null);
298297

299298
//Verify if the customer is updated
300-
$updatedCustomerDataObject = $this->_getCustomerData($customerData[Customer::ID]);
301-
$this->assertEquals(
302-
$updatedCustomerDataObject->getGroupId(),
303-
$expectedGroupID
304-
);
305-
$this->assertEquals($lastName . "Updated", $updatedCustomerDataObject->getLastname());
299+
$existingCustomerDataObject = $this->_getCustomerData($customerData[Customer::ID]);
300+
$this->assertEquals($lastName . "Updated", $existingCustomerDataObject->getLastname());
306301
}
307302

308303
/**

0 commit comments

Comments
 (0)