ENGCOM-773: Return status in console commands #13809

Author: Stanislav Idolov

setup/src/Magento/Setup/Console/Command/AbstractDependenciesCommand.php

@@ -107,5 +107,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
             // we must have an exit code higher than zero to indicate something was wrong
             return \Magento\Framework\Console\Cli::RETURN_FAILURE;
         }
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 }

setup/src/Magento/Setup/Console/Command/AbstractMaintenanceCommand.php

@@ -99,6 +99,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 . '</info>'
             );
         }
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 
     /**

setup/src/Magento/Setup/Console/Command/AbstractModuleManageCommand.php

@@ -12,6 +12,7 @@
 use Symfony\Component\Console\Input\InputOption;
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Module\Status;
+use Magento\Framework\Console\Cli;
 
 abstract class AbstractModuleManageCommand extends AbstractModuleCommand
 {
@@ -77,14 +78,14 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if (!empty($messages)) {
             $output->writeln(implode(PHP_EOL, $messages));
             // we must have an exit code higher than zero to indicate something was wrong
-            return \Magento\Framework\Console\Cli::RETURN_FAILURE;
+            return Cli::RETURN_FAILURE;
         }
         try {
             $modulesToChange = $this->getStatus()->getModulesToChange($isEnable, $modules);
         } catch (\LogicException $e) {
             $output->writeln('<error>' . $e->getMessage() . '</error>');
             // we must have an exit code higher than zero to indicate something was wrong
-            return \Magento\Framework\Console\Cli::RETURN_FAILURE;
+            return Cli::RETURN_FAILURE;
         }
         if (!empty($modulesToChange)) {
             $force = $input->getOption(self::INPUT_KEY_FORCE);
@@ -96,7 +97,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                     );
                     $output->writeln('<error>' . implode("</error>\n<error>", $constraints) . '</error>');
                     // we must have an exit code higher than zero to indicate something was wrong
-                    return \Magento\Framework\Console\Cli::RETURN_FAILURE;
+                    return Cli::RETURN_FAILURE;
                 }
             }
             $this->setIsEnabled($isEnable, $modulesToChange, $output);
@@ -111,6 +112,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         } else {
             $output->writeln('<info>No modules were changed.</info>');
         }
+        return Cli::RETURN_SUCCESS;
     }
 
     /**

setup/src/Magento/Setup/Console/Command/AdminUserCreateCommand.php

@@ -159,6 +159,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $output->writeln(
             '<info>Created Magento administrator user named ' . $input->getOption(AdminAccount::KEY_USER) . '</info>'
         );
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 
     /**

setup/src/Magento/Setup/Console/Command/ConfigSetCommand.php

@@ -126,6 +126,7 @@ function ($value) {
                 $output->writeln('<info>You made no changes to the configuration.</info>');
             }
         }
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 
     /**

setup/src/Magento/Setup/Console/Command/DbDataUpgradeCommand.php

@@ -67,5 +67,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
         $installer = $this->installFactory->create(new ConsoleLogger($output));
         $installer->installDataFixtures();
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 }

setup/src/Magento/Setup/Console/Command/DbSchemaUpgradeCommand.php

@@ -81,6 +81,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
         $installer = $this->installFactory->create(new ConsoleLogger($output));
         $installer->installSchema($input->getOptions());
-        return null;
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 }

setup/src/Magento/Setup/Console/Command/DiCompileCommand.php

@@ -21,6 +21,7 @@
 use Magento\Setup\Module\Di\App\Task\OperationInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\ProgressBar;
+use Magento\Framework\Console\Cli;
 
 /**
  * Command to run compile in single-tenant mode
@@ -141,7 +142,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $output->writeln($line);
             }
             // we must have an exit code higher than zero to indicate something was wrong
-            return \Magento\Framework\Console\Cli::RETURN_FAILURE;
+            return Cli::RETURN_FAILURE;
         }
 
         $modulePaths = $this->componentRegistrar->getPaths(ComponentRegistrar::MODULE);
@@ -211,8 +212,9 @@ function (OperationInterface $operation) use ($progressBar) {
         } catch (OperationException $e) {
             $output->writeln('<error>' . $e->getMessage() . '</error>');
             // we must have an exit code higher than zero to indicate something was wrong
-            return \Magento\Framework\Console\Cli::RETURN_FAILURE;
+            return Cli::RETURN_FAILURE;
         }
+        return Cli::RETURN_SUCCESS;
     }
 
     /**

setup/src/Magento/Setup/Console/Command/GenerateFixturesCommand.php

@@ -133,6 +133,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             // we must have an exit code higher than zero to indicate something was wrong
             return \Magento\Framework\Console\Cli::RETURN_FAILURE;
         }
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 
     /**

setup/src/Magento/Setup/Console/Command/I18nCollectPhrasesCommand.php

@@ -77,5 +77,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $input->getOption(self::INPUT_KEY_MAGENTO)
         );
         $output->writeln('<info>Dictionary successfully processed.</info>');
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 }