Skip to content

Commit 5aa39d1

Browse files
committed
B2B-2530: Unskip GraphQL cache tests skipped due to DEVOPS-4924
- Fixed static issue and other new review comments
1 parent 5232253 commit 5aa39d1

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/CacheTagTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use Magento\TestFramework\ObjectManager;
1414

1515
/**
16-
* Test the cache invalidation for products and categories
16+
* Test the cache works properly for products and categories
1717
*/
1818
class CacheTagTest extends GraphQLPageCacheAbstract
1919
{
@@ -107,7 +107,10 @@ public function testCacheInvalidationForCategoriesWithProduct()
107107

108108
// cache-debug header value should be MISS after updating product1 and reloading the Category
109109
$responseMissCategoryAfterProductUpdate = $this->graphQlQueryWithResponseHeaders($categoryQuery);
110-
$this->assertArrayHasKey(CacheIdCalculator::CACHE_ID_HEADER, $responseMissCategoryAfterProductUpdate['headers']);
110+
$this->assertArrayHasKey(
111+
CacheIdCalculator::CACHE_ID_HEADER,
112+
$responseMissCategoryAfterProductUpdate['headers']
113+
);
111114
$cacheId = $responseMissCategoryAfterProductUpdate['headers'][CacheIdCalculator::CACHE_ID_HEADER];
112115
// Verify we obtain a cache MISS the first time we search the cache using this X-Magento-Cache-Id
113116
$this->assertCacheMissAndReturnResponse($categoryQuery, [CacheIdCalculator::CACHE_ID_HEADER => $cacheId]);

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/Cms/BlockCacheTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Magento\TestFramework\Helper\Bootstrap;
1515

1616
/**
17-
* Test the cache invalidation for CMS Blocks
17+
* Test the cache works properly for CMS Blocks
1818
*/
1919
class BlockCacheTest extends GraphQLPageCacheAbstract
2020
{

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/Cms/PageCacheTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Magento\TestFramework\Helper\Bootstrap;
1515

1616
/**
17-
* Test the cache invalidation for CMS Pages
17+
* Test the cache works properly for CMS Pages
1818
*/
1919
class PageCacheTest extends GraphQLPageCacheAbstract
2020
{
@@ -130,7 +130,8 @@ public function testCacheIsInvalidatedOnPageUpdate()
130130

131131
$page100ResponseHitAfterUpdate = $this->graphQlQueryWithResponseHeaders($page100Query);
132132
$this->assertArrayHasKey(CacheIdCalculator::CACHE_ID_HEADER, $page100ResponseHitAfterUpdate['headers']);
133-
$cacheIdPage100ResponseHitAfterUpdate = $page100ResponseHitAfterUpdate['headers'][CacheIdCalculator::CACHE_ID_HEADER];
133+
$cacheIdPage100ResponseHitAfterUpdate =
134+
$page100ResponseHitAfterUpdate['headers'][CacheIdCalculator::CACHE_ID_HEADER];
134135
$this->assertCacheHitAndReturnResponse(
135136
$page100Query,
136137
[CacheIdCalculator::CACHE_ID_HEADER => $cacheIdPage100ResponseHitAfterUpdate]

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/UrlRewrite/UrlResolverCacheTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use Magento\TestFramework\Helper\Bootstrap;
1515

1616
/**
17-
* Test cache works for url resolver.
17+
* Test cache works properly for url resolver.
1818
*/
1919
class UrlResolverCacheTest extends GraphQLPageCacheAbstract
2020
{

0 commit comments

Comments
 (0)