MAGETWO-66047: Remove usages of unserialize in module Magento/Framework/App/PageCache

rganin · rganin · commit 5a952f4959c4 · 2017-03-22T12:01:29.000+02:00
diff --git a/lib/internal/Magento/Framework/App/PageCache/Identifier.php b/lib/internal/Magento/Framework/App/PageCache/Identifier.php
@@ -45,6 +45,6 @@ public function getValue()
             $this->request->get(\Magento\Framework\App\Response\Http::COOKIE_VARY_STRING)
                 ?: $this->context->getVaryString()
         ];
-        return md5(json_encode($data));
+        return sha1(json_encode($data));
     }
 }
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/PageCache/IdentifierTest.php b/lib/internal/Magento/Framework/App/Test/Unit/PageCache/IdentifierTest.php
@@ -145,7 +145,7 @@ public function testGetValue()
             ->will($this->returnValue(self::VARY));
 
         $this->assertEquals(
-            md5(
+            sha1(
                 json_encode(
                     [
                         true,

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,6 @@ public function getValue()`
`45`	`45`	`$this->request->get(\Magento\Framework\App\Response\Http::COOKIE_VARY_STRING)`
`46`	`46`	`?: $this->context->getVaryString()`
`47`	`47`	`];`
`48`		`- return md5(json_encode($data));`
	`48`	`+ return sha1(json_encode($data));`
`49`	`49`	`}`
`50`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ public function testGetValue()`
`145`	`145`	`->will($this->returnValue(self::VARY));`
`146`	`146`
`147`	`147`	`$this->assertEquals(`
`148`		`- md5(`
	`148`	`+ sha1(`
`149`	`149`	`json_encode(`
`150`	`150`	`[`
`151`	`151`	`true,`