MAGETWO-69110: Incorrect status for order placed within Authorize.net with Fraud Filters Triggered (Filter Actions = Process as normal and report filter(s) triggered)

- Fixed static test

Author: viktym

dev/tests/integration/testsuite/Magento/Authorizenet/Model/DirectpostTest.php

@@ -5,19 +5,17 @@
  */
 namespace Magento\Authorizenet\Model;
 
-use Magento\Framework\Simplexml\Element;
-use Magento\Framework\Api\FilterBuilder;
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\HTTP\ZendClient;
 use Magento\Framework\HTTP\ZendClientFactory;
+use Magento\Framework\Simplexml\Element;
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Api\OrderRepositoryInterface;
 use Magento\Sales\Model\Order;
 use Magento\Sales\Model\Order\Payment;
 use Magento\TestFramework\Helper\Bootstrap;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
-use Zend_Http_Response;
 
 /**
  * Class contains tests for Direct Post integration
@@ -74,7 +72,7 @@ public function testCapture()
             ->method('create')
             ->willReturn($httpClient);
 
-        $response = $this->getMockBuilder(Zend_Http_Response::class)
+        $response = $this->getMockBuilder('Zend_Http_Response')
             ->disableOriginalConstructor()
             ->setMethods(['getBody'])
             ->getMock();
@@ -101,7 +99,6 @@ public function testCapture()
         static::assertEquals('UK', $payment->getOrder()->getShippingAddress()->getCountryId());
     }
 
-
     /**
      * Verifies that order is placed in correct state according the action taken for a transaction that
      * triggered one or more of the Advanced Fraud Detection Suite filters.
@@ -136,8 +133,16 @@ public function testProcessWithFdsFilterActionReportOnly($filterAction, $orderId
     public function fdsFilterActionDataProvider()
     {
         return [
-            ['filter_action' => 'authAndHold', 'order_id' => '100000003', 'expected_order_state' => Order::STATE_PAYMENT_REVIEW],
-            ['filter_action' => 'report', 'order_id' => '100000004', 'expected_order_state' => Order::STATE_PROCESSING],
+            [
+                'filter_action' => 'authAndHold',
+                'order_id' => '100000003',
+                'expected_order_state' => Order::STATE_PAYMENT_REVIEW
+            ],
+            [
+                'filter_action' => 'report',
+                'order_id' => '100000004',
+                'expected_order_state' => Order::STATE_PROCESSING
+            ],
         ];
     }
 
@@ -204,17 +209,9 @@ private function getSuccessResponse($orderId)
      */
     private function getPayment($orderId)
     {
-        /** @var FilterBuilder $filterBuilder */
-        $filterBuilder = $this->objectManager->get(FilterBuilder::class);
-        $filters = [
-            $filterBuilder->setField(OrderInterface::INCREMENT_ID)
-                ->setValue($orderId)
-                ->create()
-        ];
-
         /** @var SearchCriteriaBuilder $searchCriteriaBuilder */
         $searchCriteriaBuilder = $this->objectManager->get(SearchCriteriaBuilder::class);
-        $searchCriteria = $searchCriteriaBuilder->addFilters($filters)
+        $searchCriteria = $searchCriteriaBuilder->addFilter(OrderInterface::INCREMENT_ID, $orderId)
             ->create();
 
         $orderRepository = $this->objectManager->get(OrderRepositoryInterface::class);

dev/tests/integration/testsuite/Magento/Authorizenet/_files/transaction_details.xml

@@ -1,4 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
 <getTransactionDetailsResponse>
     <messages>
         <resultCode>Ok</resultCode>