MAGETWO-89315: Magento application compatible with cloud

Author: Bohdan Korablov

lib/internal/Magento/Framework/Setup/FilePermissions.php

@@ -9,6 +9,8 @@
 use Magento\Framework\Backup\Filesystem\Iterator\Filter;
 use Magento\Framework\Filesystem;
 use Magento\Framework\Filesystem\Filter\ExcludeFilter;
+use Magento\Framework\App\State;
+use Magento\Framework\App\ObjectManager;
 
 /**
  * Checks permissions to files and folders.
@@ -25,6 +27,11 @@ class FilePermissions
      */
     protected $directoryList;
 
+    /**
+     * @var State
+     */
+    private $state;
+
     /**
      * List of required writable directories for installation
      *
@@ -66,10 +73,12 @@ class FilePermissions
      */
     public function __construct(
         Filesystem $filesystem,
-        DirectoryList $directoryList
+        DirectoryList $directoryList,
+        State $state = null
     ) {
         $this->filesystem = $filesystem;
         $this->directoryList = $directoryList;
+        $this->state = $state ?:ObjectManager::getInstance()->get(State::class);
     }
 
     /**
@@ -85,8 +94,10 @@ public function getInstallationWritableDirectories()
                 DirectoryList::VAR_DIR,
                 DirectoryList::MEDIA,
                 DirectoryList::STATIC_VIEW,
-                DirectoryList::GENERATED,
             ];
+            if ($this->state->getMode() !== State::MODE_PRODUCTION) {
+                $data[] = DirectoryList::GENERATED;
+            }
             foreach ($data as $code) {
                 $this->installationWritableDirectories[$code] = $this->directoryList->getPath($code);
             }

lib/internal/Magento/Framework/Setup/Test/Unit/FilePermissionsTest.php

@@ -7,6 +7,8 @@
 
 use \Magento\Framework\Setup\FilePermissions;
 use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\App\State;
+use function Magento\NonComposerComponentRegistration\main;
 
 class FilePermissionsTest extends \PHPUnit\Framework\TestCase
 {
@@ -25,6 +27,11 @@ class FilePermissionsTest extends \PHPUnit\Framework\TestCase
      */
     private $directoryListMock;
 
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject|State
+     */
+    private $stateMock;
+
     /**
      * @var FilePermissions
      */
@@ -34,6 +41,7 @@ public function setUp()
     {
         $this->directoryWriteMock = $this->createMock(\Magento\Framework\Filesystem\Directory\Write::class);
         $this->filesystemMock = $this->createMock(\Magento\Framework\Filesystem::class);
+        $this->stateMock = $this->createMock(State::class);
 
         $this->filesystemMock
             ->expects($this->any())
@@ -43,13 +51,21 @@ public function setUp()
 
         $this->filePermissions = new FilePermissions(
             $this->filesystemMock,
-            $this->directoryListMock
+            $this->directoryListMock,
+            $this->stateMock
         );
     }
 
-    public function testGetInstallationWritableDirectories()
+    /**
+     * @param string $mageMode
+     * @dataProvider modeDataProvider
+     */
+    public function testGetInstallationWritableDirectories($mageMode)
     {
         $this->setUpDirectoryListInstallation();
+        $this->stateMock->expects($this->once())
+            ->method('getMode')
+            ->willReturn($mageMode);
 
         $expected = [
             BP . '/app/etc',
@@ -62,6 +78,23 @@ public function testGetInstallationWritableDirectories()
         $this->assertEquals($expected, $this->filePermissions->getInstallationWritableDirectories());
     }
 
+    public function testGetInstallationWritableDirectoriesInProduction()
+    {
+        $this->setUpDirectoryListInstallationInProduction();
+        $this->stateMock->expects($this->once())
+            ->method('getMode')
+            ->willReturn(State::MODE_PRODUCTION);
+
+        $expected = [
+            BP . '/app/etc',
+            BP . '/var',
+            BP . '/pub/media',
+            BP . '/pub/static'
+        ];
+
+        $this->assertEquals($expected, $this->filePermissions->getInstallationWritableDirectories());
+    }
+
     public function testGetApplicationNonWritableDirectories()
     {
         $this->directoryListMock
@@ -134,13 +167,18 @@ public function getApplicationCurrentNonWritableDirectoriesDataProvider()
     }
 
     /**
+     * @param string $mageMode
+     * @dataProvider modeDataProvider
      * @covers \Magento\Framework\Setup\FilePermissions::getMissingWritableDirectoriesForInstallation
      * @covers \Magento\Framework\Setup\FilePermissions::getMissingWritablePathsForInstallation
      */
-    public function testGetMissingWritableDirectoriesAndPathsForInstallation()
+    public function testGetMissingWritableDirectoriesAndPathsForInstallation($mageMode)
     {
         $this->setUpDirectoryListInstallation();
         $this->setUpDirectoryWriteInstallation();
+        $this->stateMock->expects($this->once())
+            ->method('getMode')
+            ->willReturn($mageMode);
 
         $expected = [
             BP . '/var',
@@ -160,6 +198,31 @@ public function testGetMissingWritableDirectoriesAndPathsForInstallation()
         );
     }
 
+    public function testGetMissingWritableDirectoriesAndPathsForInstallationInProduction()
+    {
+        $this->setUpDirectoryListInstallationInProduction();
+        $this->setUpDirectoryWriteInstallation();
+        $this->stateMock->expects($this->once())
+            ->method('getMode')
+            ->willReturn(State::MODE_PRODUCTION);
+
+        $expected = [
+            BP . '/var',
+            BP . '/pub/media',
+            BP . '/pub/static'
+        ];
+
+        $this->assertEquals(
+            $expected,
+            array_values($this->filePermissions->getMissingWritableDirectoriesForInstallation())
+        );
+
+        $this->assertEquals(
+            $expected,
+            array_values($this->filePermissions->getMissingWritablePathsForInstallation())
+        );
+    }
+
     public function testGetMissingWritableDirectoriesForDbUpgrade()
     {
         $directoryMethods = ['isExist', 'isDirectory', 'isReadable', 'isWritable'];
@@ -240,6 +303,30 @@ public function setUpDirectoryListInstallation()
             ->will($this->returnValue(BP . '/generated'));
     }
 
+    public function setUpDirectoryListInstallationInProduction()
+    {
+        $this->directoryListMock
+            ->expects($this->at(0))
+            ->method('getPath')
+            ->with(DirectoryList::CONFIG)
+            ->will($this->returnValue(BP . '/app/etc'));
+        $this->directoryListMock
+            ->expects($this->at(1))
+            ->method('getPath')
+            ->with(DirectoryList::VAR_DIR)
+            ->will($this->returnValue(BP . '/var'));
+        $this->directoryListMock
+            ->expects($this->at(2))
+            ->method('getPath')
+            ->with(DirectoryList::MEDIA)
+            ->will($this->returnValue(BP . '/pub/media'));
+        $this->directoryListMock
+            ->expects($this->at(3))
+            ->method('getPath')
+            ->with(DirectoryList::STATIC_VIEW)
+            ->will($this->returnValue(BP . '/pub/static'));
+    }
+
     public function setUpDirectoryWriteInstallation()
     {
         // CONFIG
@@ -294,4 +381,15 @@ public function setUpDirectoryWriteInstallation()
             ->method('isWritable')
             ->will($this->returnValue(false));
     }
+
+    /**
+     * @return array
+     */
+    public function modeDataProvider()
+    {
+        return [
+            [State::MODE_DEFAULT],
+            [State::MODE_DEVELOPER],
+        ];
+    }
 }