Skip to content

Commit 59f9a19

Browse files
ENGCOM-3221: Add Value to Magento Framework's public API #17296
- Merge Pull Request #17296 from navarr/magento2:add-value-to-public-api - Merged commits: 1. 9f47f05 2. e24d8b9 3. 863f772
2 parents f710f9b + 863f772 commit 59f9a19

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

lib/internal/Magento/Framework/App/Config/Value.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@
88
/**
99
* Config data model
1010
*
11+
* This model is temporarily marked as API since {@see \Magento\Framework\App\Config\ValueInterface} doesn't fit
12+
* developers' needs of extensibility. In 2.4 we are going to introduce a new iterface which should cover all needs
13+
* and deprecate the mentioned together with the model
14+
*
1115
* @method string getScope()
1216
* @method \Magento\Framework\App\Config\ValueInterface setScope(string $value)
1317
* @method int getScopeId()
@@ -17,6 +21,8 @@
1721
* @method string getValue()
1822
* @method \Magento\Framework\App\Config\ValueInterface setValue(string $value)
1923
*
24+
* @api
25+
*
2026
* @SuppressWarnings(PHPMD.NumberOfChildren)
2127
*/
2228
class Value extends \Magento\Framework\Model\AbstractModel implements \Magento\Framework\App\Config\ValueInterface

lib/internal/Magento/Framework/App/Config/ValueInterface.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99

1010
/**
1111
* Interface \Magento\Framework\App\Config\ValueInterface
12-
*
12+
*
13+
* This interface cannot be marked as API since doesn't fit developers' needs of extensibility. In 2.4 we are going
14+
* to introduce a new iterface which should cover all needs and deprecate the this one with the model
15+
* {@see \Magento\Framework\App\Config\Value}
1316
*/
1417
interface ValueInterface
1518
{

0 commit comments

Comments
 (0)