Move catalog search indexer outside stores loop

ihor-sviziev · web-flow · commit 59ee3e6b4064 · 2021-07-29T18:01:30.000+03:00
Apply suggestions from code review
diff --git a/app/code/Magento/Elasticsearch/Model/Indexer/Fulltext/Plugin/Category/Product/Action/Rows.php b/app/code/Magento/Elasticsearch/Model/Indexer/Fulltext/Plugin/Category/Product/Action/Rows.php
@@ -81,9 +81,10 @@ public function afterExecute(
 
             foreach ($this->storeManager->getStores() as $store) {
                 $indexTable = $this->getIndexTable((int) $store->getId(), $useTempTable);
-                $productIds = array_merge($productIds, $this->getProductIdsFromIndex($indexTable, $entityIds));
+                $productIds[] = $this->getProductIdsFromIndex($indexTable, $entityIds);
             }
 
+            $productIds = array_merge([], ...$productIds);
             if (!empty($productIds)) {
                 $indexer->reindexList(array_unique($productIds));
             }

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,10 @@ public function afterExecute(`
`81`	`81`
`82`	`82`	`foreach ($this->storeManager->getStores() as $store) {`
`83`	`83`	`$indexTable = $this->getIndexTable((int) $store->getId(), $useTempTable);`
`84`		`- $productIds = array_merge($productIds, $this->getProductIdsFromIndex($indexTable, $entityIds));`
	`84`	`+ $productIds[] = $this->getProductIdsFromIndex($indexTable, $entityIds);`
`85`	`85`	`}`
`86`	`86`
	`87`	`+ $productIds = array_merge([], ...$productIds);`
`87`	`88`	`if (!empty($productIds)) {`
`88`	`89`	`$indexer->reindexList(array_unique($productIds));`
`89`	`90`	`}`