Skip to content

Commit 5969ba7

Browse files
committed
Fix unit test
1 parent 34c1375 commit 5969ba7

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
*/
1010
namespace Magento\Cron\Observer;
1111

12-
use Laminas\Http\PhpEnvironment\Request;
12+
use Laminas\Http\PhpEnvironment\Request as Environment;
1313
use Magento\Cron\Model\ResourceModel\Schedule\Collection as ScheduleCollection;
1414
use Magento\Cron\Model\Schedule;
1515
use Magento\Framework\App\State;
@@ -130,9 +130,9 @@ class ProcessCronQueueObserver implements ObserverInterface
130130
protected $dateTime;
131131

132132
/**
133-
* @var Request
133+
* @var Environment
134134
*/
135-
protected Request $environment;
135+
protected Environment $environment;
136136

137137
/**
138138
* @var string
@@ -195,7 +195,7 @@ class ProcessCronQueueObserver implements ObserverInterface
195195
* @param \Magento\Framework\Lock\LockManagerInterface $lockManager
196196
* @param \Magento\Framework\Event\ManagerInterface $eventManager
197197
* @param DeadlockRetrierInterface $retrier
198-
* @param Request $environment
198+
* @param Environment $environment
199199
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
200200
*/
201201
public function __construct(
@@ -214,7 +214,7 @@ public function __construct(
214214
\Magento\Framework\Lock\LockManagerInterface $lockManager,
215215
\Magento\Framework\Event\ManagerInterface $eventManager,
216216
DeadlockRetrierInterface $retrier,
217-
Request $environment
217+
Environment $environment
218218
) {
219219
$this->_objectManager = $objectManager;
220220
$this->_scheduleFactory = $scheduleFactory;

app/code/Magento/Cron/Test/Unit/Observer/ProcessCronQueueObserverTest.php

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
namespace Magento\Cron\Test\Unit\Observer;
99

1010
use Exception;
11+
use Laminas\Http\PhpEnvironment\Request as Environment;
1112
use Magento\Cron\Model\Config;
1213
use Magento\Cron\Model\DeadlockRetrierInterface;
1314
use Magento\Cron\Model\ResourceModel\Schedule as ScheduleResourceModel;
@@ -20,8 +21,8 @@
2021
use Magento\Framework\App\Config\ScopeConfigInterface;
2122
use Magento\Framework\App\Console\Request as ConsoleRequest;
2223
use Magento\Framework\App\ObjectManager;
23-
use Magento\Framework\App\State;
2424
use Magento\Framework\App\State as AppState;
25+
use Magento\Framework\App\State;
2526
use Magento\Framework\DataObject;
2627
use Magento\Framework\DB\Adapter\AdapterInterface;
2728
use Magento\Framework\Event\ManagerInterface;
@@ -219,6 +220,14 @@ protected function setUp(): void
219220

220221
$this->retrierMock = $this->getMockForAbstractClass(DeadlockRetrierInterface::class);
221222

223+
$environmentMock = $this->getMockBuilder(Environment::class)
224+
->disableOriginalConstructor()
225+
->getMock();
226+
$environmentMock->expects($this->any())
227+
->method('getServer')
228+
->with('argv')
229+
->willReturn($_SERVER['argv']);
230+
222231
$this->cronQueueObserver = new ProcessCronQueueObserver(
223232
$this->objectManagerMock,
224233
$this->scheduleFactoryMock,
@@ -234,7 +243,8 @@ protected function setUp(): void
234243
$this->statFactory,
235244
$this->lockManagerMock,
236245
$this->eventManager,
237-
$this->retrierMock
246+
$this->retrierMock,
247+
$environmentMock
238248
);
239249
}
240250

0 commit comments

Comments
 (0)