Skip to content

Commit 592d05c

Browse files
Indrani SonawaneIndrani Sonawane
authored andcommitted
Merge remote-tracking branch '33414/fix-tracking-typo-currier' into augcommpr
2 parents 62ddef6 + 6917863 commit 592d05c

File tree

1 file changed

+11
-10
lines changed
  • app/code/Magento/Shipping/view/adminhtml/templates/order

1 file changed

+11
-10
lines changed

app/code/Magento/Shipping/view/adminhtml/templates/order/tracking.phtml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
/**
99
* @var $block Magento\Shipping\Block\Adminhtml\Order\Tracking
1010
* @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer
11+
* @var $escaper \Magento\Framework\Escaper
1112
*/
1213
?>
1314
<?php $scriptString = <<<script
@@ -29,25 +30,25 @@ require(['prototype'], function(){
2930
$('trackingC' + this.index).disabled = false;
3031
$('trackingT' + this.index).disabled = false;
3132
$('trackingN' + this.index).disabled = false;
32-
this.bindCurrierOnchange();
33+
this.bindCarrierOnchange();
3334
},
3435
deleteRow : function(event) {
3536
var row = Event.findElement(event, 'tr');
3637
if (row) {
3738
row.parentNode.removeChild(row)
3839
}
3940
},
40-
bindCurrierOnchange : function() {
41+
bindCarrierOnchange : function() {
4142
var elems = $('tracking_numbers_table').select('.select');
4243
elems.each(function (elem) {
4344
if (!elem.onchangeBound) {
4445
elem.onchangeBound = true;
4546
elem.valueInput = $(elem.parentNode.parentNode).select('.number-title')[0];
46-
elem.observe('change', this.currierOnchange);
47+
elem.observe('change', this.carrierOnchange);
4748
}
4849
}.bind(this));
4950
},
50-
currierOnchange : function(event) {
51+
carrierOnchange : function(event) {
5152
var elem = Event.element(event);
5253
var option = elem.options[elem.selectedIndex];
5354
if (option.value && option.value != 'custom') {
@@ -76,7 +77,7 @@ script;
7677
class="select admin__control-select carrier"
7778
disabled="disabled">
7879
<?php foreach ($block->getCarriers() as $_code => $_name): ?>
79-
<option value="<?= $block->escapeHtmlAttr($_code) ?>"><?= $block->escapeHtml($_name) ?></option>
80+
<option value="<?= $escaper->escapeHtmlAttr($_code) ?>"><?= $escaper->escapeHtml($_name) ?></option>
8081
<?php endforeach; ?>
8182
</select>
8283
</td>
@@ -101,7 +102,7 @@ script;
101102
type="button"
102103
class="action-default action-delete"
103104
onclick="trackingControl.deleteRow(event);return false">
104-
<span><?= $block->escapeHtml(__('Delete')) ?></span>
105+
<span><?= $escaper->escapeHtml(__('Delete')) ?></span>
105106
</button>
106107
</td>
107108
</tr>
@@ -111,10 +112,10 @@ script;
111112
<table class="data-table admin__control-table" id="tracking_numbers_table">
112113
<thead>
113114
<tr class="headings">
114-
<th class="col-carrier"><?= $block->escapeHtml(__('Carrier')) ?></th>
115-
<th class="col-title"><?= $block->escapeHtml(__('Title')) ?></th>
116-
<th class="col-number"><?= $block->escapeHtml(__('Number')) ?></th>
117-
<th class="col-delete"><?= $block->escapeHtml(__('Action')) ?></th>
115+
<th class="col-carrier"><?= $escaper->escapeHtml(__('Carrier')) ?></th>
116+
<th class="col-title"><?= $escaper->escapeHtml(__('Title')) ?></th>
117+
<th class="col-number"><?= $escaper->escapeHtml(__('Number')) ?></th>
118+
<th class="col-delete"><?= $escaper->escapeHtml(__('Action')) ?></th>
118119
</tr>
119120
</thead>
120121
<tfoot>

0 commit comments

Comments
 (0)