Skip to content

Commit 58d6137

Browse files
author
Bohdan Korablov
committed
MAGETWO-52386: JS validation is absent for "Configurations" and "Images And Videos" panels
1 parent 1a3fd9b commit 58d6137

File tree

2 files changed

+2
-8
lines changed
  • app/code/Magento

2 files changed

+2
-8
lines changed

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/helper/gallery.phtml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,11 @@
99
/** @var $block \Magento\Catalog\Block\Adminhtml\Product\Helper\Form\Gallery\Content */
1010
$elementName = $block->getElement()->getName() . '[images]';
1111
$formName = $block->getFormName();
12-
$parentComponent = $block->getData('config/parentComponent')
13-
? 'data-parent-component="' . $block->getData('config/parentComponent') . '"'
14-
: '';
1512
?>
1613
<div id="<?php echo $block->getHtmlId() ?>"
1714
class="gallery"
1815
data-mage-init='{"productGallery":{"template":"#<?php echo $block->getHtmlId() ?>-template"}}'
19-
<?php echo $parentComponent ?>
16+
data-parent-component="<?php echo $block->escapeHtml($block->getData('config/parentComponent')) ?>"
2017
data-images="<?php echo $block->escapeHtml($block->getImagesJson()) ?>"
2118
data-types="<?php echo $block->escapeHtml(
2219
$this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($block->getImageTypes())

app/code/Magento/ProductVideo/view/adminhtml/templates/helper/gallery.phtml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
/** @var $block \Magento\Catalog\Block\Adminhtml\Product\Helper\Form\Gallery\Content */
1010
$elementName = $block->getElement()->getName() . '[images]';
1111
$formName = $block->getFormName();
12-
$parentComponent = $block->getData('config/parentComponent')
13-
? 'data-parent-component="' . $block->getData('config/parentComponent') . '"'
14-
: '';
1512
?>
1613

1714
<div class="row">
@@ -36,7 +33,7 @@ $elementToggleCode = $element->getToggleCode() ? $element->getToggleCode() : 'to
3633
<div id="<?php echo $block->getHtmlId() ?>"
3734
class="gallery"
3835
data-mage-init='{"openVideoModal":{}}'
39-
<?php echo $parentComponent ?>
36+
data-parent-component="<?php echo $block->escapeHtml($block->getData('config/parentComponent')) ?>"
4037
data-images="<?php echo $block->escapeHtml($block->getImagesJson()) ?>"
4138
data-types="<?php echo $block->escapeHtml(
4239
$this->helper('Magento\Framework\Json\Helper\Data')->jsonEncode($block->getImageTypes())

0 commit comments

Comments
 (0)