Skip to content

Commit 5898776

Browse files
committed
Add assert class, fix mftf test
1 parent c8b80d0 commit 5898776

File tree

3 files changed

+30
-8
lines changed

3 files changed

+30
-8
lines changed
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
9+
<actionGroup name="AdminAssertClassElementRelativeIdActionGroup">
10+
<arguments>
11+
<argument name="elementId" type="string" defaultValue="{{AdminMenuSection.marketing}}"/>
12+
<argument name="expectClass" type="string" defaultValue="{{AdminMenuUserContentPendingReviews.activeClass}}" />
13+
</arguments>
14+
15+
<grabAttributeFrom selector="{{elementId}}" userInput="class" stepKey="grabClass"/>
16+
<assertContains stepKey="assertClass">
17+
<actualResult type="string">{$grabClass}</actualResult>
18+
<expectedResult type="string">{{expectClass}}</expectedResult>
19+
</assertContains>
20+
</actionGroup>
21+
</actionGroups>

app/code/Magento/Review/Test/Mftf/Data/AdminMenuData.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<data key="pageTitle">Pending Reviews</data>
1818
<data key="title">Pending Reviews</data>
1919
<data key="dataUiId">magento-review-catalog-reviews-ratings-pending</data>
20+
<data key="dataActiveClass">_active</data>
2021
</entity>
2122
<entity name="AdminMenuReportsReviewsByCustomers">
2223
<data key="pageTitle">Customer Reviews Report</data>

app/code/Magento/Review/Test/Mftf/Test/AdminMarketingPendingReviewsNavigateMenuTest.xml renamed to app/code/Magento/Review/Test/Mftf/Test/AdminMarketingPendingReviewsNavigateMenuActiveTest.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,14 @@
66
*/
77
-->
88

9-
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
11-
<test name="AdminMarketingPendingReviewsNavigateMenuTest">
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="AdminMarketingPendingReviewsNavigateMenuActiveTest">
1211
<annotations>
1312
<features value="Pending Reviews"/>
1413
<stories value="Menu Navigation"/>
15-
<title value="Admin marketing pending reviews navigate menu test"/>
16-
<description value="Admin should be able to navigate to Marketing > Pending Reviews"/>
17-
<severity value="CRITICAL"/>
18-
<testCaseId value="MC-14200"/>
14+
<title value="Admin marketing pending reviews navigate menu"/>
15+
<description value="Admin able see navigate head menu Marketing is active, when open page Marketing > Pending Reviews"/>
1916
<group value="menu"/>
20-
<group value="mtf_migrated"/>
2117
</annotations>
2218
<before>
2319
<actionGroup ref="LoginAsAdmin" stepKey="LoginAsAdmin"/>
@@ -32,5 +28,9 @@
3228
<actionGroup ref="AdminAssertPageTitleActionGroup" stepKey="seePageTitle">
3329
<argument name="title" value="{{AdminMenuUserContentPendingReviews.pageTitle}}"/>
3430
</actionGroup>
31+
<actionGroup ref="AdminAssertClassElementRelativeIdActionGroup" stepKey="assertClass">
32+
<argument name="elementId" value="{{AdminMenuSection.marketing}}"/>
33+
<argument name="expectClass" value="{{AdminMenuUserContentPendingReviews.dataActiveClass}}"/>
34+
</actionGroup>
3535
</test>
3636
</tests>

0 commit comments

Comments
 (0)