Skip to content

Commit 57a4765

Browse files
jilu1tomreece
authored andcommitted
MQE-377: Addressed review feedback regarding page url reference.
1 parent 4d4f307 commit 57a4765

File tree

10 files changed

+17
-19
lines changed

10 files changed

+17
-19
lines changed

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Backend/Cest/AdminLoginCest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<env value="phantomjs"/>
2727
<env value="headless"/>
2828
</annotations>
29-
<amOnPage url="{{AdminLoginPage}}" mergeKey="amOnAdminLoginPage"/>
29+
<amOnPage url="{{AdminLoginPage.url}}" mergeKey="amOnAdminLoginPage"/>
3030
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" mergeKey="fillUsername"/>
3131
<fillField selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}" mergeKey="fillPassword"/>
3232
<click selector="{{AdminLoginFormSection.signIn}}" mergeKey="clickOnSignIn"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Cest/AdminCreateCategoryCest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@
2626
<env value="chrome"/>
2727
<env value="headless"/>
2828
</annotations>
29-
<amOnPage url="{{AdminLoginPage}}" mergeKey="amOnAdminLoginPage"/>
29+
<amOnPage url="{{AdminLoginPage.url}}" mergeKey="amOnAdminLoginPage"/>
3030
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" mergeKey="fillUsername"/>
3131
<fillField selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}" mergeKey="fillPassword"/>
3232
<click selector="{{AdminLoginFormSection.signIn}}" mergeKey="clickOnSignIn"/>
33-
<amOnPage url="{{AdminCategoryPage}}" mergeKey="navigateToCategoryPage"/>
33+
<amOnPage url="{{AdminCategoryPage.url}}" mergeKey="navigateToCategoryPage"/>
3434
<waitForPageLoad mergeKey="waitForPageLoad1"/>
3535
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" mergeKey="clickOnAddSubCategory"/>
3636
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" mergeKey="enterCategoryName"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Cest/AdminCreateConfigurableProductCest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" mergeKey="clickOnSaveCategory"/>
4141
<seeElement selector="{{AdminCategoryMessagesSection.SuccessMessage}}" mergeKey="assertSuccessMessage"/>
4242

43-
<amOnPage url="{{AdminProductIndexPage.urlPath}}" mergeKey="amOnProductGridPage"/>
43+
<amOnPage url="{{AdminProductIndexPage.url}}" mergeKey="amOnProductGridPage"/>
4444
<waitForPageLoad mergeKey="waitForPageLoad2"/>
4545
<click selector="{{AdminProductGridActionSection.addProductToggle}}" mergeKey="clickOnAddProductToggle"/>
4646
<click selector="{{AdminProductGridActionSection.addConfigurableProduct}}" mergeKey="clickOnAddConfigurableProduct"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Checkout/Cest/StorefrontCustomerCheckoutCest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
<grabTextFrom mergeKey="s53" selector="{{CheckoutSuccessMainSection.orderNumber22}}" returnVariable="orderNumber" />
6464
<see mergeKey="s55" selector="{{CheckoutSuccessMainSection.success}}" userInput="Your order number is:" />
6565

66-
<amOnPage mergeKey="s59" url="{{AdminLoginPage}}" />
66+
<amOnPage mergeKey="s59" url="{{AdminLoginPage.url}}" />
6767
<fillField mergeKey="s61" selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" />
6868
<fillField mergeKey="s63" selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}" />
6969
<click mergeKey="s65" selector="{{AdminLoginFormSection.signIn}}" />

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Checkout/Cest/StorefrontGuestCheckoutCest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@
6262
<grabTextFrom selector="{{CheckoutSuccessMainSection.orderNumber}}" returnVariable="orderNumber" mergeKey="grabOrderNumber"/>
6363
<see selector="{{CheckoutSuccessMainSection.success}}" userInput="Your order # is:" mergeKey="seeOrderNumber"/>
6464
<see selector="{{CheckoutSuccessMainSection.success}}" userInput="We'll email you an order confirmation with details and tracking info." mergeKey="seeEmailYou"/>
65-
<amOnPage url="{{AdminLoginPage}}" mergeKey="navigateToAdmin"/>
65+
<amOnPage url="{{AdminLoginPage.url}}" mergeKey="navigateToAdmin"/>
6666
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" mergeKey="fillUsername"/>
6767
<fillField selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}" mergeKey="fillPassword"/>
6868
<click selector="{{AdminLoginFormSection.signIn}}" mergeKey="clickLogin"/>
69-
<amOnPage url="{{OrdersPage}}" mergeKey="onOrdersPage"/>
69+
<amOnPage url="{{OrdersPage.url}}" mergeKey="onOrdersPage"/>
7070
<waitForElementNotVisible selector="{{OrdersGridSection.spinner}}" time="30" mergeKey="waitForOrdersPage"/>
7171
<fillField selector="{{OrdersGridSection.search}}" variable="orderNumber" mergeKey="fillOrderNum"/>
7272
<click selector="{{OrdersGridSection.submitSearch}}" mergeKey="submitSearchOrderNum"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Cest/AdminCreateCmsPageCest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
<env value="firefox"/>
2828
<env value="headless"/>
2929
</annotations>
30-
<amOnPage url="{{AdminLoginPage}}" mergeKey="navigateToAdmin"/>
30+
<amOnPage url="{{AdminLoginPage.url}}" mergeKey="navigateToAdmin"/>
3131
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" mergeKey="fillUsername"/>
3232
<fillField selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}" mergeKey="fillPassword"/>
3333
<click selector="{{AdminLoginFormSection.signIn}}" mergeKey="clickLogin"/>
34-
<amOnPage url="{{CmsPagesPage}}" mergeKey="amOnPagePagesGrid"/>
34+
<amOnPage url="{{CmsPagesPage.url}}" mergeKey="amOnPagePagesGrid"/>
3535
<waitForPageLoad mergeKey="waitForPageLoad1"/>
3636
<click selector="{{CmsPagesPageActionsSection.addNewPage}}" mergeKey="clickAddNewPage"/>
3737
<fillField selector="{{CmsNewPagePageBasicFieldsSection.pageTitle}}" userInput="{{_defaultCmsPage.title}}" mergeKey="fillFieldTitle"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Customer/Cest/StorefrontExistingCustomerLoginCest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<env value="phantomjs"/>
3232
<env value="headless"/>
3333
</annotations>
34-
<amOnPage mergeKey="amOnSignInPage" url="{{StorefrontCustomerSignInPage}}"/>
34+
<amOnPage mergeKey="amOnSignInPage" url="{{StorefrontCustomerSignInPage.url}}"/>
3535
<fillField mergeKey="fillEmail" userInput="$$customer.email$$" selector="{{StorefrontCustomerSignInFormSection.emailField}}"/>
3636
<fillField mergeKey="fillPassword" userInput="$$customer.password$$" selector="{{StorefrontCustomerSignInFormSection.passwordField}}"/>
3737
<click mergeKey="clickSignInAccountButton" selector="{{StorefrontCustomerSignInFormSection.signInAccountButton}}"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Sales/Cest/AdminCreateInvoiceCest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@
5757
<grabTextFrom selector="{{CheckoutSuccessMainSection.orderNumber}}" returnVariable="orderNumber" mergeKey="grabOrderNumber"/>
5858
<!-- end todo -->
5959

60-
<amOnPage url="{{AdminLoginPage}}" mergeKey="goToAdmin"/>
60+
<amOnPage url="{{AdminLoginPage.url}}" mergeKey="goToAdmin"/>
6161
<waitForPageLoad mergeKey="waitForPageLoad1"/>
6262
<fillField selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}" mergeKey="fillUsername"/>
6363
<fillField selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}" mergeKey="fillPassword"/>
6464
<click selector="{{AdminLoginFormSection.signIn}}" mergeKey="clickLogin"/>
6565

66-
<amOnPage url="{{OrdersPage}}" mergeKey="onOrdersPage"/>
66+
<amOnPage url="{{OrdersPage.url}}" mergeKey="onOrdersPage"/>
6767
<waitForElementNotVisible selector="{{OrdersGridSection.spinner}}" time="10" mergeKey="waitSpinner1"/>
6868
<fillField selector="{{OrdersGridSection.search}}" variable="orderNumber" mergeKey="searchOrderNum"/>
6969
<click selector="{{OrdersGridSection.submitSearch}}" mergeKey="submitSearch"/>
@@ -79,7 +79,7 @@
7979
<see selector="{{OrderDetailsInvoicesSection.content}}" userInput="John Doe" mergeKey="seeInvoice2"/>
8080
<click selector="{{OrderDetailsOrderViewSection.information}}" mergeKey="clickInformation"/>
8181
<see selector="{{OrderDetailsInformationSection.orderStatus}}" userInput="Processing" mergeKey="seeOrderStatus"/>
82-
<amOnPage url="{{InvoicesPage}}" mergeKey="goToInvoices"/>
82+
<amOnPage url="{{InvoicesPage.url}}" mergeKey="goToInvoices"/>
8383
<waitForElementNotVisible selector="{{InvoicesGridSection.spinner}}" time="10" mergeKey="waitSpinner4"/>
8484
<click selector="{{InvoicesGridSection.filter}}" mergeKey="clickFilters"/>
8585
<fillField selector="{{InvoicesFiltersSection.orderNum}}" variable="orderNumber" mergeKey="searchOrderNum2"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Store/Cest/AdminCreateStoreGroupCest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,12 @@
2424
<annotations>
2525
<title value="Create a store group in admin"/>
2626
<description value="Create a store group in admin"/>
27-
<severity value="CRITICAL"/>
28-
<testCaseId value="MAGETWO-?????"/>
2927
</annotations>
30-
<amOnPage mergeKey="s1" url="{{AdminLoginPage}}"/>
28+
<amOnPage mergeKey="s1" url="{{AdminLoginPage.url}}"/>
3129
<fillField mergeKey="s3" selector="{{AdminLoginFormSection.username}}" userInput="{{_ENV.MAGENTO_ADMIN_USERNAME}}"/>
3230
<fillField mergeKey="s5" selector="{{AdminLoginFormSection.password}}" userInput="{{_ENV.MAGENTO_ADMIN_PASSWORD}}"/>
3331
<click mergeKey="s7" selector="{{AdminLoginFormSection.signIn}}"/>
34-
<amOnPage mergeKey="s9" url="{{AdminSystemStorePage}}"/>
32+
<amOnPage mergeKey="s9" url="{{AdminSystemStorePage.url}}"/>
3533

3634
<click mergeKey="s11" selector="{{AdminStoresGridSection.resetButton}}"/>
3735
<waitForPageLoad mergeKey="s15" time="10"/>

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Wishlist/Cest/StorefrontCustomerCreateWishlistCest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<title value="Persist a wishlist for a customer"/>
3232
<description value="Persist a wishlist for a customer"/>
3333
</annotations>
34-
<amOnPage mergeKey="amOnSignInPage" url="{{StorefrontCustomerSignInPage}}"/>
34+
<amOnPage mergeKey="amOnSignInPage" url="{{StorefrontCustomerSignInPage.url}}"/>
3535
<fillField mergeKey="fillEmail" userInput="$$customer.email$$" selector="{{StorefrontCustomerSignInFormSection.emailField}}"/>
3636
<fillField mergeKey="fillPassword" userInput="$$customer.password$$" selector="{{StorefrontCustomerSignInFormSection.passwordField}}"/>
3737
<waitForElementVisible mergeKey="waitForButton" selector="{{StorefrontCustomerSignInFormSection.signInAccountButton}}"/>
@@ -40,7 +40,7 @@
4040
<see mergeKey="seeLastName" userInput="$$customer.lastname$$" selector="{{StorefrontCustomerDashboardAccountInformationSection.ContactInformation}}" />
4141
<see mergeKey="seeEmail" userInput="$$customer.email$$" selector="{{StorefrontCustomerDashboardAccountInformationSection.ContactInformation}}" />
4242
<waitForPageLoad mergeKey="15"/>
43-
<amOnPage mergeKey="amOnWishlist" url="{{StorefrontCustomerWishlistPage}}"/>
43+
<amOnPage mergeKey="amOnWishlist" url="{{StorefrontCustomerWishlistPage.url}}"/>
4444
<see mergeKey="seeInField" userInput="$$product.name$$" selector="{{StorefrontCustomerWishlistSection.productItemName}}"/>
4545
</test>
4646
</cest>

0 commit comments

Comments
 (0)