Skip to content

Commit 5790225

Browse files
Fix SKU limit in import new products for 2.3 with backward compatible allow 64 characters
1 parent b65b49f commit 5790225

File tree

1 file changed

+18
-2
lines changed
  • app/code/Magento/CatalogImportExport/Model/Import/Product

1 file changed

+18
-2
lines changed

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,12 @@ public function isRequiredAttributeValid($attrCode, array $attributeParams, arra
153153
$doCheck = true;
154154
}
155155

156-
return $doCheck ? isset($rowData[$attrCode]) && strlen(trim($rowData[$attrCode])) : true;
156+
if ($doCheck === true) {
157+
return isset($rowData[$attrCode])
158+
&& strlen(trim($rowData[$attrCode]))
159+
&& trim($rowData[$attrCode]) !== $this->context->getEmptyAttributeValueConstant();
160+
}
161+
return true;
157162
}
158163

159164
/**
@@ -191,6 +196,11 @@ public function isAttributeValid($attrCode, array $attrParams, array $rowData)
191196
if (!strlen(trim($rowData[$attrCode]))) {
192197
return true;
193198
}
199+
200+
if ($rowData[$attrCode] === $this->context->getEmptyAttributeValueConstant() && !$attrParams['is_required']) {
201+
return true;
202+
}
203+
194204
switch ($attrParams['type']) {
195205
case 'varchar':
196206
case 'text':
@@ -212,6 +222,12 @@ public function isAttributeValid($attrCode, array $attrParams, array $rowData)
212222
break;
213223
}
214224
}
225+
226+
$uniqueValues = array_unique($values);
227+
if (count($uniqueValues) != count($values)) {
228+
$valid = false;
229+
$this->_addMessages([RowValidatorInterface::ERROR_DUPLICATE_MULTISELECT_VALUES]);
230+
}
215231
break;
216232
case 'datetime':
217233
$val = trim($rowData[$attrCode]);
@@ -328,4 +344,4 @@ public function init($context)
328344
$validator->init($context);
329345
}
330346
}
331-
}
347+
}

0 commit comments

Comments
 (0)