ACP2E-72: Search results suggestion give total count of 0 even though there are products

- Added the test coverage and fixed the static test failure.

Author: devarul

app/code/Magento/Search/Plugin/Model/SearchSuggestionResultsCount.php

@@ -17,15 +17,11 @@
 class SearchSuggestionResultsCount
 {
     /**
-     * Query collection factory
-     *
      * @var QueryCollectionFactory
      */
     protected QueryCollectionFactory $_queryCollectionFactory;
 
     /**
-     * Store manager
-     *
      * @var StoreManagerInterface
      */
     protected StoreManagerInterface $_storeManager;
@@ -47,6 +43,9 @@ public function __construct(
     /**
      * Get the search suggestion results count.
      *
+     * @param QueryResult $subject
+     * @param array $result
+     * @return array
      * @throws NoSuchEntityException
      */
     public function afterGetResultsCount(QueryResult $subject, $result)
@@ -57,7 +56,7 @@ public function afterGetResultsCount(QueryResult $subject, $result)
             $subject->getQueryText()
         );
         foreach ($collection as $item) {
-            $result = $item->getNumResults();
+            $result = $item->getData('num_results');
         }
         return $result;
     }

app/code/Magento/Search/Test/Unit/Plugin/Model/SearchSuggestionResultsCountTest.php

@@ -0,0 +1,127 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Search\Test\Unit\Plugin\Model;
+
+use Magento\Search\Model\QueryResult;
+use Magento\Search\Model\ResourceModel\Query\Collection;
+use Magento\Search\Model\ResourceModel\Query\CollectionFactory as QueryCollectionFactory;
+use Magento\Search\Plugin\Model\SearchSuggestionResultsCount;
+use Magento\Store\Api\Data\StoreInterface;
+use Magento\Store\Model\StoreManagerInterface;
+use Magento\Framework\Data\Collection\AbstractDb;
+use PHPUnit\Framework\TestCase;
+
+class SearchSuggestionResultsCountTest extends TestCase
+{
+    /**
+     * @var SearchSuggestionResultsCount
+     */
+    private SearchSuggestionResultsCount $model;
+
+    /**
+     * @var QueryCollectionFactory
+     */
+    private QueryCollectionFactory $queryCollectionFactoryMock;
+
+    /**
+     * @var StoreManagerInterface
+     */
+    private StoreManagerInterface $storeManagerMock;
+
+    /**
+     * @var QueryResult
+     */
+    private QueryResult $queryResultMock;
+
+    /**
+     * @var Collection
+     */
+    private Collection $queryCollectionMock;
+
+    /**
+     * @var StoreInterface
+     */
+    private StoreInterface $storeInterfaceMock;
+
+    /**
+     * @var AbstractDb
+     */
+    private AbstractDb $abstractDbMock;
+
+    /**
+     * @return void
+     */
+    protected function setUp(): void
+    {
+        $this->queryCollectionFactoryMock = $this->getMockBuilder(QueryCollectionFactory::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['create'])
+            ->getMock();
+        $this->storeManagerMock = $this->getMockBuilder(StoreManagerInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->queryResultMock = $this->getMockBuilder(QueryResult::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->queryCollectionMock = $this->getMockBuilder(Collection::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->storeInterfaceMock = $this->getMockBuilder(StoreInterface::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getId'])
+            ->getMockForAbstractClass();
+        $this->abstractDbMock = $this->getMockBuilder(AbstractDb::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getData'])
+            ->getMockForAbstractClass();
+        $this->model = new SearchSuggestionResultsCount(
+            $this->queryCollectionFactoryMock,
+            $this->storeManagerMock
+        );
+    }
+
+    /**
+     * @return void
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    public function testAfterGetResultsCount()
+    {
+        $expectedArr = ['num_results' => 5];
+        $this->queryCollectionFactoryMock->expects($this->once())
+            ->method('create')
+            ->willReturn($this->queryCollectionMock);
+        $this->storeManagerMock->expects($this->once())
+            ->method('getStore')
+            ->willReturn($this->storeInterfaceMock);
+        $this->storeInterfaceMock->expects($this->once())
+            ->method('getId')
+            ->willReturn(1);
+        $this->queryCollectionMock->expects($this->once())
+            ->method('setStoreId')
+            ->willReturnSelf();
+        $this->queryResultMock->expects($this->once())
+            ->method('getQueryText')
+            ->willReturn('mint');
+        $this->queryCollectionMock->expects($this->once())
+            ->method('setQueryFilter')
+            ->willReturn($this->queryCollectionMock);
+        $this->abstractDbMock->expects($this->once())
+            ->method('getData')
+            ->willReturn(['num_results' => 5]);
+        $this->queryCollectionMock->expects($this->once())
+            ->method('getIterator')
+            ->willReturn(new \ArrayIterator([$this->abstractDbMock]));
+        $this->assertEquals(
+            $expectedArr,
+            $this->model->afterGetResultsCount(
+                $this->queryResultMock,
+                0
+            )
+        );
+    }
+}