ACP2E-77: app:config:import stop when retrieve a warning or notice on php code

Author: dhorytskyi

app/code/Magento/Cron/Model/Config/Backend/Sitemap.php

@@ -17,7 +17,7 @@
 class Sitemap extends \Magento\Framework\App\Config\Value
 {
     /**
-     * Cron string path
+     * Cron expression path
      */
     const CRON_STRING_PATH = 'crontab/default/jobs/sitemap_generate/schedule/cron_expr';
 
@@ -71,14 +71,12 @@ public function __construct(
      */
     public function afterSave()
     {
-        $time = $this->getData('groups/generate/fields/time/value');
-        if (null === $time) {
-            $time = explode(',', $this->_config->getValue('sitemap/generate/time'));
-        }
-        $frequency = $this->getData('groups/generate/fields/frequency/value');
-        if (null === $frequency) {
-            $frequency = $this->getValue();
-        }
+        $time = $this->getData('groups/generate/fields/time/value') ?:
+            explode(
+                ',',
+                $this->_config->getValue('sitemap/generate/time', $this->getScope(), $this->getScopeId()) ?: '0,0,0'
+            );
+        $frequency = $this->getValue();
 
         $cronExprArray = [
             (int)$time[1], //Minute
@@ -108,6 +106,7 @@ public function afterSave()
                 self::CRON_MODEL_PATH
             )->save();
         } catch (\Exception $e) {
+            // phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception(__('We can\'t save the cron expression.'));
         }
         return parent::afterSave();

dev/tests/integration/testsuite/Magento/Cron/Model/Config/Backend/SitemapTest.php

@@ -0,0 +1,98 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Cron\Model\Config\Backend;
+
+use Magento\Config\Model\Config as ConfigModel;
+use Magento\Config\Model\PreparedValueFactory;
+use Magento\Cron\Model\Config\Source\Frequency;
+use Magento\Framework\App\Config\ValueFactory;
+use Magento\Framework\ObjectManagerInterface;
+use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @magentoAppArea adminhtml
+ */
+class SitemapTest extends TestCase
+{
+    /**
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp(): void
+    {
+        $this->objectManager = Bootstrap::getObjectManager();
+    }
+
+    /**
+     * @dataProvider frequencyDataProvider
+     * @param string $frequency
+     * @param string $expectedCronExpr
+     */
+    public function testDirectSave(string $frequency, string $expectedCronExpr): void
+    {
+        $preparedValueFactory = $this->objectManager->get(PreparedValueFactory::class);
+        /** @var Sitemap $sitemapValue */
+        $sitemapValue = $preparedValueFactory->create('sitemap/generate/frequency', $frequency, 'default', 0);
+        $sitemapValue->save();
+
+        self::assertEquals($expectedCronExpr, $this->getCronExpression());
+    }
+
+    /**
+     * @dataProvider frequencyDataProvider
+     * @param string $frequency
+     * @param string $expectedCronExpr
+     */
+    public function testSaveFromAdmin(string $frequency, string $expectedCronExpr): void
+    {
+        $config = $this->objectManager->create(ConfigModel::class);
+        $config->setSection('sitemap');
+        $config->setGroups(
+            [
+                'generate' => [
+                    'fields' => [
+                        'time' => ['value' => ['00', '00', '00']],
+                        'frequency' => ['value' => $frequency],
+                    ],
+                ],
+            ]
+        );
+        $config->save();
+
+        self::assertEquals($expectedCronExpr, $this->getCronExpression());
+    }
+
+    /**
+     * @return array
+     */
+    public function frequencyDataProvider(): array
+    {
+        return [
+            'daily' => [Frequency::CRON_DAILY, '0 0 * * *'],
+            'weekly' => [Frequency::CRON_WEEKLY, '0 0 * * 1'],
+            'monthly' => [Frequency::CRON_MONTHLY, '0 0 1 * *'],
+        ];
+    }
+
+    /**
+     * @return string
+     */
+    private function getCronExpression(): string
+    {
+        $valueFactory = $this->objectManager->get(ValueFactory::class);
+        $cronExprValue = $valueFactory->create()
+            ->load(Sitemap::CRON_STRING_PATH, 'path');
+
+        return $cronExprValue->getValue();
+    }
+}