Skip to content

Commit 56ba3b4

Browse files
authored
Setting right shipper street1 in addressline1
In UPS there is limit of 35 chars in address each lines, so currently in model it was setting address line 1 with concatenated street1 and street2 from origin setting which was exceeding chars limit of address lines. So not setting right street1 inside address line 1 data. Previously it was giving error "Missing or invalid ship from address line 1" in response of UPS request because of character limit.
1 parent 4f0763d commit 56ba3b4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/code/Magento/Ups/Model/Carrier.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1380,7 +1380,7 @@ protected function _formShipmentRequest(\Magento\Framework\DataObject $request)
13801380
$shipperPart->addChild('PhoneNumber', $request->getShipperContactPhoneNumber());
13811381

13821382
$addressPart = $shipperPart->addChild('Address');
1383-
$addressPart->addChild('AddressLine1', $request->getShipperAddressStreet());
1383+
$addressPart->addChild('AddressLine1', $request->getShipperAddressStreet1());
13841384
$addressPart->addChild('AddressLine2', $request->getShipperAddressStreet2());
13851385
$addressPart->addChild('City', $request->getShipperAddressCity());
13861386
$addressPart->addChild('CountryCode', $request->getShipperAddressCountryCode());

0 commit comments

Comments
 (0)