MAGETWO-92950: [2.3] Extra XHR POST request made on every page

Author: iivashchenko

app/code/Magento/Catalog/view/frontend/web/js/product/storage/storage-service.js

@@ -47,7 +47,7 @@ define([
                  * @param {*} data
                  */
                 add: function (data) {
-                    if (!utils.compare(data, this.data()).equal) {
+                    if (!_.isEmpty(data) && !utils.compare(data, this.data()).equal) {
                         this.data(_.extend(utils.copy(this.data()), data));
                     }
                 },

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/storage/storage-service.test.js

@@ -12,22 +12,11 @@ define([
 
     var injector = new Squire(),
         mocks = {
-            'Magento_Catalog/js/product/storage/ids-storage': {
-                name: 'IdsStorage',
-                initialize: jasmine.createSpy().and.returnValue({})
-            },
             'Magento_Catalog/js/product/storage/data-storage': {},
             'Magento_Catalog/js/product/storage/ids-storage-compare': {}
         },
-        obj;
-
-    beforeEach(function (done) {
-        injector.mock(mocks);
-        injector.require(['Magento_Catalog/js/product/storage/storage-service'], function (insance) {
-            obj = insance;
-            done();
-        });
-    });
+        obj,
+        utils;
 
     afterEach(function () {
         try {
@@ -43,6 +32,19 @@ define([
             },
             storage;
 
+        beforeEach(function (done) {
+            injector.mock(mocks);
+            injector.require([
+                'Magento_Catalog/js/product/storage/ids-storage',
+                'Magento_Catalog/js/product/storage/storage-service',
+                'mageUtils'
+            ], function (IdsStorage, instance, mageUtils) {
+                obj = instance;
+                utils = mageUtils;
+                done();
+            });
+        });
+
         describe('"createStorage" method', function () {
             it('create new storage', function () {
                 obj.processSubscribers = jasmine.createSpy();
@@ -73,5 +75,54 @@ define([
                 expect(typeof obj.getStorage(config.namespace)).toBe('object');
             });
         });
+        describe('"add" method', function () {
+            var storageValue;
+
+            beforeEach(function () {
+                storage = new obj.createStorage(config);
+                storageValue = {
+                    'property1': 1
+                };
+
+                storage.set(storageValue);
+            });
+
+            it('method exists', function () {
+                expect(storage.add).toBeDefined();
+                expect(typeof storage.add).toEqual('function');
+            });
+
+            it('update value', function () {
+                spyOn(utils, 'copy').and.callThrough();
+                expect(storage.get()).toEqual(storageValue);
+
+                storageValue = {
+                    'property2': 2
+                };
+
+                storage.add(storageValue);
+
+                expect(utils.copy).toHaveBeenCalled();
+                expect(storage.get()).toEqual(
+                    {
+                        'property1': 1,
+                        'property2': 2
+                    }
+                );
+            });
+
+            it('add empty value', function () {
+                spyOn(utils, 'copy').and.callThrough();
+
+                storage.add({});
+
+                expect(utils.copy).not.toHaveBeenCalled();
+                expect(storage.get()).toEqual(
+                    {
+                        'property1': 1
+                    }
+                );
+            });
+        });
     });
 });