MAGETWO-87191: [Improvement] Add reporting instead of ignore action on schema processing

Author: rganin

app/etc/di.xml

@@ -1419,14 +1419,6 @@
         <arguments>
             <argument name="triggers" xsi:type="array">
                 <item name="migrateDataFromSameTable" xsi:type="object">Magento\Framework\Setup\Declaration\Schema\Db\MySQL\DDL\Triggers\MigrateDataFrom</item>
-                <item name="migrateDataFromAnotherTable" xsi:type="object">Magento\Framework\Setup\Declaration\Schema\Db\MySQL\DDL\Triggers\MigrateDataFromAnotherTable</item>
-            </argument>
-        </arguments>
-    </type>
-    <type name="Magento\Framework\Setup\Declaration\Schema\Operations\CreateTable">
-        <arguments>
-            <argument name="triggers" xsi:type="array">
-                <item name="migrateDataFromAnotherTable" xsi:type="object">Magento\Framework\Setup\Declaration\Schema\Db\MySQL\DDL\Triggers\MigrateDataFromAnotherTable</item>
             </argument>
         </arguments>
     </type>
@@ -1513,4 +1505,9 @@
             <argument name="schemaPatchReader" xsi:type="object">\Magento\Framework\Setup\Patch\SchemaPatchReader</argument>
         </arguments>
     </type>
+    <type name="Magento\Framework\Setup\Declaration\Schema\Db\SchemaBuilder">
+        <arguments>
+            <argument name="logger" xsi:type="object">\Magento\Framework\Setup\Patch\DataPatchReader</argument>
+        </arguments>
+    </type>
 </config>

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/MySQL/DDL/Triggers/MigrateDataFromAnotherTable.php

@@ -174,13 +174,14 @@ private function resolveInternalRelations(array $columns, array $data)
         foreach ($data['column'] as $columnName) {
             if (!isset($columns[$columnName])) {
                 $tableName = isset($data['table']) ? $data['table']->getName() : '';
-                throw new Exception(
+                trigger_error(
                     __(
                         'Column %1 does not exist for index/constraint %2 in table %3.',
                         $columnName,
                         $data['name'],
                         $tableName
-                    )
+                    ),
+                    E_USER_WARNING
                 );
             } else {
                 $referenceColumns[] = $columns[$columnName];

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/SchemaBuilder.php

@@ -228,7 +228,14 @@ public function applySchemaPatch($moduleName = null)
                 $schemaPatch->apply();
                 $this->patchHistory->fixPatch(get_class($schemaPatch));
             } catch (\Exception $e) {
-                throw new Exception($e->getMessage());
+                throw new Exception(
+                    __(
+                        'Unable to apply patch %1 for module %2. Original exception message: %3',
+                        get_class($schemaPatch),
+                        $moduleName,
+                        $e->getMessage()
+                    )
+                );
             } finally {
                 unset($schemaPatch);
             }

lib/internal/Magento/Framework/Setup/Patch/PatchApplier.php

@@ -287,8 +287,9 @@ public function testBuild(array $columns, array $references, array $constraints,
      * @param array $references
      * @param array $constraints
      * @param array $indexes
-     * @expectedException \Magento\Framework\Setup\Exception
-     * @expectedExceptionMessage Column unknown_column does not exist for index/constraint FIRST_INDEX in table second_table
+     * @expectedException \PHPUnit\Framework\Exception
+     * @expectedExceptionMessage
+     * User Warning: Column unknown_column does not exist for index/constraint FIRST_INDEX in table second_table
      */
     public function testBuildUnknownIndexColumn(array $columns, array $references, array $constraints, array $indexes)
     {