Fixed code by recommendation.

Author: anzin

app/code/Magento/Contact/Controller/Index/Post.php

@@ -125,6 +125,7 @@ private function validatedParams()
             throw new LocalizedException(__('The email address is invalid. Verify the email address and try again.'));
         }
         if (trim($request->getParam('hideit', '')) !== '') {
+            // phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception();
         }
 

app/code/Magento/Contact/Test/Unit/Controller/Index/PostTest.php

@@ -137,21 +137,19 @@ public function testExecuteEmptyPost(): void
 
     /**
      * Test exceute post validation
+     *
      * @param array $postData
-     * @param bool $exceptionExpected
      * @dataProvider postDataProvider
      */
-    public function testExecutePostValidation($postData, $exceptionExpected): void
+    public function testExecutePostValidation($postData): void
     {
         $this->stubRequestPostData($postData);
+        $this->messageManagerMock->expects($this->once())
+            ->method('addErrorMessage');
+        $this->dataPersistorMock->expects($this->once())
+            ->method('set')
+            ->with('contact_us', $postData);
 
-        if ($exceptionExpected) {
-            $this->messageManagerMock->expects($this->once())
-                ->method('addErrorMessage');
-            $this->dataPersistorMock->expects($this->once())
-                ->method('set')
-                ->with('contact_us', $postData);
-        }
 
         $this->controller->execute();
     }
@@ -162,12 +160,12 @@ public function testExecutePostValidation($postData, $exceptionExpected): void
     public function postDataProvider(): array
     {
         return [
-            [['name' => null, 'comment' => null, 'email' => '', 'hideit' => 'no'], true],
-            [['name' => 'test', 'comment' => '', 'email' => '', 'hideit' => 'no'], true],
-            [['name' => '', 'comment' => 'test', 'email' => '', 'hideit' => 'no'], true],
-            [['name' => '', 'comment' => '', 'email' => 'test', 'hideit' => 'no'], true],
-            [['name' => '', 'comment' => '', 'email' => '', 'hideit' => 'no'], true],
-            [['name' => 'Name', 'comment' => 'Name', 'email' => 'invalidmail', 'hideit' => 'no'], true],
+            [['name' => null, 'comment' => null, 'email' => '', 'hideit' => 'no']],
+            [['name' => 'test', 'comment' => '', 'email' => '', 'hideit' => 'no']],
+            [['name' => '', 'comment' => 'test', 'email' => '', 'hideit' => 'no']],
+            [['name' => '', 'comment' => '', 'email' => 'test', 'hideit' => 'no']],
+            [['name' => '', 'comment' => '', 'email' => '', 'hideit' => 'no']],
+            [['name' => 'Name', 'comment' => 'Name', 'email' => 'invalidmail', 'hideit' => 'no']],
         ];
     }
 
@@ -206,8 +204,8 @@ private function stubRequestPostData($post): void
         $this->requestStub->method('getPostValue')->willReturn($post);
         $this->requestStub->method('getParams')->willReturn($post);
         $this->requestStub->method('getParam')->willReturnCallback(
-            function ($key) use ($post) {
-                return $post[$key] ?? '';
+            function ($key, $defaultValue) use ($post) {
+                return $post[$key] ?? $defaultValue;
             }
         );
     }