Merge pull request #1529 from magento-tsg/2.0-develop-pr22

[TSG] Backporting for 2.0 (pr22) (2.0.17)

Author: vzabaznov

app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Edit/Tab/Advanced.php

@@ -16,6 +16,8 @@
 use Magento\Backend\Block\Widget\Form\Generic;
 use Magento\Config\Model\Config\Source\Yesno;
 use Magento\Eav\Helper\Data;
+use Magento\Eav\Block\Adminhtml\Attribute\PropertyLocker;
+use Magento\Framework\App\ObjectManager;
 
 class Advanced extends Generic
 {
@@ -36,6 +38,13 @@ class Advanced extends Generic
      */
     protected $disableScopeChangeList;
 
+    /**
+     * Disable form fields.
+     *
+     * @var \Magento\Eav\Block\Adminhtml\Attribute\PropertyLocker PropertyLocker
+     */
+    private $propertyLocker;
+
     /**
      * @param \Magento\Backend\Block\Template\Context $context
      * @param \Magento\Framework\Registry $registry
@@ -241,6 +250,8 @@ protected function _prepareForm()
             $form->getElement('is_global')->setDisabled(1);
         }
         $this->setForm($form);
+        $this->getPropertyLocker()->lock($form);
+
         return $this;
     }
 
@@ -264,4 +275,18 @@ private function getAttributeObject()
     {
         return $this->_coreRegistry->registry('entity_attribute');
     }
+
+    /**
+     * Get property locker.
+     *
+     * @return PropertyLocker
+     */
+    private function getPropertyLocker()
+    {
+        if (null === $this->propertyLocker) {
+            $this->propertyLocker = ObjectManager::getInstance()->get(PropertyLocker::class);
+        }
+        
+        return $this->propertyLocker;
+    }
 }

app/code/Magento/Catalog/Block/Product/View/Gallery.php

@@ -63,15 +63,13 @@ public function getGalleryImages()
                 );
                 $image->setData(
                     'medium_image_url',
-                    $this->_imageHelper->init($product, 'product_page_image_medium')
-                        ->constrainOnly(true)->keepAspectRatio(true)->keepFrame(false)
+                    $this->_imageHelper->init($product, 'product_page_image_medium_no_frame')
                         ->setImageFile($image->getFile())
                         ->getUrl()
                 );
                 $image->setData(
                     'large_image_url',
-                    $this->_imageHelper->init($product, 'product_page_image_large')
-                        ->constrainOnly(true)->keepAspectRatio(true)->keepFrame(false)
+                    $this->_imageHelper->init($product, 'product_page_image_large_no_frame')
                         ->setImageFile($image->getFile())
                         ->getUrl()
                 );

app/code/Magento/Catalog/Helper/Image.php

@@ -241,28 +241,29 @@ protected function setWatermarkProperties()
     {
         $this->setWatermark(
             $this->scopeConfig->getValue(
-                "design/watermark/{$this->_getModel()->getDestinationSubdir()}_image",
+                "design/watermark/{$this->getType()}_image",
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE
             )
         );
         $this->setWatermarkImageOpacity(
             $this->scopeConfig->getValue(
-                "design/watermark/{$this->_getModel()->getDestinationSubdir()}_imageOpacity",
+                "design/watermark/{$this->getType()}_imageOpacity",
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE
             )
         );
         $this->setWatermarkPosition(
             $this->scopeConfig->getValue(
-                "design/watermark/{$this->_getModel()->getDestinationSubdir()}_position",
+                "design/watermark/{$this->getType()}_position",
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE
             )
         );
         $this->setWatermarkSize(
             $this->scopeConfig->getValue(
-                "design/watermark/{$this->_getModel()->getDestinationSubdir()}_size",
+                "design/watermark/{$this->getType()}_size",
                 \Magento\Store\Model\ScopeInterface::SCOPE_STORE
             )
         );
+
         return $this;
     }
 
@@ -496,14 +497,14 @@ protected function initBaseFile()
      */
     protected function isScheduledActionsAllowed()
     {
+        $isAllowed = true;
         $model = $this->_getModel();
-        if ($model->isBaseFilePlaceholder()
-            && $model->getNewFile() === true
-            || $model->isCached()
-        ) {
-            return false;
+
+        if ($model->isBaseFilePlaceholder() || $model->isCached()) {
+            $isAllowed =  false;
         }
-        return true;
+
+        return $isAllowed;
     }
 
     /**

app/code/Magento/Catalog/Model/Product/Attribute/Backend/Media.php

@@ -194,7 +194,10 @@ public function afterSave($object)
             if (!empty($image['removed'])) {
                 if (!empty($image['value_id']) && !isset($picturesInOtherStores[$image['file']])) {
                     $recordsToDelete[] = $image['value_id'];
-                    $filesToDelete[] = ltrim($image['file'], '/');
+                    // only delete physical files if they are not used by any other products
+                    if ($this->resourceModel->countImageUses($image['file']) <= 1) {
+                        $filesToDelete[] = ltrim($image['file'], '/');
+                    }
                 }
                 continue;
             }