Skip to content

Commit 54358cf

Browse files
committed
MC-5806: Detection of URL dependencies does not work for the Dependency static test
1 parent b0366a2 commit 54358cf

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

app/code/Magento/Review/Test/Unit/Block/Adminhtml/RssTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ public function testGetRssData()
8181
],
8282
],
8383
];
84-
$productModel = $this->createPartialMock(\Magento\Catalog\Model\ResourceModel\Product::class, [
84+
$productModel = $this->createPartialMock(
85+
\Magento\Catalog\Model\ResourceModel\Product::class,
86+
[
8587
'getStoreId',
8688
'getId',
8789
'getReviewId',
@@ -90,7 +92,8 @@ public function testGetRssData()
9092
'getTitle',
9193
'getNickname',
9294
'getProductUrl'
93-
]);
95+
]
96+
);
9497
$storeModel = $this->createMock(\Magento\Store\Model\Store::class);
9598
$this->storeManagerInterface->expects($this->once())->method('getStore')->will($this->returnValue($storeModel));
9699
$storeModel->expects($this->once())->method('getName')

dev/tests/static/testsuite/Magento/Test/Legacy/LayoutTest.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111

1212
use Magento\Framework\Component\ComponentRegistrar;
1313

14+
/**
15+
* Layout test
16+
*/
1417
class LayoutTest extends \PHPUnit\Framework\TestCase
1518
{
1619
/**
@@ -85,6 +88,9 @@ class LayoutTest extends \PHPUnit\Framework\TestCase
8588
],
8689
];
8790

91+
/**
92+
* @throws \Exception
93+
*/
8894
public function testLayoutFile()
8995
{
9096
$invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
@@ -141,6 +147,11 @@ function ($layoutFile) {
141147
$componentRegistrar->getPath(ComponentRegistrar::MODULE, 'Magento_Shipping')
142148
. '/view/adminhtml/layout/adminhtml_order'
143149
)
150+
|| false !== strpos(
151+
$layoutFile,
152+
$componentRegistrar->getPath(ComponentRegistrar::MODULE, 'Magento_Catalog')
153+
. '/view/adminhtml/layout/catalog_product_grid.xml'
154+
)
144155
) {
145156
$this->markTestIncomplete(
146157
"The file {$layoutFile} has to use \\Magento\\Core\\Block\\Text\\List, \n" .
@@ -204,6 +215,9 @@ protected function _testObsoleteAttributes($layoutXml)
204215
}
205216
}
206217

218+
/**
219+
* @throws \Exception
220+
*/
207221
public function testActionNodeMethods()
208222
{
209223
$invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);

0 commit comments

Comments
 (0)