MTA-1499: Analyse functional test failures

Author: Dmytro Aponasenko

dev/tests/functional/lib/Magento/Mtf/Client/Element/OptgroupselectElement.php

@@ -9,42 +9,62 @@
 use Magento\Mtf\Client\Locator;
 
 /**
- * Class OptgroupselectElement
- * Typified element class for option group selectors
+ * Typified element class for option group selectors.
  */
 class OptgroupselectElement extends SelectElement
 {
     /**
-     * Option locator
+     * Option locator.
      *
      * @var string
      */
-    protected $optionByIndex = './/optgroup/option[%d]';
+    protected $optionByIndex = './/option';
 
     /**
-     * Option group selector
+     * Option group selector.
      *
      * @var string
      */
     protected $optGroup = 'optgroup[option[contains(.,"%s")]]';
 
     /**
-     * Get the value of form element
+     * Option group locator.
+     *
+     * @var string
+     */
+    protected $optionGroupValue = ".//optgroup[@label = '%s']/option[text() = '%s']";
+
+    /**
+     * Get the value of form element.
      *
      * @return string
+     * @throws \Exception
      */
     public function getValue()
     {
         $this->eventManager->dispatchEvent(['get_value'], [(string)$this->getAbsoluteSelector()]);
-        $selectedLabel = trim(parent::getValue());
+
+        $selectedLabel = '';
+        $labels = $this->getElements($this->optionByIndex, Locator::SELECTOR_XPATH);
+        foreach ($labels as $label) {
+            if ($label->isSelected()) {
+                $selectedLabel = $label->getText();
+                break;
+            }
+        }
+        if ($selectedLabel == '') {
+            throw new \Exception('Selected value has not been found in optgroup select.');
+        }
+
         $element = $this->find(sprintf($this->optGroup, $selectedLabel), Locator::SELECTOR_XPATH);
         $value = trim($element->getAttribute('label'), chr(0xC2) . chr(0xA0));
         $value .= '/' . $selectedLabel;
+
         return $value;
     }
 
     /**
-     * Select value in dropdown which has option groups
+     * Select value in dropdown which has option groups.
      *
      * @param string $value
      * @return void
@@ -53,6 +73,8 @@ public function setValue($value)
     {
         $this->eventManager->dispatchEvent(['set_value'], [__METHOD__, $this->getAbsoluteSelector()]);
         list($group, $option) = explode('/', $value);
-        parent::setOptionGroupValue($group, $option);
+        $xpath = sprintf($this->optionGroupValue, $group, $option);
+        $option = $this->find($xpath, Locator::SELECTOR_XPATH);
+        $option->click();
     }
 }

dev/tests/functional/tests/app/Magento/Bundle/Test/Fixture/BundleProduct/Price.php

@@ -92,6 +92,8 @@ public function getDataConfig()
      * Get preset array
      *
      * @return array|null
+     *
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function getPreset()
     {

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/AbstractConfigureBlock.php

@@ -97,7 +97,7 @@ protected function prepareCheckoutData(array $options, array $checkoutData)
 
             if (isset($options[$attribute])) {
                 $result[] = [
-                    'type' => strtolower(preg_replace('/[^a-z]/i', '', $options[$attribute]['type'])),
+                    'type' => $options[$attribute]['type'],
                     'title' => isset($options[$attribute]['title'])
                             ? $options[$attribute]['title']
                             : $attribute,

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.php

@@ -32,6 +32,13 @@ class AttributeForm extends FormTabs
      */
     protected $saveButton = '#save';
 
+    /**
+     * Attribute to determine whether tab is opened.
+     *
+     * @var string
+     */
+    protected $isTabOpened = '.opened ';
+
     /**
      * Fill the attribute form.
      *
@@ -64,10 +71,11 @@ public function openTab($tabName)
         $strategy = isset($this->tabs[$tabName]['strategy'])
             ? $this->tabs[$tabName]['strategy']
             : Locator::SELECTOR_CSS;
-        $tab = $this->_rootElement->find($selector, $strategy);
-        $target = $this->browser->find('.page-footer-wrapper'); // Handle menu overlap problem
-        $this->_rootElement->dragAndDrop($target);
-        $tab->click();
+
+        $isTabOpened = $this->_rootElement->find($this->isTabOpened . $selector, $strategy);
+        if (!$isTabOpened->isVisible()) {
+            $this->_rootElement->find($selector, $strategy)->click();
+        }
 
         return $this;
     }

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/AttributeForm.xml

@@ -28,7 +28,7 @@
         </fields>
     </properties>
     <advanced-properties>
-        <class>\Magento\Catalog\Test\Block\Adminhtml\Product\Attribute\Edit\Tab\Advanced</class>
+        <class>\Magento\Backend\Test\Block\Widget\Tab</class>
         <selector>[data-target="#advanced_fieldset-content"]</selector>
         <strategy>css selector</strategy>
         <fields>

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Attribute/Edit/AttributeForm.php

@@ -33,6 +33,13 @@ class AttributeForm extends FormTabs
      */
     protected $propertiesTab = '#product_attribute_tabs_main';
 
+    /**
+     * Page title.
+     *
+     * @var string
+     */
+    protected $pageTitle = '.page-title .title';
+
     /**
      * Get data of the tabs.
      *
@@ -94,15 +101,8 @@ protected function expandAllToggles()
      */
     public function openTab($tabName)
     {
-        $selector = $this->tabs[$tabName]['selector'];
-        $strategy = isset($this->tabs[$tabName]['strategy'])
-            ? $this->tabs[$tabName]['strategy']
-            : Locator::SELECTOR_CSS;
-        $tab = $this->_rootElement->find($selector, $strategy);
-        $target = $this->browser->find('.page-title .title');// Handle menu overlap problem
-        $this->_rootElement->dragAndDrop($target);
-        $tab->click();
-        return $this;
+        $this->browser->find($this->pageTitle)->click(); // Handle menu overlap problem
+        return parent::openTab($tabName);
     }
 
     /**

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Tab/Options.php

@@ -204,16 +204,17 @@ protected function prepareCustomOptions(array $options)
     /**
      * Convert option name
      *
-     * @param string $str
+     * @param string $inputType
      * @return string
      */
-    protected function optionNameConvert($str)
+    protected function optionNameConvert($inputType)
     {
-        $str = str_replace([' ', '&'], "", $str);
-        if ($end = strpos($str, '-')) {
-            $str = substr($str, 0, $end) . ucfirst(substr($str, ($end + 1)));
+        $option = substr($inputType, strpos($inputType, "/") + 1);
+        $option = str_replace([' ', '&'], "", $option);
+        if ($end = strpos($option, '-')) {
+            $option = substr($option, 0, $end) . ucfirst(substr($option, ($end + 1)));
         }
 
-        return $str;
+        return $option;
     }
 }

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Tab/ProductDetails.php

@@ -38,13 +38,19 @@ class ProductDetails extends \Magento\Catalog\Test\Block\Adminhtml\Product\Edit\
     public function fillFormTab(array $fields, SimpleElement $element = null)
     {
         $data = $this->dataMapping($fields);
-
+        // Select attribute set
+        if (isset($data['attribute_set_id'])) {
+            $this->_fill([$data['attribute_set_id']], $element);
+            unset($data['attribute_set_id']);
+        }
+        // Select categories
         if (isset($data['category_ids'])) {
             /* Fix browser behavior for click by hidden list result of suggest(category) element */
             $this->scrollToCategory();
             $this->_fill([$data['category_ids']], $element);
             unset($data['category_ids']);
         }
+
         $this->_fill($data, $element);
 
         return $this;

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Tab/ProductDetails/AttributeSet.php

@@ -28,6 +28,13 @@ class AttributeSet extends SuggestElement
      */
     protected $actionToggle = '.action-toggle';
 
+    /**
+     * Magento loader
+     *
+     * @var string
+     */
+    protected $loader = '[data-role="loader"]';
+
     /**
      * Set value
      *
@@ -40,6 +47,14 @@ public function setValue($value)
             $this->find($this->actionToggle)->click();
             parent::setValue($value);
         }
+        // Wait loader
+        $element = $this->driver;
+        $selector = $this->loader;
+        $element->waitUntil(
+            function () use ($element, $selector) {
+                return $element->find($selector)->isVisible() == false ? true : null;
+            }
+        );
     }
 
     /**

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/ProductForm.xml

@@ -162,7 +162,7 @@
             <type>
                 <selector>.field [id$='_type']</selector>
                 <strategy>css selector</strategy>
-                <input>strictselect</input>
+                <input>optgroupselect</input>
             </type>
         </fields>
     </customer-options>