🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - magento-engcom/magento2ce#1284: [EngCom Team] Batch 3. Forwardports to 2.3-develop (by @magento-engcom-team)
 - magento-engcom/magento2ce#1286: [EngCom Team] Batch 5. Forwardports to 2.3-develop (by @magento-engcom-team)


Fixed GitHub Issues:
 - #6891: Add-to-cart checkbox still visible when $canItemsAddToCart = false (reported by @thdoan) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #9763: When go checkout,Cart Price Rules 25%test coupon code can go wrong (reported by @michaeldyl520) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #9919: Pattern Validation via UI Component Fails to Interpret String as RegEx Pattern (reported by @bap14) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #9944: Name attribute shows empty when creating custom fields on product creation form (reported by @PatrickSH) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #10025: Integration tests don't reset the database (reported by @dersam) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #10275: Admin global search - submit by enter doesn't work (reported by @ihor-sviziev) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #10856: Sync billing with shipping address on Admin Reorder and Admin Customer Create Order page does not work for Existing address selected (reported by @NoorulBhoelai) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #11157: nginx.sample.conf missing heath_check.php? (reported by @craigcarnell) has been fixed in magento-engcom/magento2ce#1284 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #4004: Newsletter Subscriber create-date not set, and change_status_at broken (reported by @fvschie) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #7995: If you leave as default, shipping lines disappear (reported by @rosandrest) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #8846: Attribute option value uniqueness is not checked if created via REST Api (reported by @hilrob) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #8954: Error While Trying To Load Quote Item Collection Using Magento\Quote\Model\ResourceModel\QuoteItem\Collection::getItems() (reported by @rendyep) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #9028: You cannot set a 303 redirect response using a result factory (reported by @jameshalsall) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #10583: Checkout place order exception when using a new address (reported by @mbijnsdorp) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #11700: "Something Went Wrong" error for limited access admin user (reported by @expgabe) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:


 - #12017: Cross-sell product placeholder image size issue (reported by @emiprotech) has been fixed in magento-engcom/magento2ce#1286 by @magento-engcom-team in 2.3-develop branch
   Related commits:

Author: magento-team

app/code/Magento/Catalog/Model/Product/Attribute/OptionManagement.php

@@ -40,6 +40,17 @@ public function getItems($attributeCode)
      */
     public function add($attributeCode, $option)
     {
+        /** @var \Magento\Eav\Api\Data\AttributeOptionInterface[] $currentOptions */
+        $currentOptions = $this->getItems($attributeCode);
+        if (is_array($currentOptions)) {
+            array_walk($currentOptions, function (&$attributeOption) {
+                /** @var \Magento\Eav\Api\Data\AttributeOptionInterface $attributeOption */
+                    $attributeOption = $attributeOption->getLabel();
+            });
+            if (in_array($option->getLabel(), $currentOptions)) {
+                return false;
+            }
+        }
         return $this->eavOptionManagement->add(
             \Magento\Catalog\Api\Data\ProductAttributeInterface::ENTITY_TYPE_CODE,
             $attributeCode,

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/js.phtml

@@ -196,9 +196,11 @@ function switchDefaultValueField()
 
         <?php foreach ($this->helper('Magento\Catalog\Helper\Data')->getAttributeHiddenFields() as $type => $fields): ?>
             case '<?= /* @escapeNotVerified */ $type ?>':
+                var isFrontTabHidden = false;
                 <?php foreach ($fields as $one): ?>
                     <?php if ($one == '_front_fieldset'): ?>
                         getFrontTab().hide();
+                        isFrontTabHidden = true;
                     <?php elseif ($one == '_default_value'): ?>
                         defaultValueTextVisibility =
                         defaultValueTextareaVisibility =
@@ -210,6 +212,10 @@ function switchDefaultValueField()
                         setRowVisibility('<?= /* @escapeNotVerified */ $one ?>', false);
                     <?php endif; ?>
                 <?php endforeach; ?>
+
+                if (!isFrontTabHidden){
+                  getFrontTab().show();
+                }
             break;
         <?php endforeach; ?>
 

app/code/Magento/Catalog/view/frontend/templates/product/list/items.phtml

@@ -202,7 +202,7 @@ switch ($type = $block->getType()) {
                                 <?= $block->getReviewsSummaryHtml($_item, $templateType) ?>
                             <?php endif; ?>
 
-                            <?php if (!$_item->isComposite() && $_item->isSaleable() && $type == 'related'): ?>
+                            <?php if ($canItemsAddToCart && !$_item->isComposite() && $_item->isSaleable() && $type == 'related'): ?>
                                 <?php if (!$_item->getRequiredOptions()): ?>
                                     <div class="field choice related">
                                         <input type="checkbox" class="checkbox related" id="related-checkbox<?= /* @escapeNotVerified */ $_item->getId() ?>" name="related_products[]" value="<?= /* @escapeNotVerified */ $_item->getId() ?>" />

app/code/Magento/Checkout/view/frontend/web/js/model/resource-url-manager.js

@@ -75,8 +75,8 @@ define([
                             quoteId: quoteId
                         } : {},
                     urls = {
-                        'guest': '/guest-carts/' + quoteId + '/coupons/' + couponCode,
-                        'customer': '/carts/mine/coupons/' + couponCode
+                        'guest': '/guest-carts/' + quoteId + '/coupons/' + encodeURIComponent(couponCode),
+                        'customer': '/carts/mine/coupons/' + encodeURIComponent(couponCode)
                     };
 
                 return this.getUrl(urls, params);

app/code/Magento/Customer/etc/adminhtml/system.xml

@@ -198,7 +198,8 @@
                 <field id="street_lines" translate="label comment" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1">
                     <label>Number of Lines in a Street Address</label>
                     <backend_model>Magento\Customer\Model\Config\Backend\Address\Street</backend_model>
-                    <comment>Leave empty for default (2). Valid range: 1-4</comment>
+                    <comment>Valid range: 1-4</comment>
+                    <validate>required-entry validate-digits validate-digits-range digits-range-1-4</validate>
                 </field>
                 <field id="prefix_show" translate="label comment" type="select" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="0">
                     <label>Show Prefix</label>

app/code/Magento/Eav/Model/Entity/Attribute/Backend/JsonEncoded.php

@@ -58,7 +58,7 @@ public function afterLoad($object)
     {
         parent::afterLoad($object);
         $attrCode = $this->getAttribute()->getAttributeCode();
-        $object->setData($attrCode, $this->jsonSerializer->unserialize($object->getData($attrCode)));
+        $object->setData($attrCode, $this->jsonSerializer->unserialize($object->getData($attrCode) ?: '{}'));
         return $this;
     }
 }

app/code/Magento/Eav/Test/Unit/Model/Entity/Attribute/Backend/JsonEncodedTest.php

@@ -95,4 +95,18 @@ public function testAfterLoad()
         $this->model->afterLoad($product);
         $this->assertEquals([1, 2, 3], $product->getData('json_encoded'));
     }
+
+    /**
+     * Test after load handler with null attribute value
+     */
+    public function testAfterLoadWithNullAttributeValue()
+    {
+        $product = new \Magento\Framework\DataObject(
+            [
+                'json_encoded' => null
+            ]
+        );
+        $this->model->afterLoad($product);
+        $this->assertEquals([], $product->getData('json_encoded'));
+    }
 }

app/code/Magento/Newsletter/Model/Subscriber.php

@@ -94,6 +94,12 @@ class Subscriber extends \Magento\Framework\Model\AbstractModel
      */
     protected $_customerSession;
 
+    /**
+     * Date
+     * @var \Magento\Framework\Stdlib\DateTime\DateTime
+     */
+    private $dateTime;
+
     /**
      * Store manager
      *
@@ -134,9 +140,10 @@ class Subscriber extends \Magento\Framework\Model\AbstractModel
      * @param CustomerRepositoryInterface $customerRepository
      * @param AccountManagementInterface $customerAccountManagement
      * @param \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
-     * @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource
-     * @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
+     * @param \Magento\Framework\Model\ResourceModel\AbstractResource|null $resource
+     * @param \Magento\Framework\Data\Collection\AbstractDb|null $resourceCollection
      * @param array $data
+     * @param \Magento\Framework\Stdlib\DateTime\DateTime|null $dateTime
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -152,13 +159,17 @@ public function __construct(
         \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,
         \Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
         \Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
-        array $data = []
+        array $data = [],
+        \Magento\Framework\Stdlib\DateTime\DateTime $dateTime = null
     ) {
         $this->_newsletterData = $newsletterData;
         $this->_scopeConfig = $scopeConfig;
         $this->_transportBuilder = $transportBuilder;
         $this->_storeManager = $storeManager;
         $this->_customerSession = $customerSession;
+        $this->dateTime = $dateTime ?: \Magento\Framework\App\ObjectManager::getInstance()->get(
+            \Magento\Framework\Stdlib\DateTime\DateTime::class
+        );
         $this->customerRepository = $customerRepository;
         $this->customerAccountManagement = $customerAccountManagement;
         $this->inlineTranslation = $inlineTranslation;
@@ -812,4 +823,18 @@ public function getSubscriberFullName()
         }
         return $name;
     }
+
+    /**
+     * Set date of last changed status
+     *
+     * @return $this
+     */
+    public function beforeSave()
+    {
+        parent::beforeSave();
+        if ($this->dataHasChangedFor('subscriber_status')) {
+            $this->setChangeStatusAt($this->dateTime->gmtDate());
+        }
+        return $this;
+    }
 }

app/code/Magento/OfflineShipping/Model/Carrier/Tablerate.php

@@ -113,8 +113,9 @@ public function collectRates(RateRequest $request)
 
         // Free shipping by qty
         $freeQty = 0;
+        $freePackageValue = 0;
+
         if ($request->getAllItems()) {
-            $freePackageValue = 0;
             foreach ($request->getAllItems() as $item) {
                 if ($item->getProduct()->isVirtual() || $item->getParentItem()) {
                     continue;

app/code/Magento/Quote/Model/Quote.php

@@ -1046,7 +1046,7 @@ public function addCustomerAddress(\Magento\Customer\Api\Data\AddressInterface $
     public function updateCustomerData(\Magento\Customer\Api\Data\CustomerInterface $customer)
     {
         $quoteCustomer = $this->getCustomer();
-        $this->dataObjectHelper->mergeDataObjects(get_class($quoteCustomer), $quoteCustomer, $customer);
+        $this->dataObjectHelper->mergeDataObjects(CustomerInterface::class, $quoteCustomer, $customer);
         $this->setCustomer($quoteCustomer);
         return $this;
     }