Use of parse_url PHP_URL_PATH variable.

Pieter Cappelle · Pieter Cappelle · commit 53292d370740 · 2017-12-30T12:41:58.000+01:00
diff --git a/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php b/app/code/Magento/CatalogImportExport/Model/Import/Uploader.php
@@ -162,9 +162,9 @@ public function move($fileName, $renameFileOff = false)
             }
 
             //only use filename (for URI with query parameters)
-            $parsedUrl = parse_url($url);
-            if ($parsedUrl['path']) {
-                $urlPathValues = explode('/', $parsedUrl['path']);
+            $parsedUrlPath = parse_url($url, PHP_URL_PATH);
+            if ($parsedUrlPath) {
+                $urlPathValues = explode('/', $parsedUrlPath);
                 if (!empty($urlPathValues)) {
                     $fileName = end($urlPathValues);
                 }

Original file line number	Diff line number	Diff line change
`@@ -162,9 +162,9 @@ public function move($fileName, $renameFileOff = false)`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`//only use filename (for URI with query parameters)`
`165`		`- $parsedUrl = parse_url($url);`
`166`		`- if ($parsedUrl['path']) {`
`167`		`- $urlPathValues = explode('/', $parsedUrl['path']);`
	`165`	`+ $parsedUrlPath = parse_url($url, PHP_URL_PATH);`
	`166`	`+ if ($parsedUrlPath) {`
	`167`	`+ $urlPathValues = explode('/', $parsedUrlPath);`
`168`	`168`	`if (!empty($urlPathValues)) {`
`169`	`169`	`$fileName = end($urlPathValues);`
`170`	`170`	`}`