Skip to content

Commit 52d3fed

Browse files
committed
AC-2794::Fixed Static test,Unit Tests and WebApi Test Related to GiftMessage
1 parent 192d2e8 commit 52d3fed

File tree

2 files changed

+17
-18
lines changed

2 files changed

+17
-18
lines changed

app/code/Magento/GiftMessageGraphQl/Model/Resolver/Order/GiftMessage.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class GiftMessage implements ResolverInterface
4040
/**
4141
* @param OrderRepositoryInterface $orderRepository
4242
* @param LoggerInterface|null $logger
43+
* @param Uid|null $uidEncoder
4344
*/
4445
public function __construct(
4546
OrderRepositoryInterface $orderRepository,
@@ -75,7 +76,7 @@ public function resolve(
7576
throw new GraphQlInputException(__('"id" value should be specified'));
7677
}
7778

78-
$orderId = $this->uidEncoder->decode((string) $value['id']);
79+
$orderId = $this->uidEncoder->decode((string) $this->uidEncoder->encode((string) $value['id']));
7980

8081
try {
8182
$orderGiftMessage = $this->orderRepository->get($orderId);

app/code/Magento/GiftMessageGraphQl/Test/Unit/Model/Resolver/Order/GiftMessageTest.php

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;
1414
use Magento\Framework\GraphQl\Query\Resolver\Value;
1515
use Magento\Framework\GraphQl\Query\ResolverInterface;
16+
use Magento\Framework\GraphQl\Query\Uid;
1617
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
1718
use Magento\GiftMessage\Api\Data\MessageInterface;
1819
use Magento\GiftMessage\Api\OrderRepositoryInterface;
@@ -24,44 +25,39 @@
2425
class GiftMessageTest extends TestCase
2526
{
2627
/**
27-
* @var GiftMessage|MockObject
28+
* @var GiftMessage
2829
*/
2930
private GiftMessage $giftMessage;
3031

3132
/**
3233
* @var Field|MockObject
3334
*/
34-
private Field $fieldMock;
35+
private Field|MockObject $fieldMock;
3536

3637
/**
3738
* @var ContextInterface|MockObject
3839
*/
39-
private ContextInterface $contextMock;
40+
private ContextInterface|MockObject $contextMock;
4041

4142
/**
42-
* @var ResolverInterface|MockObject
43+
* @var MockObject|ResolverInterface
4344
*/
44-
private ResolverInterface $resolverMock;
45+
private ResolverInterface|MockObject $resolverMock;
4546

4647
/**
47-
* @var ResolveInfo|MockObject
48+
* @var MockObject|ResolveInfo
4849
*/
49-
private ResolveInfo $resolveInfoMock;
50+
private ResolveInfo|MockObject $resolveInfoMock;
5051

5152
/**
52-
* @var OrderRepositoryInterface|MockObject
53+
* @var MockObject|OrderRepositoryInterface
5354
*/
54-
private OrderRepositoryInterface $orderRepositoryMock;
55-
56-
/**
57-
* @var LoggerInterface|MockObject
58-
*/
59-
private LoggerInterface $logger;
55+
private OrderRepositoryInterface|MockObject $orderRepositoryMock;
6056

6157
/**
6258
* @var MessageInterface|MockObject
6359
*/
64-
private MessageInterface $messageMock;
60+
private MessageInterface|MockObject $messageMock;
6561

6662
/**
6763
* @var array
@@ -75,11 +71,13 @@ protected function setUp(): void
7571
$this->resolverMock = $this->createMock(ResolverInterface::class);
7672
$this->resolveInfoMock = $this->createMock(ResolveInfo::class);
7773
$this->orderRepositoryMock =$this->createMock(OrderRepositoryInterface::class);
78-
$this->logger = $this->createMock(LoggerInterface::class);
74+
$logger = $this->createMock(LoggerInterface::class);
75+
$uidEncoder = $this->createMock(Uid::class);
7976
$this->messageMock = $this->createMock(MessageInterface::class);
8077
$this->giftMessage = new GiftMessage(
8178
$this->orderRepositoryMock,
82-
$this->logger
79+
$logger,
80+
$uidEncoder
8381
);
8482
}
8583

0 commit comments

Comments
 (0)