Skip to content

Commit 528d9c3

Browse files
committed
B2B-2931: [Graphql Resolver Cache] improve reliability and developer awareness on cache keyspace
1 parent dea5adb commit 528d9c3

File tree

2 files changed

+2
-4
lines changed
  • app/code/Magento/GraphQlResolverCache/Model/Resolver/Result/CacheKey/Calculator
  • dev/tests/integration/testsuite/Magento/GraphQlResolverCache/Model/Resolver/Result/Cache/KeyCalculator

2 files changed

+2
-4
lines changed

app/code/Magento/GraphQlResolverCache/Model/Resolver/Result/CacheKey/Calculator/Provider.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ private function initForResolver(ResolverInterface $resolver): void
5959
$customKeyFactorProviders = $this->getFactorProvidersForResolver($resolver);
6060
if ($customKeyFactorProviders === null) {
6161
throw new \InvalidArgumentException(
62-
"GraphQL Resolver Cache key factors are not determined for {$resolverClass} or its parents." .
63-
"An empty array of factors is expected for the resolvers with no factors involved."
62+
"GraphQL Resolver Cache key factors are not determined for {$resolverClass} or its parents."
6463
);
6564
} else {
6665
$runtimePoolKey = $this->generateCustomProvidersKey($customKeyFactorProviders);
@@ -83,7 +82,7 @@ private function initForResolver(ResolverInterface $resolver): void
8382
private function generateCustomProvidersKey(array $customProviders): string
8483
{
8584
if (empty($customProviders)) {
86-
return "empty";
85+
return '';
8786
}
8887
$keyArray = array_keys($customProviders);
8988
sort($keyArray);

dev/tests/integration/testsuite/Magento/GraphQlResolverCache/Model/Resolver/Result/Cache/KeyCalculator/ProviderTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ public function testProviderNotConfigured()
5858
$resolverClass = get_class($resolver);
5959
$this->expectExceptionMessage(
6060
"GraphQL Resolver Cache key factors are not determined for {$resolverClass} or its parents."
61-
. "An empty array of factors is expected for the resolvers with no factors involved."
6261
);
6362
$this->provider->getKeyCalculatorForResolver($resolver);
6463
}

0 commit comments

Comments
 (0)