Skip to content

Commit 526d2d2

Browse files
committed
Refactoring ActionGroups
1 parent 90a379c commit 526d2d2

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontCustomerElementNotVisibleActionGroup.xml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="StorefrontCustomerElementNotVisibleActionGroup">
11-
<arguments>
12-
<argument name="selector" type="string"/>
13-
</arguments>
14-
<dontSeeElement selector="{{selector}}" stepKey="assertNotVisibleElement"/>
10+
<actionGroup name="StorefrontCustomerReorderButtonNotVisibleActionGroup">
11+
<dontSeeElement selector="{{StorefrontCustomerOrderViewSection.reorder}}" stepKey="assertNotVisibleElement"/>
1512
</actionGroup>
1613
</actionGroups>

app/code/Magento/Customer/Test/Mftf/ActionGroup/NavigateToCustomerAccountPageActionGroup.xml renamed to app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontNavigateToCustomerOrdersHistoryPageActionGroup.xml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,8 @@
77
-->
88
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
10-
<actionGroup name="NavigateToCustomerAccountPageActionGroup">
11-
<arguments>
12-
<argument name="page" type="string"/>
13-
</arguments>
14-
<amOnPage url="{{page}}" stepKey="amOnTheCustomerPage"/>
10+
<actionGroup name="StorefrontNavigateToCustomerOrdersHistoryPageActionGroup">
11+
<amOnPage url="{{StorefrontCustomerOrdersHistoryPage.url}}" stepKey="amOnTheCustomerPage"/>
1512
<waitForPageLoad stepKey="waitForPageLoad"/>
1613
</actionGroup>
1714
</actionGroups>

app/code/Magento/Sales/Test/Mftf/Test/AdminCreateOrderAndCheckTheReorderTest.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,8 @@
4141
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="frontendCustomerLogIn">
4242
<argument name="Customer" value="$$simpleCustomer$$"/>
4343
</actionGroup>
44-
<actionGroup ref="NavigateToCustomerAccountPageActionGroup" stepKey="goToOrderHistoryPage">
45-
<argument name="page" value="{{StorefrontCustomerOrdersHistoryPage.url}}"/>
46-
</actionGroup>
47-
<actionGroup ref="StorefrontCustomerElementNotVisibleActionGroup" stepKey="checkReorderButton">
48-
<argument name="selector" value="{{StorefrontCustomerOrderViewSection.reorder}}"/>
49-
</actionGroup>
44+
<actionGroup ref="StorefrontNavigateToCustomerOrdersHistoryPageActionGroup" stepKey="goToOrderHistoryPage"/>
45+
<actionGroup ref="StorefrontCustomerReorderButtonNotVisibleActionGroup" stepKey="checkReorderButton"/>
5046
<after>
5147
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogout"/>
5248
<actionGroup ref="logout" stepKey="adminLogout"/>

0 commit comments

Comments
 (0)