Skip to content

Commit 51b5080

Browse files
MC-29566: [2.4.x] Deprecate SID query parameter-related methods
1 parent 20037ec commit 51b5080

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

app/code/Magento/Theme/Test/Unit/Model/Design/Backend/ImageTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function setUp(): void
7070
/**
7171
* @inheritdoc
7272
*/
73-
public function tearDown()
73+
public function tearDown(): void
7474
{
7575
unset($this->imageBackend);
7676
}

dev/tests/integration/testsuite/Magento/Catalog/Model/ResourceModel/Eav/AttributeTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,15 @@ public function testCRUD()
6767
/**
6868
* @magentoDataFixture Magento/Catalog/_files/product_attribute.php
6969
*
70-
* @expectedException \Magento\Framework\Exception\LocalizedException
71-
* @expectedExceptionMessage Do not change entity type.
72-
*
7370
* @return void
7471
*/
7572
public function testAttributeSaveWithChangedEntityType(): void
7673
{
74+
$this->expectException(
75+
\Magento\Framework\Exception\LocalizedException::class
76+
);
77+
$this->expectExceptionMessage('Do not change entity type.');
78+
7779
$attribute = $this->attributeRepository->get($this->catalogProductEntityType, 'test_attribute_code_333');
7880
$attribute->setEntityTypeId(1);
7981
$attribute->save();

dev/tests/integration/testsuite/Magento/Customer/Model/AttributeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class AttributeTest extends \PHPUnit\Framework\TestCase
4141
/**
4242
* @inheritDoc
4343
*/
44-
protected function setUp()
44+
protected function setUp(): void
4545
{
4646
$this->objectManager = Bootstrap::getObjectManager();
4747
$this->model = $this->objectManager->get(Attribute::class);

dev/tests/integration/testsuite/Magento/Customer/Model/Metadata/Form/ImageTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class ImageTest extends \PHPUnit\Framework\TestCase
5555
/**
5656
* @inheritDoc
5757
*/
58-
public function setUp()
58+
public function setUp(): void
5959
{
6060
$this->objectManager = Bootstrap::getObjectManager();
6161
$this->filesystem = $this->objectManager->get(Filesystem::class);
@@ -199,7 +199,7 @@ public function testProcessCustomerInvalidValue()
199199
* @inheritdoc
200200
* @throws FileSystemException
201201
*/
202-
public static function tearDownAfterClass()
202+
public static function tearDownAfterClass(): void
203203
{
204204
parent::tearDownAfterClass();
205205
$filesystem = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(

0 commit comments

Comments
 (0)